Dont catch the origional exceptions in the command executor, the caller should know whats going on

Author: Bas Visscher

ESPTool/Loaders/ESP32BootLoader/BootLoaderCommandExecutor.cs

@@ -18,39 +18,26 @@ public BootLoaderCommandExecutor(Communicator communicator)
         /// <exception cref="OperationCanceledException">Thrown if the operation is canceled via the token.</exception>
         public async Task<ResponseCommand> ExecuteCommandAsync(RequestCommand requestCommand, CancellationToken token)
         {
-            try
-            {
-                _communicator.ClearBuffer();
+            _communicator.ClearBuffer();
 
-                // Convert the RequestCommand to a Frame
-                Frame requestFrame = RequestToFrame(requestCommand);
+            // Convert the RequestCommand to a Frame
+            Frame requestFrame = RequestToFrame(requestCommand);
 
-                // Write the frame to the communicator
-                await _communicator.WriteFrameAsync(requestFrame, token);
+            // Write the frame to the communicator
+            await _communicator.WriteFrameAsync(requestFrame, token);
 
-                // Read the response frame
-                Frame responseFrame = await _communicator.ReadFrameAsync(token) ?? throw new Exception("No frame received");
+            // Read the response frame
+            Frame responseFrame = await _communicator.ReadFrameAsync(token) ?? throw new Exception("No frame received");
 
-                // Convert the response frame back to a ResponseCommand
-                var response = FrameToResponse(responseFrame);
+            // Convert the response frame back to a ResponseCommand
+            var response = FrameToResponse(responseFrame);
 
-                // Check
-                if (response.Command != requestCommand.Command)
-                {
-                    throw new Exception("Response didnt match");
-                }
-                return response;
-
-            }
-
-            catch (OperationCanceledException)
-            {
-                throw new OperationCanceledException("Frame operation was canceled.", token);
-            }
-            catch (Exception ex)
+            // Check
+            if (response.Command != requestCommand.Command)
             {
-                throw new InvalidOperationException("Failed to send or receive frame.", ex);
+                throw new Exception("Response didnt match");
             }
+            return response;
         }
 
         private static Frame RequestToFrame(RequestCommand command)

ESPTool/Loaders/SoftLoader/SoftLoaderCommandExecutor.cs

@@ -19,39 +19,26 @@ public SoftLoaderCommandExecutor(Communicator communicator)
         /// <exception cref="OperationCanceledException">Thrown if the operation is canceled via the token.</exception>
         public async Task<ResponseCommand> ExecuteCommandAsync(RequestCommand requestCommand, CancellationToken token)
         {
-            try
-            {
-                _communicator.ClearBuffer();
-
-                // Convert the RequestCommand to a Frame
-                Frame requestFrame = RequestToFrame(requestCommand);
+            _communicator.ClearBuffer();
 
-                // Write the frame to the communicator
-                await _communicator.WriteFrameAsync(requestFrame, token);
+            // Convert the RequestCommand to a Frame
+            Frame requestFrame = RequestToFrame(requestCommand);
 
-                // Read the response frame
-                Frame responseFrame = await _communicator.ReadFrameAsync(token) ?? throw new Exception("No frame received");
+            // Write the frame to the communicator
+            await _communicator.WriteFrameAsync(requestFrame, token);
 
-                // Convert the response frame back to a ResponseCommand
-                var response = FrameToResponse(responseFrame);
-
-                // Check
-                if (response.Command != requestCommand.Command)
-                {
-                    throw new Exception("Response didnt match");
-                }
-                return response;
+            // Read the response frame
+            Frame responseFrame = await _communicator.ReadFrameAsync(token) ?? throw new Exception("No frame received");
 
-            }
+            // Convert the response frame back to a ResponseCommand
+            var response = FrameToResponse(responseFrame);
 
-            catch (OperationCanceledException)
+            // Check
+            if (response.Command != requestCommand.Command)
             {
-                throw new OperationCanceledException("Frame operation was canceled.", token);
-            }
-            catch (Exception ex)
-            {
-                throw new InvalidOperationException("Failed to send or receive frame.", ex);
+                throw new Exception("Response didnt match");
             }
+            return response;
         }
 
         private static Frame RequestToFrame(RequestCommand command)