dont wait for chat session deletion (#361)

Author: lucascanna

src/app/(project-workspace)/projects/[id]/components/chat/chat-sidebar.tsx

@@ -65,7 +65,6 @@ export default function ChatSidebar({
 
     // Loading states
     isCreating,
-    isDeleting,
   } = useChatSidebar({
     projectId,
     onChatSessionChange,
@@ -170,7 +169,6 @@ export default function ChatSidebar({
         open={!!deletingSession}
         onOpenChange={open => !open && setDeletingSession(null)}
         onConfirm={confirmDeleteSession}
-        isDeleting={isDeleting}
       />
     </div>
   );

src/app/(project-workspace)/projects/[id]/components/chat/delete-chat-session-dialog.tsx

@@ -1,6 +1,6 @@
 'use client';
 
-import { AlertTriangle, Loader2, Trash2 } from 'lucide-react';
+import { AlertTriangle, Trash2 } from 'lucide-react';
 
 import { Button } from '@/components/ui/button';
 import {
@@ -17,30 +17,24 @@ interface DeleteChatSessionDialogProps {
   open: boolean;
   onOpenChange: (open: boolean) => void;
   onConfirm: (session: ChatSession) => void | Promise<void>;
-  isDeleting: boolean;
 }
 
 export function DeleteChatSessionDialog({
   session,
   open,
   onOpenChange,
   onConfirm,
-  isDeleting,
 }: DeleteChatSessionDialogProps) {
-  const handleDelete = async () => {
+  const handleDelete = () => {
     if (!session) return;
-    await onConfirm(session);
+    // Close modal immediately for optimistic UI
+    onOpenChange(false);
+    // Fire and forget - don't await the response
+    onConfirm(session);
   };
 
   return (
-    <Dialog
-      open={open}
-      onOpenChange={value => {
-        // Prevent closing while deletion is in progress
-        if (isDeleting) return;
-        onOpenChange(value);
-      }}
-    >
+    <Dialog open={open} onOpenChange={onOpenChange}>
       <DialogContent className="sm:max-w-[425px] border border-border bg-card">
         <DialogHeader>
           <div className="flex items-center gap-2">
@@ -68,18 +62,11 @@ export function DeleteChatSessionDialog({
         </div>
 
         <DialogFooter className="mt-6">
-          <Button variant="outline" onClick={() => onOpenChange(false)} disabled={isDeleting}>
+          <Button variant="outline" onClick={() => onOpenChange(false)}>
             Cancel
           </Button>
-          <Button variant="destructive" onClick={handleDelete} disabled={isDeleting}>
-            {isDeleting ? (
-              <>
-                <Loader2 className="h-4 w-4 animate-spin mr-2" />
-                <span>Deleting...</span>
-              </>
-            ) : (
-              'Delete Session'
-            )}
+          <Button variant="destructive" onClick={handleDelete}>
+            Delete Session
           </Button>
         </DialogFooter>
       </DialogContent>

src/hooks/use-chat-sidebar.ts

@@ -110,11 +110,10 @@ export function useChatSidebar({
     setDeletingSession(session);
   }, []);
 
-  // Confirm and execute session deletion
+  // Confirm and execute session deletion (fire and forget - dialog closes immediately)
   const confirmDeleteSession = useCallback(
-    async (session: ChatSession) => {
-      await deleteChatSession.mutateAsync(session.id);
-      setDeletingSession(null);
+    (session: ChatSession) => {
+      deleteChatSession.mutate(session.id);
     },
     [deleteChatSession]
   );
@@ -172,6 +171,5 @@ export function useChatSidebar({
     // Loading states
     isCreating: createChatSession.isPending,
     isUpdating: updateChatSession.isPending,
-    isDeleting: deleteChatSession.isPending,
   };
 }

src/lib/types/chat-sessions.ts

@@ -90,7 +90,7 @@ export interface UseChatSidebarReturn {
   handleCreateChat: () => Promise<void>;
   handleUpdateSession: (session: ChatSession, updates: Partial<ChatSession>) => Promise<void>;
   handleDeleteSession: (session: ChatSession) => void;
-  confirmDeleteSession: (session: ChatSession) => Promise<void>;
+  confirmDeleteSession: (session: ChatSession) => void;
   handleDuplicateSession: (session: ChatSession) => Promise<void>;
   handleViewGitHubBranch: (session: ChatSession) => void;
 
@@ -100,5 +100,4 @@ export interface UseChatSidebarReturn {
   // Loading states
   isCreating: boolean;
   isUpdating: boolean;
-  isDeleting: boolean;
 }