Code quality improvements: simplify navigator calls, fix operators, add release logging

Co-authored-by: hoc081098 <[email protected]>

Author: Copilot

app/src/main/java/com/hoc/flowmvi/initializer/TimberInitializer.kt

@@ -3,6 +3,7 @@
 package com.hoc.flowmvi.initializer
 
 import android.content.Context
+import android.util.Log
 import androidx.startup.Initializer
 import com.hoc.flowmvi.BuildConfig
 import timber.log.Timber
@@ -12,10 +13,34 @@ class TimberInitializer : Initializer<Unit> {
     if (BuildConfig.DEBUG) {
       Timber.plant(Timber.DebugTree())
     } else {
-      // TODO(Timber): plant release tree
+      Timber.plant(ReleaseTree())
     }
     Timber.d("TimberInitializer...")
   }
 
   override fun dependencies(): List<Class<out Initializer<*>>> = emptyList()
 }
+
+/**
+ * A Timber tree for release builds that only logs warnings and errors.
+ * This prevents sensitive information from being logged in production.
+ */
+private class ReleaseTree : Timber.Tree() {
+  override fun log(priority: Int, tag: String?, message: String, t: Throwable?) {
+    if (priority == Log.VERBOSE || priority == Log.DEBUG || priority == Log.INFO) {
+      return
+    }
+
+    // Log warnings and errors to system log
+    // In a production app, you might want to send these to a crash reporting service
+    // like Firebase Crashlytics, Sentry, etc.
+    if (priority == Log.ERROR && t != null) {
+      // You could send to crash reporting service here
+      Log.e(tag, message, t)
+    } else if (priority == Log.WARN) {
+      Log.w(tag, message)
+    } else if (priority == Log.ERROR) {
+      Log.e(tag, message)
+    }
+  }
+}

core-ui/src/main/java/com/hoc/flowmvi/core_ui/parcelable.kt

@@ -9,8 +9,7 @@ import android.os.Parcelable
  * https://stackoverflow.com/a/73311814/11191424
  */
 inline fun <reified T : Parcelable> Intent.parcelable(key: String): T? =
-  // TODO: Use `>`, because https://issuetracker.google.com/issues/240585930#comment6
-  if (Build.VERSION.SDK_INT > Build.VERSION_CODES.TIRAMISU) {
+  if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) {
     getParcelableExtra(key, T::class.java)
   } else {
     @Suppress("DEPRECATION")
@@ -21,8 +20,7 @@ inline fun <reified T : Parcelable> Intent.parcelable(key: String): T? =
  * https://stackoverflow.com/a/73311814/11191424
  */
 inline fun <reified T : Parcelable> Bundle.parcelable(key: String): T? =
-  // TODO: Use `>`, because https://issuetracker.google.com/issues/240585930#comment6
-  if (Build.VERSION.SDK_INT > Build.VERSION_CODES.TIRAMISU) {
+  if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) {
     getParcelable(key, T::class.java)
   } else {
     @Suppress("DEPRECATION")

feature-main/src/main/java/com/hoc/flowmvi/ui/main/MainActivity.kt

@@ -43,11 +43,11 @@ class MainActivity : AbstractMviActivity<ViewIntent, ViewState, SingleEvent, Mai
   override fun onOptionsItemSelected(item: MenuItem): Boolean =
     when (item.itemId) {
       R.id.add_action -> {
-        navigator.run { navigateToAdd() }
+        navigator.navigateToAdd()
         true
       }
       R.id.search_action -> {
-        navigator.run { navigateToSearch() }
+        navigator.navigateToSearch()
         true
       }
       else -> super.onOptionsItemSelected(item)
@@ -106,7 +106,7 @@ class MainActivity : AbstractMviActivity<ViewIntent, ViewState, SingleEvent, Mai
     userAdapter.submitList(viewState.userItems)
 
     mainBinding.run {
-      errorGroup.isVisible = viewState.error !== null
+      errorGroup.isVisible = viewState.error != null
       errorMessageTextView.text =
         viewState.error?.let {
           when (it) {

feature-search/src/main/java/com/hoc/flowmvi/ui/search/SearchActivity.kt

@@ -68,7 +68,7 @@ class SearchActivity : AbstractMviActivity<ViewIntent, ViewState, SingleEvent, S
           .setDuration(200),
       )
 
-      errorGroup.isVisible = viewState.error !== null
+      errorGroup.isVisible = viewState.error != null
       if (errorGroup.isVisible) {
         errorMessageTextView.text =
           viewState.error?.let {

feature-search/src/main/java/com/hoc/flowmvi/ui/search/SearchVM.kt

@@ -90,7 +90,7 @@ class SearchVM(
   ): Flow<PartialStateChange> =
     flatMapFirst {
       viewState.value.let { vs ->
-        if (vs.error !== null) {
+        if (vs.error != null) {
           executeSearch(vs.submittedQuery).takeUntil(searchableQueryFlow)
         } else {
           emptyFlow()