Skip to content

Commit e9f0a5e

Browse files
committed
fix(search): wrong UserItem.fullName
1 parent 3f5705c commit e9f0a5e

File tree

2 files changed

+50
-1
lines changed

2 files changed

+50
-1
lines changed

feature-search/src/main/java/com/hoc/flowmvi/ui/search/SearchContract.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ data class UserItem private constructor(
2121
id = domain.id,
2222
email = domain.email.value,
2323
avatar = domain.avatar,
24-
fullName = "${domain.firstName} ${domain.lastName}",
24+
fullName = "${domain.firstName.value} ${domain.lastName.value}",
2525
)
2626
}
2727
}
Lines changed: 49 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
1+
package com.hoc.flowmvi.ui.search
2+
3+
import com.hoc.flowmvi.domain.model.User
4+
import com.hoc.flowmvi.test_utils.valueOrThrow
5+
import kotlin.test.Test
6+
import kotlin.test.assertEquals
7+
8+
class SearchContractTest {
9+
@Test
10+
fun test_userItem_equals() {
11+
assertEquals(
12+
UserItem.from(createUser()),
13+
UserItem.from(createUser())
14+
)
15+
}
16+
17+
@Test
18+
fun test_userItem_hashCode() {
19+
assertEquals(
20+
UserItem.from(createUser()).hashCode(),
21+
UserItem.from(createUser()).hashCode()
22+
)
23+
}
24+
25+
@Test
26+
fun test_userItem_properties() {
27+
val item = UserItem.from(createUser())
28+
assertEquals(ID, item.id)
29+
assertEquals(EMAIL, item.email)
30+
assertEquals(AVATAR, item.avatar)
31+
assertEquals("$FIRST_NAME $LAST_NAME", item.fullName)
32+
}
33+
34+
private companion object {
35+
private const val ID = "0"
36+
private const val EMAIL = "[email protected]"
37+
private const val AVATAR = "avatar.png"
38+
private const val FIRST_NAME = "first"
39+
private const val LAST_NAME = "last"
40+
41+
private fun createUser(): User = User.create(
42+
id = ID,
43+
email = EMAIL,
44+
avatar = AVATAR,
45+
firstName = FIRST_NAME,
46+
lastName = LAST_NAME
47+
).valueOrThrow
48+
}
49+
}

0 commit comments

Comments
 (0)