Properly expose withValuesImpl to remove INSIVIBLE_REFERENCE from compiler plugin

Author: koperagen

core/api/core.api

@@ -5757,6 +5757,10 @@ public final class org/jetbrains/kotlinx/dataframe/impl/aggregation/receivers/Ag
 	public static final fun internal (Lorg/jetbrains/kotlinx/dataframe/aggregation/AggregateDsl;)Lorg/jetbrains/kotlinx/dataframe/impl/aggregation/receivers/AggregateInternalDsl;
 }
 
+public final class org/jetbrains/kotlinx/dataframe/impl/api/ConstructorsKt {
+	public static final fun withValuesImpl (Lkotlin/Pair;)Ljava/util/List;
+}
+
 public final class org/jetbrains/kotlinx/dataframe/impl/api/ConvertKt {
 	public static final fun convertRowColumnImpl (Lorg/jetbrains/kotlinx/dataframe/api/Convert;Lkotlin/reflect/KType;Lorg/jetbrains/kotlinx/dataframe/api/Infer;Lkotlin/jvm/functions/Function2;)Lorg/jetbrains/kotlinx/dataframe/DataFrame;
 	public static final fun withRowCellImpl (Lorg/jetbrains/kotlinx/dataframe/api/Convert;Lkotlin/reflect/KType;Lorg/jetbrains/kotlinx/dataframe/api/Infer;Lkotlin/jvm/functions/Function2;)Lorg/jetbrains/kotlinx/dataframe/DataFrame;

core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/constructors.kt

@@ -393,7 +393,7 @@ public class DataFrameBuilder(private val header: List<String>) {
 
     @JvmName("invoke1")
     internal fun withValues(values: Iterable<Any?>): DataFrame<*> =
-        withValuesImpl(header, values.asList()).map { (name, values) ->
+        (header to values.asList()).withValuesImpl().map { (name, values) ->
             DataColumn.createByInference(name, values)
         }.toDataFrame()
 

core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/api/constructors.kt

@@ -1,10 +1,16 @@
 package org.jetbrains.kotlinx.dataframe.impl.api
 
-internal fun <T> withValuesImpl(header: List<String>, values: List<T>): List<Pair<String, List<T>>> {
+import org.jetbrains.kotlinx.dataframe.exceptions.DataFrameException
+
+/**
+ * Public API to be re-used in compiler plugin implementation
+ */
+public fun <T> Pair<List<String>, List<T>>.withValuesImpl(): List<Pair<String, List<T>>> {
+    val (header, values) = this
     val ncol = header.size
 
-    require(header.isNotEmpty() && values.size.rem(ncol) == 0) {
-        "Number of values ${values.size} is not divisible by number of columns $ncol"
+    if (!(header.isNotEmpty() && values.size.rem(ncol) == 0)) {
+        throw WrongNumberOfValuesException(values.size, ncol)
     }
 
     val nrow = values.size / ncol
@@ -16,3 +22,9 @@ internal fun <T> withValuesImpl(header: List<String>, values: List<T>): List<Pai
         header[col] to colValues
     }
 }
+
+internal class WrongNumberOfValuesException(size: Int, ncol: Int) :
+    IllegalArgumentException(),
+    DataFrameException {
+    override val message = "Number of values $size is not divisible by number of columns $ncol"
+}

plugins/kotlin-dataframe/src/org/jetbrains/kotlinx/dataframe/plugin/impl/api/dataFrameOf.kt

@@ -1,4 +1,3 @@
-@file:Suppress("INVISIBLE_REFERENCE", "INVISIBLE_MEMBER")
 package org.jetbrains.kotlinx.dataframe.plugin.impl.api
 
 import org.jetbrains.kotlin.fir.expressions.FirExpression
@@ -35,7 +34,7 @@ class DataFrameBuilderInvoke0 : AbstractSchemaModificationInterpreter() {
     val Arguments.values: FirVarargArgumentsExpression by arg(lens = Interpreter.Id)
 
     override fun Arguments.interpret(): PluginDataFrameSchema {
-        val columns = withValuesImpl(receiver.header, values.arguments).map { (name, values) ->
+        val columns = (receiver.header to values.arguments).withValuesImpl().map { (name, values) ->
             val type = session.typeContext.commonSuperTypeOrNull(values.map { it.resolvedType }) ?: error("$name $values")
             simpleColumnOf(name, type)
         }