Skip to content

Commit 58e91d3

Browse files
committed
[Compiler plugin] Align Flatten.separator default argument with the library
1 parent c55726c commit 58e91d3

File tree

2 files changed

+4
-2
lines changed
  • plugins/kotlin-dataframe

2 files changed

+4
-2
lines changed

plugins/kotlin-dataframe/src/org/jetbrains/kotlinx/dataframe/plugin/impl/api/flatten.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import org.jetbrains.kotlinx.dataframe.plugin.impl.toPluginDataFrameSchema
1414
class FlattenDefault : AbstractSchemaModificationInterpreter() {
1515
val Arguments.receiver by dataFrame()
1616
val Arguments.keepParentNameForColumns: Boolean by arg(defaultValue = Present(false))
17-
val Arguments.separator: String by arg(defaultValue = Present("."))
17+
val Arguments.separator: String by arg(defaultValue = Present("_"))
1818

1919
override fun Arguments.interpret(): PluginDataFrameSchema {
2020
return receiver.asDataFrame().flatten(keepParentNameForColumns, separator).toPluginDataFrameSchema()
@@ -24,7 +24,7 @@ class FlattenDefault : AbstractSchemaModificationInterpreter() {
2424
class Flatten0 : AbstractSchemaModificationInterpreter() {
2525
val Arguments.receiver by dataFrame()
2626
val Arguments.keepParentNameForColumns: Boolean by arg(defaultValue = Present(false))
27-
val Arguments.separator: String by arg(defaultValue = Present("."))
27+
val Arguments.separator: String by arg(defaultValue = Present("_"))
2828
val Arguments.columns: ColumnsResolver by arg()
2929

3030
override fun Arguments.interpret(): PluginDataFrameSchema {

plugins/kotlin-dataframe/testData/box/flatten.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ fun box(): String {
1414
flattened.compareSchemas(strict = true)
1515
flattened.ungroup { f }.compareSchemas(strict = true)
1616

17+
grouped.flatten(keepParentNameForColumns = true) { f.e }.compareSchemas(strict = true)
18+
1719
grouped.flatten { f.e and f }.compareSchemas(strict = true)
1820
return "OK"
1921
}

0 commit comments

Comments
 (0)