static table text alignment

Jolanrensen · Jolanrensen · commit 5902846947f2 · 2023-12-15T17:58:05.000+01:00
diff --git a/core/generated-sources/src/main/kotlin/org/jetbrains/kotlinx/dataframe/io/html.kt b/core/generated-sources/src/main/kotlin/org/jetbrains/kotlinx/dataframe/io/html.kt
@@ -220,14 +220,14 @@ public fun AnyFrame.toStaticHtml(
     // properly laid out with borders.
     fun StringBuilder.emitHeader() = emitTag("thead") {
         for (row in colGrid) {
-            emitTag("tr", "align=\"left\"") {
+            emitTag("tr") {
                 for ((j, col) in row.withIndex()) {
                     val colBorders = col.borders.toMutableSet()
                     // check if the next cell has a left border, and if so, add a right border to this cell
                     if (row.getOrNull(j + 1)?.borders?.contains(Border.LEFT) == true) {
                         colBorders += Border.RIGHT
                     }
-                    emitTag("th", colBorders.toClass()) {
+                    emitTag("th", "${colBorders.toClass()} style=\"text-align:left\"") {
                         append(col.columnWithPath?.name ?: "")
                     }
                 }
@@ -267,7 +267,7 @@ public fun AnyFrame.toStaticHtml(
         }
 
     // Adds a single row to the html. This row uses the flattened columns to get them displayed non-collapsed.
-    fun StringBuilder.emitRow(row: AnyRow) = emitTag("tr", "align=\"right\"") {
+    fun StringBuilder.emitRow(row: AnyRow) = emitTag("tr") {
         for ((i, col) in flattenedCols.withIndex()) {
             val border = borders[i].toMutableSet()
             // check if the next cell has a left border, and if so, add a right border to this cell
diff --git a/core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/io/html.kt b/core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/io/html.kt
@@ -220,14 +220,14 @@ public fun AnyFrame.toStaticHtml(
     // properly laid out with borders.
     fun StringBuilder.emitHeader() = emitTag("thead") {
         for (row in colGrid) {
-            emitTag("tr", "align=\"left\"") {
+            emitTag("tr") {
                 for ((j, col) in row.withIndex()) {
                     val colBorders = col.borders.toMutableSet()
                     // check if the next cell has a left border, and if so, add a right border to this cell
                     if (row.getOrNull(j + 1)?.borders?.contains(Border.LEFT) == true) {
                         colBorders += Border.RIGHT
                     }
-                    emitTag("th", colBorders.toClass()) {
+                    emitTag("th", "${colBorders.toClass()} style=\"text-align:left\"") {
                         append(col.columnWithPath?.name ?: "")
                     }
                 }
@@ -267,7 +267,7 @@ public fun AnyFrame.toStaticHtml(
         }
 
     // Adds a single row to the html. This row uses the flattened columns to get them displayed non-collapsed.
-    fun StringBuilder.emitRow(row: AnyRow) = emitTag("tr", "align=\"right\"") {
+    fun StringBuilder.emitRow(row: AnyRow) = emitTag("tr") {
         for ((i, col) in flattenedCols.withIndex()) {
             val border = borders[i].toMutableSet()
             // check if the next cell has a left border, and if so, add a right border to this cell
diff --git a/examples/notebooks/netflix/netflix.ipynb b/examples/notebooks/netflix/netflix.ipynb

Original file line number	Diff line number	Diff line change
`@@ -220,14 +220,14 @@ public fun AnyFrame.toStaticHtml(`
`220`	`220`	`// properly laid out with borders.`
`221`	`221`	`fun StringBuilder.emitHeader() = emitTag("thead") {`
`222`	`222`	`for (row in colGrid) {`
`223`		`- emitTag("tr", "align=\"left\"") {`
	`223`	`+ emitTag("tr") {`
`224`	`224`	`for ((j, col) in row.withIndex()) {`
`225`	`225`	`val colBorders = col.borders.toMutableSet()`
`226`	`226`	`// check if the next cell has a left border, and if so, add a right border to this cell`
`227`	`227`	`if (row.getOrNull(j + 1)?.borders?.contains(Border.LEFT) == true) {`
`228`	`228`	`colBorders += Border.RIGHT`
`229`	`229`	`}`
`230`		`- emitTag("th", colBorders.toClass()) {`
	`230`	`+ emitTag("th", "${colBorders.toClass()} style=\"text-align:left\"") {`
`231`	`231`	`append(col.columnWithPath?.name ?: "")`
`232`	`232`	`}`
`233`	`233`	`}`
`@@ -267,7 +267,7 @@ public fun AnyFrame.toStaticHtml(`
`267`	`267`	`}`
`268`	`268`
`269`	`269`	`// Adds a single row to the html. This row uses the flattened columns to get them displayed non-collapsed.`
`270`		`- fun StringBuilder.emitRow(row: AnyRow) = emitTag("tr", "align=\"right\"") {`
	`270`	`+ fun StringBuilder.emitRow(row: AnyRow) = emitTag("tr") {`
`271`	`271`	`for ((i, col) in flattenedCols.withIndex()) {`
`272`	`272`	`val border = borders[i].toMutableSet()`
`273`	`273`	`// check if the next cell has a left border, and if so, add a right border to this cell`