Skip to content

Commit 62d327b

Browse files
authored
Merge pull request #137 from Kotlin/fix-read-excel
Consider skipRows when obtaining column indexes #132
2 parents 24ec80e + c4c86f0 commit 62d327b

File tree

3 files changed

+7
-1
lines changed
  • dataframe-excel/src

3 files changed

+7
-1
lines changed

dataframe-excel/src/main/kotlin/org/jetbrains/kotlinx/dataframe/io/xlsx.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ public fun DataFrame.Companion.readExcel(
158158
}
159159
}
160160
} else {
161-
sheet.getRow(0).map { it.columnIndex }
161+
sheet.getRow(skipRows).map { it.columnIndex }
162162
}
163163

164164
val headerRow = sheet.getRow(skipRows)

dataframe-excel/src/test/kotlin/org/jetbrains/kotlinx/dataframe/io/XlsxTest.kt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,4 +84,10 @@ class XlsxTest {
8484
val df = DataFrame.readExcel(testResource("custom_header_position.xlsx"), skipRows = 1)
8585
df.columnNames() shouldBe listOf("header1", "header2")
8686
}
87+
88+
@Test
89+
fun `consider skipRows when obtaining column indexes`() {
90+
val df = DataFrame.readExcel(testResource("header.xlsx"), skipRows = 6)
91+
df.columnNames() shouldBe listOf("Well", "Well Position", "Omit", "Sample Name", "Target Name", "Task", "Reporter", "Quencher")
92+
}
8793
}
5.09 KB
Binary file not shown.

0 commit comments

Comments
 (0)