Unit test "converting string to double in different locales"

Author: Kopilov

core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/api/convert.kt

@@ -36,6 +36,7 @@ import org.jetbrains.kotlinx.dataframe.type
 import java.math.BigDecimal
 import java.net.URL
 import java.time.LocalTime
+import java.util.*
 import kotlin.math.roundToInt
 import kotlin.math.roundToLong
 import kotlin.reflect.KType
@@ -81,15 +82,15 @@ internal fun AnyCol.convertToTypeImpl(to: KType): AnyCol {
     return when {
         from == to -> this
         from.isSubtypeOf(to) -> (this as DataColumnInternal<*>).changeType(to.withNullability(hasNulls()))
-        else -> when (val converter = getConverter(from, to)) {
+        else -> when (val converter = getConverter(from, to, ParserOptions(locale = Locale.getDefault()))) {
             null -> when (from.classifier) {
                 Any::class, Number::class, java.io.Serializable::class -> {
                     // find converter for every value
                     val values = values.map {
                         it?.let {
                             val clazz = it.javaClass.kotlin
                             val type = clazz.createStarProjectedType(false)
-                            val converter = getConverter(type, to) ?: throw TypeConverterNotFoundException(from, to)
+                            val converter = getConverter(type, to, ParserOptions(locale = Locale.getDefault())) ?: throw TypeConverterNotFoundException(from, to)
                             converter(it)
                         }.checkNulls()
                     }
@@ -107,9 +108,9 @@ internal fun AnyCol.convertToTypeImpl(to: KType): AnyCol {
     }
 }
 
-internal val convertersCache = mutableMapOf<Pair<KType, KType>, TypeConverter?>()
+internal val convertersCache = mutableMapOf<Triple<KType, KType, ParserOptions?>, TypeConverter?>()
 
-internal fun getConverter(from: KType, to: KType): TypeConverter? = convertersCache.getOrPut(from to to) { createConverter(from, to) }
+internal fun getConverter(from: KType, to: KType, options: ParserOptions? = null): TypeConverter? = convertersCache.getOrPut(Triple(from, to, options)) { createConverter(from, to, options) }
 
 internal typealias TypeConverter = (Any) -> Any?
 

core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/io/ParserTests.kt

@@ -2,12 +2,14 @@ package org.jetbrains.kotlinx.dataframe.io
 
 import io.kotest.matchers.shouldBe
 import kotlinx.datetime.LocalDateTime
+import org.jetbrains.kotlinx.dataframe.DataColumn
 import org.jetbrains.kotlinx.dataframe.DataFrame
 import org.jetbrains.kotlinx.dataframe.api.*
 import org.jetbrains.kotlinx.dataframe.api.columnOf
 import org.jetbrains.kotlinx.dataframe.exceptions.TypeConversionException
 import org.junit.Test
 import java.math.BigDecimal
+import java.util.*
 import kotlin.reflect.typeOf
 
 class ParserTests {
@@ -58,4 +60,23 @@ class ParserTests {
         converted[0] shouldBe 1.0f
         converted[1] shouldBe 0.321f
     }
+
+    @Test
+    fun `converting string to double in different locales`() {
+        val currentLocale = Locale.getDefault()
+        try {
+            val stringValues = listOf("1", "2.3", "4,5")
+            val stringColumn = DataColumn.createValueColumn("nums", stringValues, typeOf<String>())
+            Locale.setDefault(Locale.forLanguageTag("ru-RU"))
+            stringColumn.convertToDouble().shouldBe(
+                DataColumn.createValueColumn("nums", listOf(1.0, 2.3, 4.5), typeOf<Double>())
+            )
+            Locale.setDefault(Locale.forLanguageTag("en-US"))
+            stringColumn.convertToDouble().shouldBe(
+                DataColumn.createValueColumn("nums", listOf(1.0, 2.3, 45.0), typeOf<Double>())
+            )
+        } finally {
+            Locale.setDefault(currentLocale)
+        }
+    }
 }