Fix build: parametrized tests for JUnit5

Author: ileasile

dataframe-json/build.gradle.kts

@@ -26,8 +26,10 @@ dependencies {
     implementation(libs.serialization.json)
     implementation(libs.sl4j)
 
-    testImplementation(kotlin("test"))
-    testImplementation(libs.junit)
+    testImplementation(libs.kotlin.test)
+    testImplementation(libs.junit.jupiter)
+    testImplementation(libs.junit.jupiter.engine)
+    testImplementation(libs.junit.jupiter.params)
     testImplementation(libs.kotestAssertions) {
         exclude("org.jetbrains.kotlin", "kotlin-stdlib-jdk8")
     }

dataframe-json/src/test/kotlin/org/jetbrains/kotlinx/dataframe/io/ImageSerializationTests.kt

@@ -13,8 +13,8 @@ import org.jetbrains.kotlinx.dataframe.impl.io.resizeKeepingAspectRatio
 import org.jetbrains.kotlinx.dataframe.io.Base64ImageEncodingOptions.Companion.ALL_OFF
 import org.jetbrains.kotlinx.dataframe.io.Base64ImageEncodingOptions.Companion.GZIP_ON
 import org.jetbrains.kotlinx.dataframe.io.Base64ImageEncodingOptions.Companion.LIMIT_SIZE_ON
-import org.junit.runner.RunWith
-import org.junit.runners.Parameterized
+import org.junit.jupiter.params.ParameterizedTest
+import org.junit.jupiter.params.provider.MethodSource
 import java.awt.image.BufferedImage
 import java.io.ByteArrayInputStream
 import java.io.ByteArrayOutputStream
@@ -23,12 +23,11 @@ import java.util.Base64
 import java.util.zip.GZIPInputStream
 import javax.imageio.ImageIO
 import kotlin.math.abs
-import kotlin.test.Test
 
-@RunWith(Parameterized::class)
-class ImageSerializationTests(private val encodingOptions: Base64ImageEncodingOptions?) {
-    @Test
-    fun `serialize images as base64`() {
+class ImageSerializationTests {
+    @ParameterizedTest
+    @MethodSource("imageEncodingOptionsToTest")
+    fun `serialize images as base64`(encodingOptions: Base64ImageEncodingOptions?) {
         val images = readImagesFromResources()
         val json = encodeImagesAsJson(images, encodingOptions)
 
@@ -166,8 +165,7 @@ class ImageSerializationTests(private val encodingOptions: Base64ImageEncodingOp
         private val DISABLED = null
 
         @JvmStatic
-        @Parameterized.Parameters
-        fun imageEncodingOptionsToTest(): Collection<Base64ImageEncodingOptions?> =
+        fun imageEncodingOptionsToTest(): List<Base64ImageEncodingOptions?> =
             listOf(
                 DEFAULT,
                 GZIP_ON_RESIZE_OFF,

gradle/libs.versions.toml

@@ -95,6 +95,7 @@ junit = { group = "junit", name = "junit", version.ref = "junit" }
 junit-bom = { group = "org.junit", name = "junit-bom", version.ref = "junit-jupiter" }
 junit-jupiter = { group = "org.junit.jupiter", name = "junit-jupiter", version.ref = "junit-jupiter" }
 junit-jupiter-engine = { group = "org.junit.jupiter", name = "junit-jupiter-engine", version.ref = "junit-jupiter" }
+junit-jupiter-params = { group = "org.junit.jupiter", name = "junit-jupiter-params", version.ref = "junit-jupiter" }
 junit-platform-commons = { group = "org.junit.platform", name = "junit-platform-commons", version.ref = "junit-platform" }
 junit-platform-launcher = { group = "org.junit.platform", name = "junit-platform-launcher", version.ref = "junit-platform" }
 junit-platform-runner = { group = "org.junit.platform", name = "junit-platform-runner", version.ref = "junit-platform" }