Skip to content

Commit 7232b07

Browse files
authored
Merge pull request #514 from Kotlin/get-subset-fix
use range indexing to get rows subset
2 parents b9dd7a3 + 3ddf7c9 commit 7232b07

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

core/generated-sources/src/main/kotlin/org/jetbrains/kotlinx/dataframe/jupyter/KotlinNotebookPluginUtils.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ import org.jetbrains.kotlinx.dataframe.api.SplitWithTransform
2424
import org.jetbrains.kotlinx.dataframe.api.Update
2525
import org.jetbrains.kotlinx.dataframe.api.at
2626
import org.jetbrains.kotlinx.dataframe.api.dataFrameOf
27-
import org.jetbrains.kotlinx.dataframe.api.filter
2827
import org.jetbrains.kotlinx.dataframe.api.frames
2928
import org.jetbrains.kotlinx.dataframe.api.into
3029
import org.jetbrains.kotlinx.dataframe.api.sortBy
@@ -60,7 +59,7 @@ public object KotlinNotebookPluginUtils {
6059
* It's used for example for dynamic pagination in Kotlin Notebook Plugin.
6160
*/
6261
public fun getRowsSubsetForRendering(df: AnyFrame, startIdx: Int, endIdx: Int): DisableRowsLimitWrapper =
63-
DisableRowsLimitWrapper(df.filter { it.index() in startIdx until endIdx })
62+
DisableRowsLimitWrapper(df[startIdx ..< endIdx])
6463

6564
/**
6665
* Sorts a dataframe-like object by multiple columns.

core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/jupyter/KotlinNotebookPluginUtils.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ import org.jetbrains.kotlinx.dataframe.api.SplitWithTransform
2424
import org.jetbrains.kotlinx.dataframe.api.Update
2525
import org.jetbrains.kotlinx.dataframe.api.at
2626
import org.jetbrains.kotlinx.dataframe.api.dataFrameOf
27-
import org.jetbrains.kotlinx.dataframe.api.filter
2827
import org.jetbrains.kotlinx.dataframe.api.frames
2928
import org.jetbrains.kotlinx.dataframe.api.into
3029
import org.jetbrains.kotlinx.dataframe.api.sortBy
@@ -60,7 +59,7 @@ public object KotlinNotebookPluginUtils {
6059
* It's used for example for dynamic pagination in Kotlin Notebook Plugin.
6160
*/
6261
public fun getRowsSubsetForRendering(df: AnyFrame, startIdx: Int, endIdx: Int): DisableRowsLimitWrapper =
63-
DisableRowsLimitWrapper(df.filter { it.index() in startIdx until endIdx })
62+
DisableRowsLimitWrapper(df[startIdx ..< endIdx])
6463

6564
/**
6665
* Sorts a dataframe-like object by multiple columns.

0 commit comments

Comments
 (0)