Skip to content

Commit a728428

Browse files
Automated commit of generated code
1 parent 9d7057c commit a728428

File tree

3 files changed

+15
-21
lines changed

3 files changed

+15
-21
lines changed

core/generated-sources/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/all.kt

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ import org.jetbrains.kotlinx.dataframe.columns.ColumnSet
1717
import org.jetbrains.kotlinx.dataframe.columns.ColumnWithPath
1818
import org.jetbrains.kotlinx.dataframe.columns.ColumnsResolver
1919
import org.jetbrains.kotlinx.dataframe.columns.SingleColumn
20-
import org.jetbrains.kotlinx.dataframe.columns.isSingleColumnWithGroup
2120
import org.jetbrains.kotlinx.dataframe.columns.size
2221
import org.jetbrains.kotlinx.dataframe.columns.values
2322
import org.jetbrains.kotlinx.dataframe.impl.columns.TransformableColumnSet
@@ -8052,22 +8051,24 @@ public interface AllColumnsSelectionDsl<out _UNUSED> {
80528051
}
80538052

80548053
/**
8055-
* If [this] is a [SingleColumn] containing a single [ColumnGroup], it
8054+
* If [this] is a [SingleColumn] containing a single [ColumnGroup]
8055+
* (like [SingleColumn][SingleColumn]`<`[AnyRow][AnyRow]`>` or [ColumnsSelectionDsl][ColumnsSelectionDsl]), it
80568056
* returns a [(transformable) ColumnSet][TransformableColumnSet] containing the children of this [ColumnGroup],
8057-
* else it simply returns a [(transformable) ColumnSet][TransformableColumnSet] from [this].
8057+
* else it simply returns a [(transformable) ColumnSet][TransformableColumnSet] from [this]
8058+
* (like when [this] is a [ColumnSet]).
80588059
*/
80598060
internal fun ColumnsResolver<*>.allColumnsInternal(removePaths: Boolean = false): TransformableColumnSet<*> =
8060-
transform {
8061-
if (isSingleColumnWithGroup(it)) {
8062-
it.single().let {
8061+
transform { cols ->
8062+
if (this is SingleColumn<*> && cols.singleOrNull()?.isColumnGroup() == true) {
8063+
cols.single().let {
80638064
if (removePaths) {
80648065
it.asColumnGroup().columns().map(AnyCol::addPath)
80658066
} else {
80668067
it.cols()
80678068
}
80688069
}
80698070
} else {
8070-
it
8071+
cols
80718072
}
80728073
}
80738074

core/generated-sources/src/main/kotlin/org/jetbrains/kotlinx/dataframe/columns/SingleColumn.kt

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package org.jetbrains.kotlinx.dataframe.columns
22

33
import org.jetbrains.kotlinx.dataframe.DataColumn
4-
import org.jetbrains.kotlinx.dataframe.api.isColumnGroup
54
import org.jetbrains.kotlinx.dataframe.impl.columns.TransformableColumnSet
65
import org.jetbrains.kotlinx.dataframe.impl.columns.TransformableSingleColumn
76

@@ -23,11 +22,3 @@ public interface SingleColumn<out C> : ColumnsResolver<C> {
2322

2423
public fun resolveSingle(context: ColumnResolutionContext): ColumnWithPath<C>?
2524
}
26-
27-
public fun ColumnsResolver<*>.isSingleColumn(): Boolean = this is SingleColumn<*>
28-
29-
/**
30-
* Returns true if [this] is a [SingleColumn] and [cols] consists of a single column group.
31-
*/
32-
public fun ColumnsResolver<*>.isSingleColumnWithGroup(cols: List<ColumnWithPath<*>>): Boolean =
33-
isSingleColumn() && cols.singleOrNull()?.isColumnGroup() == true

core/generated-sources/src/test/kotlin/org/jetbrains/kotlinx/dataframe/api/colsAtAnyDepth.kt

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,14 @@ import org.jetbrains.kotlinx.dataframe.impl.columns.transform
1313
import org.jetbrains.kotlinx.dataframe.impl.columns.tree.flattenRecursively
1414
import org.jetbrains.kotlinx.dataframe.kind
1515
import org.jetbrains.kotlinx.dataframe.samples.api.TestBase
16+
import org.jetbrains.kotlinx.dataframe.samples.api.age
1617
import org.jetbrains.kotlinx.dataframe.samples.api.city
1718
import org.jetbrains.kotlinx.dataframe.samples.api.firstName
1819
import org.jetbrains.kotlinx.dataframe.samples.api.lastName
1920
import org.jetbrains.kotlinx.dataframe.samples.api.name
21+
import org.jetbrains.kotlinx.dataframe.samples.api.secondName
22+
import org.jetbrains.kotlinx.dataframe.samples.api.thirdName
23+
import org.jetbrains.kotlinx.dataframe.samples.api.weight
2024
import org.junit.Test
2125
import kotlin.reflect.typeOf
2226

@@ -153,17 +157,15 @@ class AtAnyDepth : TestBase() {
153157
dfWithFrames.getColumnsWithPaths { name[frameCol] and frameCol }
154158
}
155159

156-
// @Test
160+
@Test
157161
fun `cols of kind atAnyDepth`() {
158162
listOf(
159163
dfGroup.getColumnsWithPaths {
160164
colsAtAnyDepth().colsOfKind(Frame, Value) { "e" in it.name }
161165
},
162166
dfGroup.getColumnsWithPaths {
163-
asSingleColumn().ensureIsColumnGroup().asColumnSet().dfsInternal { "e" in it.name }
167+
name { firstName.allCols() and lastName } and cols(age, weight)
164168
},
165-
).map {
166-
it.sortedBy { it.name }.map { it.name to it.path }
167-
}.shouldAllBeEqual()
169+
).map { it.map { it.path.joinToString() } }.shouldAllBeEqual()
168170
}
169171
}

0 commit comments

Comments
 (0)