Skip to content

Commit c09c774

Browse files
committed
Swap default for generateDataClasses extensionProperties
Function is intended to be used together with either KSP or compiler plugin, so generated extension properties won't be needed
1 parent e2e336c commit c09c774

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/generateCode.kt

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ package org.jetbrains.kotlinx.dataframe.api
33
import org.jetbrains.dataframe.impl.codeGen.CodeGenerator
44
import org.jetbrains.kotlinx.dataframe.DataFrame
55
import org.jetbrains.kotlinx.dataframe.codeGen.MarkerVisibility
6+
import org.jetbrains.kotlinx.dataframe.codeGen.NameNormalizer
7+
import org.jetbrains.kotlinx.dataframe.impl.codeGen.from
68

79
public inline fun <reified T> DataFrame<T>.generateCode(
810
fields: Boolean = true,
@@ -36,7 +38,7 @@ public inline fun <reified T> DataFrame<T>.generateInterfaces(): CodeString = ge
3638

3739
public inline fun <reified T> DataFrame<T>.generateDataClasses(
3840
markerName: String? = null,
39-
extensionProperties: Boolean = true,
41+
extensionProperties: Boolean = false,
4042
visibility: MarkerVisibility = MarkerVisibility.IMPLICIT_PUBLIC,
4143
useFqNames: Boolean = false
4244
): CodeString {
@@ -49,8 +51,8 @@ public inline fun <reified T> DataFrame<T>.generateDataClasses(
4951
extensionProperties = extensionProperties,
5052
isOpen = false,
5153
visibility = visibility,
52-
asDataClass = true
53-
).code.declarations
54+
asDataClass = true,
55+
fieldNameNormalizer = nameNormalizer
5456
).code.declarations.toCodeString()
5557
}
5658

core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/codeGen/CodeGenerationTests.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ class CodeGenerationTests : BaseTest() {
311311

312312
@Test
313313
fun `check method generateDataClasses`() {
314-
val code = typed.groupBy { name }.toDataFrame().generateDataClasses(extensionProperties = false)
314+
val code = typed.groupBy { name }.toDataFrame().generateDataClasses()
315315

316316
code shouldBe """
317317
@DataSchema

0 commit comments

Comments
 (0)