[Compiler plugin] Remove redundant arguments that are equal to default value

Author: koperagen

plugins/kotlin-dataframe/src/org/jetbrains/kotlinx/dataframe/plugin/impl/ExpectedArgumentDelegates.kt

@@ -21,7 +21,6 @@ fun <T> AbstractInterpreter<T>.dataFrame(
 fun <T> AbstractInterpreter<T>.varargString(
     name: ArgumentName? = null,
     defaultValue: DefaultValue<List<String>> = Absent
-): ExpectedArgumentProvider<List<String>> = arg(name, lens = Interpreter.Value, defaultValue = defaultValue)
 
 fun <T> AbstractInterpreter<T>.renameClause(
     name: ArgumentName? = null
@@ -38,40 +37,40 @@ fun <T> AbstractInterpreter<T>.type(
 fun <T, E : Enum<E>> AbstractInterpreter<T>.enum(
     name: ArgumentName? = null,
     defaultValue: DefaultValue<E> = Absent
-): ExpectedArgumentProvider<E> = argConvert(name = name, lens = Interpreter.Value, defaultValue = defaultValue) { it: DataFrameCallableId ->
+): ExpectedArgumentProvider<E> = argConvert(name = name, defaultValue = defaultValue) { it: DataFrameCallableId ->
     val forName: Class<*> = Class.forName("${it.packageName}.${it.className}")
     @Suppress("UNCHECKED_CAST")
     java.lang.Enum.valueOf(forName as Class<out Enum<*>>, it.callableName) as E
 }
 
 fun <T> AbstractInterpreter<T>.columnAccessor(
     name: ArgumentName? = null
-): ExpectedArgumentProvider<ColumnAccessorApproximation> = arg(name, lens = Interpreter.Value)
+): ExpectedArgumentProvider<ColumnAccessorApproximation> = arg(name)
 
 fun <T> AbstractInterpreter<T>.dataColumn(
     name: ArgumentName? = null
-): ExpectedArgumentProvider<SimpleCol> = arg(name, lens = Interpreter.Value)
+): ExpectedArgumentProvider<SimpleCol> = arg(name)
 
 fun <T> AbstractInterpreter<T>.insertClause(
     name: ArgumentName? = null
-): ExpectedArgumentProvider<InsertClauseApproximation> = arg(name, lens = Interpreter.Value)
+): ExpectedArgumentProvider<InsertClauseApproximation> = arg(name)
 
 internal fun <T> AbstractInterpreter<T>.columnPath(
     name: ArgumentName? = null
-): ExpectedArgumentProvider<ColumnPathApproximation> = arg(name, lens = Interpreter.Value)
 
 internal fun <T> AbstractInterpreter<T>.columnWithPath(
     name: ArgumentName? = null
 ): ExpectedArgumentProvider<ColumnWithPathApproximation> = arg(name, lens = Interpreter.Value)
+): ExpectedArgumentProvider<ColumnPathApproximation> = arg(name)
 
 fun <T> AbstractInterpreter<T>.kproperty(
     name: ArgumentName? = null
-): ExpectedArgumentProvider<KPropertyApproximation> = arg(name, lens = Interpreter.Value)
+): ExpectedArgumentProvider<KPropertyApproximation> = arg(name)
 
 internal fun <T> AbstractInterpreter<T>.string(
     name: ArgumentName? = null
 ): ExpectedArgumentProvider<String> =
-    arg(name, lens = Interpreter.Value)
+    arg(name)
 
 internal fun <T> AbstractInterpreter<T>.dsl(
     name: ArgumentName? = null

plugins/kotlin-dataframe/src/org/jetbrains/kotlinx/dataframe/plugin/impl/api/add.kt

@@ -4,7 +4,6 @@ import org.jetbrains.kotlinx.dataframe.plugin.extensions.Marker
 import org.jetbrains.kotlinx.dataframe.plugin.impl.AbstractInterpreter
 import org.jetbrains.kotlinx.dataframe.plugin.impl.AbstractSchemaModificationInterpreter
 import org.jetbrains.kotlinx.dataframe.plugin.impl.Arguments
-import org.jetbrains.kotlinx.dataframe.plugin.impl.Interpreter
 import org.jetbrains.kotlinx.dataframe.plugin.impl.PluginDataFrameSchema
 import org.jetbrains.kotlinx.dataframe.plugin.impl.SimpleCol
 import org.jetbrains.kotlinx.dataframe.plugin.impl.SimpleColumnGroup
@@ -27,7 +26,7 @@ class Add : AbstractSchemaModificationInterpreter() {
 }
 
 class From : AbstractInterpreter<Unit>() {
-    val Arguments.dsl: AddDslApproximation by arg(lens = Interpreter.Value)
+    val Arguments.dsl: AddDslApproximation by arg()
     val Arguments.receiver: String by string()
     val Arguments.type: TypeApproximation by type(name("expression"))
 
@@ -37,7 +36,7 @@ class From : AbstractInterpreter<Unit>() {
 }
 
 class Into : AbstractInterpreter<Unit>() {
-    val Arguments.dsl: AddDslApproximation by arg(lens = Interpreter.Value)
+    val Arguments.dsl: AddDslApproximation by arg()
     val Arguments.receiver: TypeApproximation by type()
     val Arguments.name: String by string()
 
@@ -60,7 +59,7 @@ class AddWithDsl : AbstractSchemaModificationInterpreter() {
 }
 
 class AddDslStringInvoke : AbstractInterpreter<Unit>() {
-    val Arguments.dsl: AddDslApproximation by arg(lens = Interpreter.Value)
+    val Arguments.dsl: AddDslApproximation by arg()
     val Arguments.receiver: String by string()
     val Arguments.body by dsl()
 

plugins/kotlin-dataframe/src/org/jetbrains/kotlinx/dataframe/plugin/impl/api/stdlib.kt

@@ -22,16 +22,16 @@ class PairConstructor : AbstractInterpreter<Pair<*, *>>() {
 }
 
 class TrimMargin : AbstractInterpreter<String>() {
-    val Arguments.receiver: String by arg(lens = Interpreter.Value)
-    val Arguments.marginPrefix: String by arg(lens = Interpreter.Value, defaultValue = Present("|"))
+    val Arguments.receiver: String by arg()
+    val Arguments.marginPrefix: String by arg(defaultValue = Present("|"))
 
     override fun Arguments.interpret(): String {
         return receiver.trimMargin(marginPrefix)
     }
 }
 
 class TrimIndent : AbstractInterpreter<String>() {
-    val Arguments.receiver: String by arg(lens = Interpreter.Value)
+    val Arguments.receiver: String by arg()
 
     override fun Arguments.interpret(): String {
         return receiver.trimIndent()