Skip to content

Commit d21934b

Browse files
committed
removed allRecursively and boolean arguments for recursively
1 parent b085905 commit d21934b

File tree

43 files changed

+147
-655
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+147
-655
lines changed

core/generated-sources/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/ColumnsSelectionDsl.kt

Lines changed: 15 additions & 280 deletions
Large diffs are not rendered by default.

core/generated-sources/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/cumSum.kt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ public fun <T> DataFrame<T>.cumSum(vararg columns: KProperty<*>, skipNA: Boolean
5353
cumSum(skipNA) { columns.toColumnSet() }
5454

5555
public fun <T> DataFrame<T>.cumSum(skipNA: Boolean = defaultCumSumSkipNA): DataFrame<T> = cumSum(skipNA) {
56-
allRecursively(includeGroups = false)
56+
cols { !it.isColumnGroup() }.recursively()
5757
}
5858

5959
// endregion
@@ -79,7 +79,8 @@ public fun <T, G> GroupBy<T, G>.cumSum(
7979
skipNA: Boolean = defaultCumSumSkipNA,
8080
): GroupBy<T, G> = cumSum(skipNA) { columns.toColumnSet() }
8181

82-
public fun <T, G> GroupBy<T, G>.cumSum(skipNA: Boolean = defaultCumSumSkipNA): GroupBy<T, G> =
83-
cumSum(skipNA) { allRecursively(includeGroups = false) }
82+
public fun <T, G> GroupBy<T, G>.cumSum(skipNA: Boolean = defaultCumSumSkipNA): GroupBy<T, G> = cumSum(skipNA) {
83+
cols { !it.isColumnGroup() }.recursively()
84+
}
8485

8586
// endregion

core/generated-sources/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/describe.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public fun <T> DataColumn<T>.describe(): DataFrame<ColumnDescription> = describe
3939

4040
// region DataFrame
4141

42-
public fun <T> DataFrame<T>.describe(): DataFrame<ColumnDescription> = describe { allRecursively(includeGroups = false) }
42+
public fun <T> DataFrame<T>.describe(): DataFrame<ColumnDescription> = describe { cols { !it.isColumnGroup() }.recursively() }
4343

4444
public fun <T> DataFrame<T>.describe(columns: ColumnsSelector<T, *>): DataFrame<ColumnDescription> =
4545
describeImpl(getColumnsWithPaths(columns))

core/generated-sources/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/inferType.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ public fun AnyCol.inferType(): DataColumn<*> = guessColumnType(name, toList(), t
1414

1515
// region DataFrame
1616

17-
public fun <T> DataFrame<T>.inferType(): DataFrame<T> = inferType { allRecursively(includeGroups = false) }
17+
public fun <T> DataFrame<T>.inferType(): DataFrame<T> = inferType { cols { !it.isColumnGroup() }.recursively() }
1818

1919
public fun <T> DataFrame<T>.inferType(columns: ColumnsSelector<T, *>): DataFrame<T> =
2020
replace(columns).with { it.inferType() }

core/generated-sources/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/parse.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ public data class ParserOptions(
5656
public fun DataColumn<String?>.tryParse(options: ParserOptions? = null): DataColumn<*> = tryParseImpl(options)
5757

5858
public fun <T> DataFrame<T>.parse(options: ParserOptions? = null): DataFrame<T> = parse(options) {
59-
allRecursively(includeGroups = false)
59+
cols { !it.isColumnGroup() }.recursively()
6060
}
6161

6262
public fun DataColumn<String?>.parse(options: ParserOptions? = null): DataColumn<*> =

core/generated-sources/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/reorder.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public fun <T, V : Comparable<V>> DataFrame<T>.reorderColumnsBy(
4545
): DataFrame<T> =
4646
Reorder(
4747
df = this,
48-
columns = { if (recursively) allRecursively() else all() },
48+
columns = { if (recursively) all().recursively() else all() },
4949
inFrameColumns = recursively,
5050
).reorderImpl(desc, expression)
5151

core/generated-sources/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/replace.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public fun <T, C> DataFrame<T>.replace(columns: Iterable<ColumnReference<C>>): R
3838

3939
public fun <T> DataFrame<T>.replaceAll(
4040
vararg valuePairs: Pair<Any?, Any?>,
41-
columns: ColumnsSelector<T, *> = { allRecursively(includeGroups = false) },
41+
columns: ColumnsSelector<T, *> = { cols { !it.isColumnGroup() }.recursively() },
4242
): DataFrame<T> {
4343
val map = valuePairs.toMap()
4444
return update(columns).with { map[it] ?: it }

core/generated-sources/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/xs.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import org.jetbrains.kotlinx.dataframe.impl.api.xsImpl
77
// region DataFrame
88

99
public fun <T> DataFrame<T>.xs(vararg keyValues: Any?): DataFrame<T> = xs(*keyValues) {
10-
allRecursively(includeGroups = false).take(keyValues.size)
10+
cols { !it.isColumnGroup() }.recursively().take(keyValues.size)
1111
}
1212

1313
public fun <T, C> DataFrame<T>.xs(vararg keyValues: C, keyColumns: ColumnsSelector<T, C>): DataFrame<T> =
@@ -18,7 +18,7 @@ public fun <T, C> DataFrame<T>.xs(vararg keyValues: C, keyColumns: ColumnsSelect
1818
// region GroupBy
1919

2020
public fun <T, G> GroupBy<T, G>.xs(vararg keyValues: Any?): GroupBy<T, G> = xs(*keyValues) {
21-
allRecursively(includeGroups = false).take(keyValues.size)
21+
cols { !it.isColumnGroup() }.recursively().take(keyValues.size)
2222
}
2323

2424
public fun <T, G, C> GroupBy<T, G>.xs(vararg keyValues: C, keyColumns: ColumnsSelector<T, C>): GroupBy<T, G> =

core/generated-sources/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/GroupByImpl.kt

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -6,18 +6,7 @@ import org.jetbrains.kotlinx.dataframe.DataFrame
66
import org.jetbrains.kotlinx.dataframe.Selector
77
import org.jetbrains.kotlinx.dataframe.aggregation.AggregateGroupedBody
88
import org.jetbrains.kotlinx.dataframe.aggregation.NamedValue
9-
import org.jetbrains.kotlinx.dataframe.api.GroupBy
10-
import org.jetbrains.kotlinx.dataframe.api.GroupedRowFilter
11-
import org.jetbrains.kotlinx.dataframe.api.asGroupBy
12-
import org.jetbrains.kotlinx.dataframe.api.cast
13-
import org.jetbrains.kotlinx.dataframe.api.concat
14-
import org.jetbrains.kotlinx.dataframe.api.convert
15-
import org.jetbrains.kotlinx.dataframe.api.getColumn
16-
import org.jetbrains.kotlinx.dataframe.api.getColumnsWithPaths
17-
import org.jetbrains.kotlinx.dataframe.api.into
18-
import org.jetbrains.kotlinx.dataframe.api.minus
19-
import org.jetbrains.kotlinx.dataframe.api.pathOf
20-
import org.jetbrains.kotlinx.dataframe.api.rename
9+
import org.jetbrains.kotlinx.dataframe.api.*
2110
import org.jetbrains.kotlinx.dataframe.columns.FrameColumn
2211
import org.jetbrains.kotlinx.dataframe.impl.aggregation.AggregatableInternal
2312
import org.jetbrains.kotlinx.dataframe.impl.aggregation.GroupByReceiverImpl
@@ -95,7 +84,7 @@ internal fun <T, G, R> aggregateGroupBy(
9584

9685
if (!removeColumns) removedNode.data.wasRemoved = false
9786

98-
val columnsToInsert = groupedFrame.getColumnsWithPaths { allRecursively(includeGroups = false) }.map {
87+
val columnsToInsert = groupedFrame.getColumnsWithPaths { cols { !it.isColumnGroup() }.rec() }.map {
9988
ColumnToInsert(insertPath + it.path, it, removedNode)
10089
}
10190
val src = if (removeColumns) removed.df else df

core/generated-sources/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/api/flatten.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ internal fun <T, C> DataFrame<T>.flattenImpl(
2727
fun getRootPrefix(path: ColumnPath) =
2828
(1 until path.size).asSequence().map { path.take(it) }.first { rootPrefixes.contains(it) }
2929

30-
val result = move { rootPrefixes.toColumnSet().allRecursively(includeGroups = false, includeTopLevel = false) }
30+
val result = move { rootPrefixes.toColumnSet().cols { !it.isColumnGroup() }.recursively() }
3131
.into {
3232
val targetPath = getRootPrefix(it.path).dropLast(1)
3333
val nameGen = nameGenerators[targetPath]!!

0 commit comments

Comments
 (0)