Merge pull request #209 from Kotlin/minKernelVersion

Min kernel version fix

Author: Jolanrensen

core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/jupyter/Integration.kt

@@ -55,12 +55,24 @@ import kotlin.reflect.KClass
 import kotlin.reflect.KProperty
 import kotlin.reflect.full.isSubtypeOf
 
+/** Users will get an error if their Kotlin Jupyter kernel is older than this version. */
+private const val MIN_KERNEL_VERSION = "0.11.0.198"
+
 internal val newDataSchemas = mutableListOf<KClass<*>>()
 
-internal class Integration(private val notebook: Notebook, private val options: MutableMap<String, String?>) :
-    JupyterIntegration() {
+internal class Integration(
+    private val notebook: Notebook,
+    private val options: MutableMap<String, String?>,
+) : JupyterIntegration() {
 
     override fun Builder.onLoaded() {
+        try {
+            setMinimalKernelVersion(MIN_KERNEL_VERSION)
+        } catch (_: NoSuchMethodError) { // will be thrown on version < 0.11.0.198
+            throw IllegalStateException(
+                getKernelUpdateMessage(notebook.kernelVersion, MIN_KERNEL_VERSION, notebook.jupyterClientType)
+            )
+        }
         val codeGen = ReplCodeGenerator.create()
         val config = JupyterConfiguration()
 

core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/jupyter/kernelUpdateMessages.kt

@@ -0,0 +1,26 @@
+package org.jetbrains.kotlinx.dataframe.jupyter
+
+import org.jetbrains.kotlinx.jupyter.api.JupyterClientType
+import org.jetbrains.kotlinx.jupyter.api.JupyterClientType.DATALORE
+import org.jetbrains.kotlinx.jupyter.api.JupyterClientType.KOTLIN_NOTEBOOK
+import org.jetbrains.kotlinx.jupyter.api.KotlinKernelVersion
+
+private const val UPDATING_DATALORE_URL = "https://github.com/Kotlin/kotlin-jupyter/tree/master#datalore"
+private const val UPDATING_KOTLIN_NOTEBOOK_URL = "https://github.com/Kotlin/kotlin-jupyter#kotlin-notebook"
+private const val UPDATING = "https://github.com/Kotlin/kotlin-jupyter/tree/master#updating"
+
+internal fun getKernelUpdateMessage(
+    kernelVersion: KotlinKernelVersion,
+    minKernelVersion: String,
+    clientType: JupyterClientType,
+): String = buildString {
+    append("Your Kotlin Jupyter kernel version appears to be out of date (version $kernelVersion). ")
+    appendLine("Please update it to version $minKernelVersion or newer to be able to use DataFrame.")
+    append("Follow the instructions at: ")
+
+    when (clientType) {
+        DATALORE -> appendLine(UPDATING_DATALORE_URL)
+        KOTLIN_NOTEBOOK -> appendLine(UPDATING_KOTLIN_NOTEBOOK_URL)
+        else -> appendLine(UPDATING)
+    }
+}

gradle/libs.versions.toml

@@ -1,9 +1,9 @@
 [versions]
-ksp = "1.7.20-1.0.8"
-kotlinJupyter = "0.11.0-187"
+ksp = "1.8.0-RC-1.0.8"
+kotlinJupyter = "0.11.0-198"
 ktlint = "3.4.5"
-kotlin = "1.7.20"
-dokka = "1.6.20"
+kotlin = "1.8.0-RC"
+dokka = "1.7.20"
 libsPublisher = "0.0.60-dev-30"
 # "Bootstrap" version of the dataframe, used in the build itself to generate @DataSchema APIs,
 # dogfood Gradle / KSP plugins in tests and idea-examples modules

plugins/dataframe-gradle-plugin/src/integrationTest/kotlin/org/jetbrains/dataframe/gradle/SchemaGeneratorPluginIntegrationTest.kt

@@ -436,7 +436,7 @@ class SchemaGeneratorPluginIntegrationTest : AbstractDataFramePluginIntegrationT
                 
                 kotlin {
                     sourceSets {
-                        js {
+                        js(IR) {
                             browser()
                         }
                     }