Enabling linter for all modules except jdbc

Author: Jolanrensen

build.gradle.kts

@@ -1,7 +1,9 @@
 import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
+import org.jetbrains.kotlin.tooling.core.closure
 import org.jetbrains.kotlinx.publisher.apache2
 import org.jetbrains.kotlinx.publisher.developer
 import org.jetbrains.kotlinx.publisher.githubRepo
+import org.jmailen.gradle.kotlinter.KotlinterExtension
 
 @Suppress("DSL_SCOPE_VIOLATION", "UnstableApiUsage")
 plugins {
@@ -51,6 +53,31 @@ allprojects {
         sourceCompatibility = JavaVersion.VERSION_1_8.toString()
         targetCompatibility = JavaVersion.VERSION_1_8.toString()
     }
+
+    // Attempts to configure kotlinter for each sub-project that uses the plugin
+    afterEvaluate {
+        try {
+            kotlinter {
+                ignoreFailures = false
+                reporters = arrayOf("checkstyle", "plain")
+                experimentalRules = true
+                disabledRules = arrayOf(
+                    "no-wildcard-imports",
+                    "experimental:spacing-between-declarations-with-annotations",
+                    "experimental:enum-entry-name-case",
+                    "experimental:argument-list-wrapping",
+                    "experimental:annotation",
+                    "max-line-length",
+                    "filename",
+                    "comment-spacing",
+                    "curly-spacing",
+                    "experimental:annotation-spacing"
+                )
+            }
+        } catch (_: UnknownDomainObjectException) {
+            logger.warn("Could not set kotlinter config on :${this.name}")
+        }
+    }
 }
 
 koverMerged {

core/build.gradle.kts

@@ -298,24 +298,6 @@ korro {
     }
 }
 
-kotlinter {
-    ignoreFailures = false
-    reporters = arrayOf("checkstyle", "plain")
-    experimentalRules = true
-    disabledRules = arrayOf(
-        "no-wildcard-imports",
-        "experimental:spacing-between-declarations-with-annotations",
-        "experimental:enum-entry-name-case",
-        "experimental:argument-list-wrapping",
-        "experimental:annotation",
-        "max-line-length",
-        "filename",
-        "comment-spacing",
-        "curly-spacing",
-        "experimental:annotation-spacing"
-    )
-}
-
 tasks.withType<KspTaskJvm> {
     dependsOn(tasks.generateKeywordsSrc)
 }

core/generated-sources/src/main/kotlin/org/jetbrains/kotlinx/dataframe/jupyter/JupyterHtmlRenderer.kt

@@ -50,9 +50,9 @@ internal inline fun <reified T : Any> JupyterHtmlRenderer.render(
         includeCss = true,
     ).plus(
         df.toHTML(
-            configuration = reifiedDisplayConfiguration,
+            // is added later to make sure it's put outside of potential iFrames
+            configuration = reifiedDisplayConfiguration.copy(enableFallbackStaticTables = false),
             cellRenderer = contextRenderer,
-            includeStatic = false, // is added later to make sure it's put outside of potential iFrames
         ) { footer }
     ).toJupyterHtmlData()
 

dataframe-arrow/build.gradle.kts

@@ -2,6 +2,7 @@ plugins {
     kotlin("jvm")
     kotlin("libs.publisher")
     id("org.jetbrains.kotlinx.kover")
+    id("org.jmailen.kotlinter")
 }
 
 group = "org.jetbrains.kotlinx"

dataframe-excel/build.gradle.kts

@@ -2,6 +2,7 @@ plugins {
     kotlin("jvm")
     kotlin("libs.publisher")
     id("org.jetbrains.kotlinx.kover")
+    id("org.jmailen.kotlinter")
 }
 
 group = "org.jetbrains.kotlinx"

dataframe-jdbc/build.gradle.kts

@@ -3,6 +3,7 @@ plugins {
     kotlin("libs.publisher")
     id("org.jetbrains.kotlinx.kover")
     kotlin("jupyter.api")
+    // TODO enable later: id("org.jmailen.kotlinter")
 }
 
 group = "org.jetbrains.kotlinx"

dataframe-openapi/build.gradle.kts

@@ -3,7 +3,7 @@ plugins {
     kotlin("libs.publisher")
     kotlin("plugin.serialization")
     id("org.jetbrains.kotlinx.kover")
-
+    id("org.jmailen.kotlinter")
     kotlin("jupyter.api")
 }
 

plugins/dataframe-gradle-plugin/build.gradle.kts

@@ -5,6 +5,7 @@ plugins {
     `java-gradle-plugin`
     `maven-publish`
     id("com.gradle.plugin-publish") version "0.15.0"
+    id("org.jmailen.kotlinter")
 }
 
 repositories {

plugins/expressions-converter/build.gradle.kts

@@ -47,14 +47,6 @@ tasks.test {
     }
 }
 
-kotlinter {
-    ignoreFailures = false
-    reporters = arrayOf("checkstyle", "plain")
-    disabledRules = arrayOf(
-        "max-line-length",
-    )
-}
-
 sourceSets {
     main {
         java.setSrcDirs(listOf("src"))

plugins/symbol-processor/build.gradle

@@ -2,6 +2,7 @@ plugins {
     id("com.github.johnrengelman.shadow") version "7.1.2"
     id("org.jetbrains.kotlin.jvm")
     id("org.jetbrains.kotlin.libs.publisher")
+    id("org.jmailen.kotlinter")
 }
 
 repositories {