Skip to content

Commit f5ce103

Browse files
committed
K2 compatibility: tiny fixes regarding type resolution
1 parent 4337ec4 commit f5ce103

File tree

4 files changed

+14
-12
lines changed
  • core
    • generated-sources/src
    • src

4 files changed

+14
-12
lines changed

core/generated-sources/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/codeGen/CodeGeneratorImpl.kt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -156,11 +156,11 @@ internal object FullyQualifiedNames : TypeRenderingStrategy {
156156

157157
internal object ShortNames : TypeRenderingStrategy {
158158

159-
private val DataRow = DataRow::class.simpleName!!
160-
private val ColumnsContainer = ColumnsContainer::class.simpleName!!
161-
private val DataFrame = DataFrame::class.simpleName!!
162-
private val DataColumn = DataColumn::class.simpleName!!
163-
private val ColumnGroup = ColumnGroup::class.simpleName!!
159+
private val DataRow = org.jetbrains.kotlinx.dataframe.DataRow::class.simpleName!!
160+
private val ColumnsContainer = org.jetbrains.kotlinx.dataframe.ColumnsContainer::class.simpleName!!
161+
private val DataFrame = org.jetbrains.kotlinx.dataframe.DataFrame::class.simpleName!!
162+
private val DataColumn = org.jetbrains.kotlinx.dataframe.DataColumn::class.simpleName!!
163+
private val ColumnGroup = org.jetbrains.kotlinx.dataframe.columns.ColumnGroup::class.simpleName!!
164164

165165
override fun renderRowTypeName(markerName: String): String = "$DataRow<${markerName.shorten()}>"
166166

core/generated-sources/src/test/kotlin/org/jetbrains/kotlinx/dataframe/statistics/cumsum.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package org.jetbrains.kotlinx.dataframe.statistics
22

33
import io.kotest.matchers.shouldBe
4+
import org.jetbrains.kotlinx.dataframe.DataColumn
45
import org.jetbrains.kotlinx.dataframe.api.columnOf
56
import org.jetbrains.kotlinx.dataframe.api.concat
67
import org.jetbrains.kotlinx.dataframe.api.cumSum
@@ -43,7 +44,7 @@ class CumsumTests {
4344

4445
@Test
4546
fun `number column`() {
46-
val doubles by columnOf(1, 2, null, Double.NaN, 4)
47+
val doubles: DataColumn<Number?> by columnOf(1, 2, null, Double.NaN, 4)
4748
doubles.cumSum().toList() shouldBe listOf(1.0, 3.0, Double.NaN, Double.NaN, 7.0)
4849
}
4950

core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/codeGen/CodeGeneratorImpl.kt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -156,11 +156,11 @@ internal object FullyQualifiedNames : TypeRenderingStrategy {
156156

157157
internal object ShortNames : TypeRenderingStrategy {
158158

159-
private val DataRow = DataRow::class.simpleName!!
160-
private val ColumnsContainer = ColumnsContainer::class.simpleName!!
161-
private val DataFrame = DataFrame::class.simpleName!!
162-
private val DataColumn = DataColumn::class.simpleName!!
163-
private val ColumnGroup = ColumnGroup::class.simpleName!!
159+
private val DataRow = org.jetbrains.kotlinx.dataframe.DataRow::class.simpleName!!
160+
private val ColumnsContainer = org.jetbrains.kotlinx.dataframe.ColumnsContainer::class.simpleName!!
161+
private val DataFrame = org.jetbrains.kotlinx.dataframe.DataFrame::class.simpleName!!
162+
private val DataColumn = org.jetbrains.kotlinx.dataframe.DataColumn::class.simpleName!!
163+
private val ColumnGroup = org.jetbrains.kotlinx.dataframe.columns.ColumnGroup::class.simpleName!!
164164

165165
override fun renderRowTypeName(markerName: String): String = "$DataRow<${markerName.shorten()}>"
166166

core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/statistics/cumsum.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package org.jetbrains.kotlinx.dataframe.statistics
22

33
import io.kotest.matchers.shouldBe
4+
import org.jetbrains.kotlinx.dataframe.DataColumn
45
import org.jetbrains.kotlinx.dataframe.api.columnOf
56
import org.jetbrains.kotlinx.dataframe.api.concat
67
import org.jetbrains.kotlinx.dataframe.api.cumSum
@@ -43,7 +44,7 @@ class CumsumTests {
4344

4445
@Test
4546
fun `number column`() {
46-
val doubles by columnOf(1, 2, null, Double.NaN, 4)
47+
val doubles: DataColumn<Number?> by columnOf(1, 2, null, Double.NaN, 4)
4748
doubles.cumSum().toList() shouldBe listOf(1.0, 3.0, Double.NaN, Double.NaN, 7.0)
4849
}
4950

0 commit comments

Comments
 (0)