Skip to content

Commit feb8355

Browse files
committed
reverting back to the gradle plugin in :samples
1 parent f2ba9f0 commit feb8355

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

gradle/libs.versions.toml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,6 @@ spark = "3.3.2"
7373

7474
multik = "0.2.3"
7575

76-
# todo remove and use kotlin version instead
77-
dataframePlugin = "2.2.20-Beta2"
78-
7976
[libraries]
8077
ksp-gradle = { group = "com.google.devtools.ksp", name = "symbol-processing-gradle-plugin", version.ref = "ksp" }
8178
ksp-api = { group = "com.google.devtools.ksp", name = "symbol-processing-api", version.ref = "ksp" }
@@ -212,5 +209,4 @@ plugin-publish = { id = "com.gradle.plugin-publish", version.ref = "plugin-publi
212209
shadow = { id = "com.gradleup.shadow", version.ref = "shadow" }
213210
buildconfig = { id = "com.github.gmazzo.buildconfig", version.ref = "buildconfig" }
214211
kotlinx-benchmark = { id = "org.jetbrains.kotlinx.benchmark", version.ref = "benchmark" }
215-
# todo use kotlin version instead
216-
dataframePlugin = { id = "org.jetbrains.kotlin.plugin.dataframe", version.ref = "dataframePlugin" }
212+
dataframe-compiler-plugin = { id = "org.jetbrains.kotlin.plugin.dataframe", version.ref = "kotlin" }

samples/build.gradle.kts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,10 @@ plugins {
2323
alias(kotlin.jvm)
2424
alias(korro)
2525
alias(ktlint)
26-
// Doesn't work properly for now: https://github.com/Kotlin/dataframe/issues/1432
27-
alias(dataframePlugin)
26+
// Compiler plugin doesn't work properly for now: https://github.com/Kotlin/dataframe/issues/1432
27+
// alias(dataframePlugin)
28+
// using deprecated gradle plugin instead
29+
alias(dataframe)
2830
// alias(kover)
2931
alias(ksp)
3032
}

0 commit comments

Comments
 (0)