Not support transform get/set method

[penfeizhou]

Dukat cannot transform typescript's get or set method to kotlin.

[Schahen]

Can you please provide some code you are trying to convert.

[penfeizhou]

OK,please see follows:

TypeScript file:

export class Test {
    _prop = 0
    get prop() {
        return this._prop
    }
    set prop(v: number) {
        this._prop = v
    }
}

generated .d.ts

export declare class Test {
    _prop: number;
    get prop(): number;
    set prop(v: number);
}

Use dukat generate kt file:

@file:Suppress("INTERFACE_WITH_SUPERCLASS", "OVERRIDING_FINAL_MEMBER", "RETURN_TYPE_MISMATCH_ON_OVERRIDE", "CONFLICTING_OVERLOADS", "EXTERNAL_DELEGATION")

import kotlin.js.*
import kotlin.js.Json
import org.khronos.webgl.*
import org.w3c.dom.*
import org.w3c.dom.events.*
import org.w3c.dom.parsing.*
import org.w3c.dom.svg.*
import org.w3c.dom.url.*
import org.w3c.fetch.*
import org.w3c.files.*
import org.w3c.notifications.*
import org.w3c.performance.*
import org.w3c.workers.*
import org.w3c.xhr.*

external open class Test {
    open var _prop: Number
}

As you can see,generated kt file missed the prop property.

dukat version 0.0.28

[Schahen]

A-ha! Now it's clearer, thank you! If it's a syntactically valid construction (which it seem to be) we still need to support it.

It's very strange to me that it's generated that way - after all, it doesn't make much sense in the declaration context (compared to having just prop) - but that's only means I'm missing something.

[Schahen]

Here's relevant quote from documentation that explains the rationale behind translating getters and setters:

get and set Accessors Are Allowed in Ambient Contexts

In previous versions of TypeScript, the language didn’t allow get and set accessors in ambient contexts (like in declare-d classes, or in .d.ts files in general). The rationale was that accessors weren’t distinct from properties as far as writing and reading to these properties; however, because ECMAScript’s class fields proposal may have differing behavior from in existing versions of TypeScript, we realized we needed a way to communicate this different behavior to provide appropriate errors in subclasses.

As a result, users can write getters and setters in ambient contexts in TypeScript 3.6.

declare class Foo {
    // Allowed in 3.6+.
    get x(): number;
    set x(val: number): void;
}

In TypeScript 3.7, the compiler itself will take advantage of this feature so that generated .d.ts files will also emit get/set accessors.

[penfeizhou]

And I want report other two issues.

1. Miss the private attribute
2. Miss the abstract attribute

export declare class TestClass {
    private a;
    b: number;
    private aaa;
    bbb(): void;
}
export declare abstract class AbstractClass {
    abstract aaa(): void;
    bbb(): void;
}

What I got from dukat

external open class TestClass {
    open var a: Any
    open var b: Number
    open var aaa: Any
    open fun bbb()
}

external open class AbstractClass {
    open fun aaa()
    open fun bbb()
}

They all became open.