Skip to content

Commit 43d3d42

Browse files
committed
Get rid of scripting-dependencies in the shared-compiler module
1 parent 0b89eec commit 43d3d42

File tree

9 files changed

+15
-17
lines changed

9 files changed

+15
-17
lines changed

jupyter-lib/shared-compiler/build.gradle.kts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ dependencies {
2525
compileOnly(libs.kotlin.dev.scriptingCommon)
2626
compileOnly(libs.kotlin.dev.scriptingJvm)
2727
compileOnly(libs.kotlin.dev.scriptingCompilerImplUnshaded)
28-
compileOnly(libs.kotlin.dev.scriptingDependencies) { isTransitive = false }
2928

3029
// Serialization runtime
3130
compileOnly(libs.serialization.json)

jupyter-lib/shared-compiler/src/main/kotlin/org/jetbrains/kotlinx/jupyter/config/defaultImports.kt

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,5 @@
11
package org.jetbrains.kotlinx.jupyter.config
22

3-
import kotlin.script.experimental.dependencies.RepositoryCoordinates
4-
5-
val MAVEN_CENTRAL = RepositoryCoordinates("https://repo.maven.apache.org/maven2/")
6-
val JITPACK = RepositoryCoordinates("https://jitpack.io/")
7-
8-
val defaultRepositories = listOf(
9-
MAVEN_CENTRAL,
10-
JITPACK,
11-
)
12-
133
val defaultGlobalImports = listOf(
144
"kotlin.math.*",
155
"jupyter.kotlin.*",

src/main/kotlin/org/jetbrains/kotlinx/jupyter/config.kt

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,19 +14,24 @@ import kotlinx.serialization.json.decodeFromJsonElement
1414
import kotlinx.serialization.serializer
1515
import org.jetbrains.kotlinx.jupyter.api.KotlinKernelVersion
1616
import org.jetbrains.kotlinx.jupyter.common.getNameForUser
17-
import org.jetbrains.kotlinx.jupyter.config.defaultRepositories
1817
import org.jetbrains.kotlinx.jupyter.config.getLogger
1918
import org.jetbrains.kotlinx.jupyter.config.readResourceAsIniFile
2019
import org.jetbrains.kotlinx.jupyter.dependencies.ResolverConfig
2120
import org.jetbrains.kotlinx.jupyter.libraries.ResolutionInfoProvider
2221
import org.jetbrains.kotlinx.jupyter.libraries.getStandardResolver
2322
import org.zeromq.SocketType
2423
import java.io.File
24+
import kotlin.script.experimental.dependencies.RepositoryCoordinates
2525

2626
const val protocolVersion = "5.3"
2727

2828
internal val log by lazy { getLogger() }
2929

30+
val defaultRepositories = listOf(
31+
RepositoryCoordinates("https://repo.maven.apache.org/maven2/"),
32+
RepositoryCoordinates("https://jitpack.io/"),
33+
)
34+
3035
val defaultRuntimeProperties by lazy {
3136
RuntimeKernelProperties(readResourceAsIniFile("runtime.properties"))
3237
}
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
package org.jetbrains.kotlinx.jupyter.dependencies
2+
3+
import kotlin.script.experimental.api.ResultWithDiagnostics
4+
import kotlin.script.experimental.api.ScriptCompilationConfiguration
5+
6+
interface ScriptDependencyAnnotationHandler {
7+
fun configure(configuration: ScriptCompilationConfiguration, annotations: List<Annotation>): ResultWithDiagnostics<ScriptCompilationConfiguration>
8+
}
Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,6 @@ import kotlin.script.experimental.api.asSuccess
88
import kotlin.script.experimental.api.onSuccess
99
import kotlin.script.experimental.jvm.withUpdatedClasspath
1010

11-
interface ScriptDependencyAnnotationHandler {
12-
fun configure(configuration: ScriptCompilationConfiguration, annotations: List<Annotation>): ResultWithDiagnostics<ScriptCompilationConfiguration>
13-
}
14-
1511
open class ScriptDependencyAnnotationHandlerImpl(private val resolver: JupyterScriptDependenciesResolver) :
1612
ScriptDependencyAnnotationHandler {
1713
override fun configure(configuration: ScriptCompilationConfiguration, annotations: List<Annotation>): ResultWithDiagnostics<ScriptCompilationConfiguration> {

src/test/kotlin/org/jetbrains/kotlinx/jupyter/test/testUtil.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import org.jetbrains.kotlinx.jupyter.api.VariableStateImpl
1818
import org.jetbrains.kotlinx.jupyter.api.libraries.ExecutionHost
1919
import org.jetbrains.kotlinx.jupyter.api.libraries.JupyterIntegration
2020
import org.jetbrains.kotlinx.jupyter.api.libraries.LibraryDefinition
21-
import org.jetbrains.kotlinx.jupyter.config.defaultRepositories
21+
import org.jetbrains.kotlinx.jupyter.defaultRepositories
2222
import org.jetbrains.kotlinx.jupyter.defaultRuntimeProperties
2323
import org.jetbrains.kotlinx.jupyter.dependencies.ResolverConfig
2424
import org.jetbrains.kotlinx.jupyter.libraries.AbstractLibraryResolutionInfo

0 commit comments

Comments
 (0)