Skip to content

Commit 977cacb

Browse files
committed
Move common-dependencies to a more relevant destination
1 parent 5b0c6bc commit 977cacb

File tree

10 files changed

+40
-19
lines changed

10 files changed

+40
-19
lines changed

gradle.properties

Lines changed: 11 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,22 @@
1+
baseVersion=0.10.0
2+
13
# kotlinVersion=1.5.255-SNAPSHOT
24
kotlinVersion=1.6.0-dev-903
35
stableKotlinVersion=1.5.20
4-
gradleKotlinVersion=1.4.31
5-
kotlinLanguageLevel=1.5
6-
stableKotlinLanguageLevel=1.5
7-
jvmTarget=1.8
86

9-
shadowJarVersion=7.0.0
10-
changelogPluginVersion=1.7.0
11-
kotlinxSerializationVersion=1.1.0
127
ktlintGradleVersion=10.0.0
138
ktlintVersion=0.40.0
149
publishPluginVersion=0.0.29-dev
15-
junitVersion=5.7.1
16-
slf4jVersion=1.7.30
17-
logbackVersion=1.2.3
18-
http4kVersion=4.9.8.0
19-
artifactsPath=build/artifacts
10+
jupyterApiVersion=0.9.1-45
2011

21-
baseVersion=0.10.0
12+
kotlinLanguageLevel=1.5
13+
stableKotlinLanguageLevel=1.5
14+
jvmTarget=1.8
15+
16+
kotlin.jupyter.add.api=false
17+
kotlin.jupyter.add.scanner=false
18+
19+
artifactsPath=build/artifacts
2220

2321
githubRepoUser=Kotlin
2422
githubRepoName=kotlin-jupyter
@@ -33,7 +31,3 @@ org.gradle.jvmargs=-XX:MaxMetaspaceSize=1024m -Xmx2048m
3331

3432
# Turn off README check when running check task
3533
skipReadmeCheck=false
36-
37-
jupyterApiVersion=0.9.1-45
38-
kotlin.jupyter.add.api=false
39-
kotlin.jupyter.add.scanner=false

kotlin-jupyter-plugin/build.gradle.kts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,12 @@ plugins {
77

88
repositories {
99
mavenCentral()
10+
gradlePluginPortal()
1011
}
1112

1213
dependencies {
13-
implementation(project(":common-dependencies"))
14+
implementation(projects.commonDependencies)
15+
api(libs.bundles.allGradlePlugins)
1416
}
1517

1618
gradlePlugin {

kotlin-jupyter-plugin/settings.gradle.kts

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,13 @@
11
@file:Suppress("UnstableApiUsage")
22

3+
dependencyResolutionManagement {
4+
versionCatalogs {
5+
create("libs") {
6+
from(files("../gradle/libs.versions.toml"))
7+
}
8+
}
9+
}
10+
311
pluginManagement {
412
fun findRootProperties(): java.util.Properties {
513
var fileName = "gradle.properties"
@@ -46,4 +54,9 @@ pluginManagement {
4654
}
4755
}
4856

49-
include("common-dependencies")
57+
subproject("common-dependencies", "../jupyter-lib/")
58+
59+
fun subproject(name: String, parentPath: String) {
60+
include(name)
61+
project(":$name").projectDir = file("$parentPath$name").absoluteFile
62+
}

kotlin-jupyter-plugin/src/main/kotlin/org/jetbrains/kotlinx/jupyter/plugin/KotlinJupyterGradlePlugin.kt

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,18 @@ import org.jetbrains.kotlinx.jupyter.build.prepareReadmeTasks
1616

1717
class KotlinJupyterGradlePlugin : Plugin<Project> {
1818
override fun apply(project: Project) {
19+
20+
with(project.plugins) {
21+
apply("org.jetbrains.kotlin.jvm")
22+
apply("com.github.johnrengelman.shadow")
23+
apply("org.jetbrains.kotlin.plugin.serialization")
24+
apply("org.jlleitschuh.gradle.ktlint")
25+
apply("org.jetbrains.kotlinx.jupyter.dependencies")
26+
apply("ru.ileasile.kotlin.publisher")
27+
apply("ru.ileasile.kotlin.doc")
28+
apply("org.hildan.github.changelog")
29+
}
30+
1931
with(ProjectWithOptionsImpl(project, project.options())) {
2032
/****** Helper tasks ******/
2133
prepareReadmeTasks()

0 commit comments

Comments
 (0)