Rename DayOfWeek.number to isoDayNumber

Author: ilya-g

core/commonMain/src/DayOfWeek.kt

@@ -17,11 +17,11 @@ public expect enum class DayOfWeek {
     SUNDAY;
 }
 
-public val DayOfWeek.number: Int get() = ordinal + 1
+public val DayOfWeek.isoDayNumber: Int get() = ordinal + 1
 
 @SharedImmutable
 private val allDaysOfWeek = DayOfWeek.values().asList()
-public fun DayOfWeek(number: Int): DayOfWeek {
-    require(number in 1..7)
-    return allDaysOfWeek[number - 1]
+public fun DayOfWeek(isoDayNumber: Int): DayOfWeek {
+    require(isoDayNumber in 1..7)
+    return allDaysOfWeek[isoDayNumber - 1]
 }

core/commonTest/src/LocalDateTest.kt

@@ -22,7 +22,7 @@ class LocalDateTest {
         assertEquals(month, value.monthNumber)
         assertEquals(Month(month), value.month)
         assertEquals(day, value.dayOfMonth)
-        if (dayOfWeek != null) assertEquals(dayOfWeek, value.dayOfWeek.number)
+        if (dayOfWeek != null) assertEquals(dayOfWeek, value.dayOfWeek.isoDayNumber)
         if (dayOfYear != null) assertEquals(dayOfYear, value.dayOfYear)
 
         val fromComponents = LocalDate(year, month, day)
@@ -31,7 +31,7 @@ class LocalDateTest {
 
     fun checkLocalDateTimePart(date: LocalDate, datetime: LocalDateTime) {
         checkEquals(date, datetime.date)
-        checkComponents(date, datetime.year, datetime.monthNumber, datetime.dayOfMonth, datetime.dayOfWeek.number, datetime.dayOfYear)
+        checkComponents(date, datetime.year, datetime.monthNumber, datetime.dayOfMonth, datetime.dayOfWeek.isoDayNumber, datetime.dayOfYear)
     }
 
     @Test

core/commonTest/src/LocalDateTimeTest.kt

@@ -120,7 +120,7 @@ fun checkComponents(value: LocalDateTime, year: Int, month: Int, day: Int, hour:
     assertEquals(minute, value.minute, "minutes")
     assertEquals(second, value.second, "seconds")
     assertEquals(nanosecond, value.nanosecond, "nanoseconds")
-    if (dayOfWeek != null) assertEquals(dayOfWeek, value.dayOfWeek.number, "weekday")
+    if (dayOfWeek != null) assertEquals(dayOfWeek, value.dayOfWeek.isoDayNumber, "weekday")
     if (dayOfYear != null) assertEquals(dayOfYear, value.dayOfYear, "day of year")
 
     val fromComponents = LocalDateTime(year, month, day, hour, minute, second, nanosecond)

core/nativeTest/src/ThreeTenBpLocalDateTest.kt

@@ -62,7 +62,7 @@ class ThreeTenBpLocalDateTest {
             for (i in 1..length) {
                 val d = LocalDate(2007, month, i)
                 assertSame(d.dayOfWeek, dow)
-                dow = DayOfWeek(dow.number % 7 + 1)
+                dow = DayOfWeek(dow.isoDayNumber % 7 + 1)
             }
         }
     }