StackOverflowError on circular reference #376

Author: Mr3zee

compiler-plugin/compiler-plugin-k2/src/main/kotlin/kotlinx/rpc/codegen/checkers/FirRpcStrictModeClassChecker.kt

@@ -74,7 +74,7 @@ object FirRpcStrictModeClassChecker {
         } memoryOptimizedPlus (function.resolvedReturnTypeRef.source to function.resolvedReturnTypeRef)
 
         types.forEach { (source, symbol) ->
-            checkSerializableTypes<FirClassLikeSymbol<*>>(
+            checkSerializableTypes(
                 context = context,
                 typeRef = symbol,
                 serializablePropertiesProvider = serializablePropertiesProvider,
@@ -96,8 +96,6 @@ object FirRpcStrictModeClassChecker {
                         }
                     }
                 }
-
-                symbol
             }
         }
 
@@ -106,34 +104,36 @@ object FirRpcStrictModeClassChecker {
         }
     }
 
-    private fun <ContextElement> checkSerializableTypes(
+    private fun checkSerializableTypes(
         context: CheckerContext,
         typeRef: FirTypeRef,
         serializablePropertiesProvider: FirSerializablePropertiesProvider,
-        parentContext: List<ContextElement> = emptyList(),
-        checker: (FirClassLikeSymbol<*>, List<ContextElement>) -> ContextElement?,
+        parentContext: List<FirClassLikeSymbol<*>> = emptyList(),
+        checker: (FirClassLikeSymbol<*>, List<FirClassLikeSymbol<*>>) -> Unit,
     ) {
         val symbol = typeRef.toClassLikeSymbol(context.session) ?: return
-        val newElement = checker(symbol, parentContext)
-        val nextContext = if (newElement != null) {
-            parentContext memoryOptimizedPlus newElement
-        } else {
-            parentContext
-        }
+
+        checker(symbol, parentContext)
 
         if (symbol !is FirClassSymbol<*>) {
             return
         }
 
-        val extracted = extractArgumentsTypeRefAndSource(typeRef)
+        val nextContext = parentContext memoryOptimizedPlus symbol
+
+        if (symbol in parentContext && symbol.typeParameterSymbols.isEmpty()) {
+            return
+        }
+
+        val typeParameters = extractArgumentsTypeRefAndSource(typeRef)
             .orEmpty()
             .withIndex()
             .associate { (i, refSource) ->
                 symbol.typeParameterSymbols[i].toConeType() to refSource.typeRef
             }
 
         val flowProps: List<FirTypeRef> = if (symbol.classId == RpcClassId.flow) {
-            listOf(extracted.values.toList()[0]!!)
+            listOf(typeParameters.values.toList()[0]!!)
         } else {
             emptyList()
         }
@@ -144,7 +144,7 @@ object FirRpcStrictModeClassChecker {
                 if (resolvedTypeRef.toClassLikeSymbol(context.session) != null) {
                     resolvedTypeRef
                 } else {
-                    extracted[property.resolvedReturnType]
+                    typeParameters[property.resolvedReturnType]
                 }
             }.memoryOptimizedPlus(flowProps)
             .forEach { symbol ->

compiler-plugin/gradle.properties

@@ -15,7 +15,7 @@ org.gradle.parallel=true
 org.gradle.workers.max=8
 org.gradle.caching=true
 org.gradle.configuration-cache=true
-org.gradle.configureondemand=true
+#org.gradle.configureondemand=true // breaks compiler tests
 
 org.jetbrains.dokka.experimental.gradle.pluginMode=V2Enabled
 org.jetbrains.dokka.experimental.gradle.pluginMode.noWarn=true

dokka-plugin/gradle.properties

@@ -15,7 +15,7 @@ org.gradle.parallel=true
 org.gradle.workers.max=8
 org.gradle.caching=true
 org.gradle.configuration-cache=true
-org.gradle.configureondemand=true
+#org.gradle.configureondemand=true // breaks compiler tests
 
 org.jetbrains.dokka.experimental.gradle.pluginMode=V2Enabled
 org.jetbrains.dokka.experimental.gradle.pluginMode.noWarn=true

gradle-conventions/src/main/kotlin/conventions-common.gradle.kts

@@ -1,5 +1,5 @@
 /*
- * Copyright 2023-2024 JetBrains s.r.o and contributors. Use of this source code is governed by the Apache 2.0 license.
+ * Copyright 2023-2025 JetBrains s.r.o and contributors. Use of this source code is governed by the Apache 2.0 license.
  */
 
 import io.gitlab.arturbosch.detekt.Detekt

gradle-conventions/src/main/kotlin/conventions-kmp.gradle.kts

@@ -1,5 +1,5 @@
 /*
- * Copyright 2023-2024 JetBrains s.r.o and contributors. Use of this source code is governed by the Apache 2.0 license.
+ * Copyright 2023-2025 JetBrains s.r.o and contributors. Use of this source code is governed by the Apache 2.0 license.
  */
 
 @file:OptIn(ExperimentalAbiValidation::class)

gradle-conventions/src/main/kotlin/conventions-publishing.gradle.kts

@@ -138,15 +138,6 @@ fun RepositoryHandler.configureLocalDevRepository() {
     }
 }
 
-val sonatypeRepositoryUri: String?
-    get() {
-        val repositoryId: String = project.getSensitiveProperty("libs.repository.id")
-            ?.takeIf { it.isNotBlank() }
-            ?: return null
-
-        return "https://oss.sonatype.org/service/local/staging/deployByRepositoryId/$repositoryId"
-    }
-
 fun configureEmptyJavadocArtifact(): TaskProvider<Jar?> {
     val javadocJar by project.tasks.registering(Jar::class) {
         archiveClassifier.set("javadoc")

gradle-plugin/gradle.properties

@@ -15,7 +15,7 @@ org.gradle.parallel=true
 org.gradle.workers.max=8
 org.gradle.caching=true
 org.gradle.configuration-cache=true
-org.gradle.configureondemand=true
+#org.gradle.configureondemand=true // breaks compiler tests
 
 org.jetbrains.dokka.experimental.gradle.pluginMode=V2Enabled
 org.jetbrains.dokka.experimental.gradle.pluginMode.noWarn=true

gradle.properties

@@ -15,7 +15,7 @@ org.gradle.parallel=true
 org.gradle.workers.max=8
 org.gradle.caching=true
 org.gradle.configuration-cache=true
-org.gradle.configureondemand=true
+#org.gradle.configureondemand=true // breaks compiler tests
 
 org.jetbrains.dokka.experimental.gradle.pluginMode=V2Enabled
 org.jetbrains.dokka.experimental.gradle.pluginMode.noWarn=true

tests/compiler-plugin-tests/src/testData/diagnostics/strictMode.fir.txt

@@ -48,6 +48,37 @@ FILE: b.kt
 
         public final fun copy(flow1: R|kotlinx/coroutines/flow/Flow<kotlin/Int>| = this@R|/MultiFlow|.R|/MultiFlow.flow1|, flow2: R|kotlinx/coroutines/flow/Flow<kotlin/Int>| = this@R|/MultiFlow|.R|/MultiFlow.flow2|, flow3: R|kotlinx/coroutines/flow/Flow<kotlin/Int>| = this@R|/MultiFlow|.R|/MultiFlow.flow3|): R|MultiFlow|
 
+    }
+    public final data class ComplexFilter : R|kotlin/Any| {
+        public constructor(a: R|SimpleFilter?|, b: R|ComplexFilter?|): R|ComplexFilter| {
+            super<R|kotlin/Any|>()
+        }
+
+        public final val a: R|SimpleFilter?| = R|<local>/a|
+            public get(): R|SimpleFilter?|
+
+        public final val b: R|ComplexFilter?| = R|<local>/b|
+            public get(): R|ComplexFilter?|
+
+        public final operator fun component1(): R|SimpleFilter?|
+
+        public final operator fun component2(): R|ComplexFilter?|
+
+        public final fun copy(a: R|SimpleFilter?| = this@R|/ComplexFilter|.R|/ComplexFilter.a|, b: R|ComplexFilter?| = this@R|/ComplexFilter|.R|/ComplexFilter.b|): R|ComplexFilter|
+
+    }
+    public final data class SimpleFilter : R|kotlin/Any| {
+        public constructor(text: R|kotlin/String|): R|SimpleFilter| {
+            super<R|kotlin/Any|>()
+        }
+
+        public final val text: R|kotlin/String| = R|<local>/text|
+            public get(): R|kotlin/String|
+
+        public final operator fun component1(): R|kotlin/String|
+
+        public final fun copy(text: R|kotlin/String| = this@R|/SimpleFilter|.R|/SimpleFilter.text|): R|SimpleFilter|
+
     }
     @R|kotlinx/rpc/annotations/Rpc|() public abstract interface MyService : R|kotlin/Any| {
         public abstract val flow: R|kotlinx/coroutines/flow/Flow<kotlin/Int>|
@@ -105,6 +136,8 @@ FILE: b.kt
 
         public abstract fun nonSuspendNoFlowString(): R|kotlin/String|
 
+        public abstract suspend fun complex(filter: R|ComplexFilter|): R|kotlin/String|
+
         public final class $rpcServiceStub : R|kotlin/Any| {
             public final companion object Companion : R|kotlin/Any| {
             }

tests/compiler-plugin-tests/src/testData/diagnostics/strictMode.kt

@@ -29,6 +29,13 @@ data class MultiFlow(
     val flow3: Flow<Int>,
 )
 
+data class ComplexFilter(
+    val a: SimpleFilter?,
+    val b: ComplexFilter?
+)
+
+data class SimpleFilter(val text: String)
+
 @Rpc
 interface MyService {
     <!FIELD_IN_RPC_SERVICE!>val flow: Flow<Int><!>
@@ -57,4 +64,5 @@ interface MyService {
     suspend fun clientNestedTrickyFlow(<!NESTED_STREAMING_IN_RPC_SERVICE!>inner: Wrapper<Flow<Wrapper<Flow<Int>>>><!>)
     <!NON_SUSPENDING_REQUEST_WITHOUT_STREAMING_RETURN_TYPE!>fun nonSuspendNoFlow()<!>
     <!NON_SUSPENDING_REQUEST_WITHOUT_STREAMING_RETURN_TYPE!>fun nonSuspendNoFlowString(): String<!>
+    suspend fun complex(filter: ComplexFilter): String // doesn't fail on circular dependency
 }