Skip to content

Commit 9c8fdf4

Browse files
Mr3zeemartinbonnin
andauthored
Use compat-patrouille for compatibility settings (#438)
Co-authored-by: Martin Bonnin <[email protected]>
1 parent 9244646 commit 9c8fdf4

File tree

15 files changed

+93
-105
lines changed

15 files changed

+93
-105
lines changed

build.gradle.kts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ plugins {
99
alias(libs.plugins.kotlinx.rpc) apply false
1010
alias(libs.plugins.atomicfu) apply false
1111
alias(libs.plugins.conventions.kover)
12-
alias(libs.plugins.conventions.gradle.doctor)
1312
alias(libs.plugins.conventions.root)
1413
}
1514

compiler-plugin/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import util.whenForIde
66

77
plugins {
8-
alias(libs.plugins.conventions.gradle.doctor)
8+
id("empty") // resolve conventions classpath
99
}
1010

1111
val rpcVersion: String = libs.versions.kotlinx.rpc.get()

dokka-plugin/build.gradle.kts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
*/
44

55
plugins {
6-
alias(libs.plugins.conventions.gradle.doctor)
76
alias(libs.plugins.kotlin.jvm)
87
}
98

@@ -12,10 +11,6 @@ version = libs.versions.kotlinx.rpc.get()
1211

1312
logger.lifecycle("[Dokka Plugin] kotlinx.rpc project version: $version, Kotlin version: ${libs.versions.kotlin.lang.get()}")
1413

15-
kotlin {
16-
jvmToolchain(8)
17-
}
18-
1914
dependencies {
2015
compileOnly(libs.dokka.core)
2116
compileOnly(libs.dokka.base)

gradle-conventions/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ dependencies {
1010
implementation(libs.kotlin.gradle.plugin)
1111
implementation(libs.detekt.gradle.plugin)
1212
implementation(libs.dokka.gradle.plugin)
13-
implementation(libs.gradle.doctor.gradle.plugin)
1413
implementation(libs.gradle.publish.gradle.plugin)
14+
implementation(libs.compat.patrouille.gradle.plugin)
1515

1616
implementation(libs.kover.gradle.plugin)
1717

gradle-conventions/src/main/kotlin/conventions-gradle-doctor.gradle.kts

Lines changed: 0 additions & 13 deletions
This file was deleted.

gradle-conventions/src/main/kotlin/conventions-jvm.gradle.kts

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
/*
2-
* Copyright 2023-2024 JetBrains s.r.o and contributors. Use of this source code is governed by the Apache 2.0 license.
2+
* Copyright 2023-2025 JetBrains s.r.o and contributors. Use of this source code is governed by the Apache 2.0 license.
33
*/
44

55
@file:OptIn(ExperimentalAbiValidation::class)
66

7+
import compat.patrouille.configureJavaCompatibility
8+
import compat.patrouille.configureKotlinCompatibility
79
import org.jetbrains.kotlin.gradle.dsl.abi.ExperimentalAbiValidation
810
import util.configureAbiFilters
911
import util.enableAbiValidation
@@ -18,11 +20,10 @@ java {
1820
withSourcesJar()
1921
}
2022

21-
kotlin {
22-
jvmToolchain {
23-
languageVersion.set(JavaLanguageVersion.of(8))
24-
}
23+
configureJavaCompatibility(8)
24+
configureKotlinCompatibility("2.0.0")
2525

26+
kotlin {
2627
explicitApi()
2728

2829
abiValidation {

gradle-conventions/src/main/kotlin/conventions-kmp.gradle.kts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44

55
@file:OptIn(ExperimentalAbiValidation::class)
66

7+
import compat.patrouille.configureJavaCompatibility
8+
import compat.patrouille.configureKotlinCompatibility
79
import org.jetbrains.kotlin.gradle.dsl.abi.ExperimentalAbiValidation
810
import util.*
911
import util.targets.configureJs
@@ -38,3 +40,5 @@ withKmpConfig {
3840
}
3941

4042
configureJvm(isKmp = true)
43+
44+
configureJavaCompatibility(8)

gradle-conventions/src/main/kotlin/conventions-kotlin-version.gradle.kts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import org.jetbrains.kotlin.gradle.dsl.KotlinCommonCompilerOptions
66
import org.jetbrains.kotlin.gradle.dsl.KotlinProjectExtension
77
import org.jetbrains.kotlin.gradle.dsl.KotlinVersion
8-
import org.jetbrains.kotlin.gradle.plugin.KotlinCompilation
8+
import util.other.libs
99
import util.withKotlinJvmExtension
1010
import util.withKotlinKmpExtension
1111

@@ -31,12 +31,11 @@ fun KotlinCommonCompilerOptions.setProjectLanguageVersion() {
3131

3232
withKotlinJvmExtension {
3333
optInForRpcApi()
34-
35-
compilerOptions.setProjectLanguageVersion()
3634
}
3735

3836
withKotlinKmpExtension {
3937
optInForRpcApi()
4038

39+
// We don't use `compat-patrouille` here because it sets stdlib version, and that breaks WASM tests.
4140
compilerOptions.setProjectLanguageVersion()
4241
}
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
/*
2+
* Copyright 2023-2025 JetBrains s.r.o and contributors. Use of this source code is governed by the Apache 2.0 license.
3+
*/
4+
5+
// DON'T DELETE.
6+
// Resolves conventions classpath where no other convention is applied

gradle-conventions/src/main/kotlin/util/targets/configure.kt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,10 +60,6 @@ fun KmpConfig.configureKotlinExtension(action: Action<KotlinMultiplatformExtensi
6060

6161
configureDetekt(includedTargets)
6262

63-
jvmToolchain {
64-
languageVersion.set(JavaLanguageVersion.of(8))
65-
}
66-
6763
action.execute(this)
6864
}
6965
}

0 commit comments

Comments
 (0)