grpc-pb: Remove hadError() method

Signed-off-by: Johannes Zottele <[email protected]>

Author: Jozott00

grpc/grpc-core/src/commonMain/kotlin/kotlinx/rpc/grpc/GrpcException.kt

@@ -17,7 +17,7 @@ public class ProtobufDecodingException : GrpcException {
             ProtobufDecodingException("Message '$messageName' is missing a required field: $fieldName")
 
         internal fun negativeSize() = ProtobufDecodingException(
-            "CodedInputStream encountered an embedded string or message which claimed to have negative size."
+            "Decoder encountered an embedded string or message which claimed to have negative size."
         )
 
         internal fun invalidTag() = ProtobufDecodingException(

grpc/grpc-core/src/commonMain/kotlin/kotlinx/rpc/grpc/pb/WireDecoder.kt

@@ -5,6 +5,7 @@
 package kotlinx.rpc.grpc.pb
 
 import kotlinx.io.Buffer
+import kotlinx.rpc.grpc.ProtobufDecodingException
 import kotlinx.rpc.grpc.internal.popLimit
 import kotlinx.rpc.grpc.internal.pushLimit
 import kotlinx.rpc.internal.utils.InternalRpcApi
@@ -41,8 +42,6 @@ internal const val MAX_PACKED_BULK_SIZE: Int = 1_000_000
  */
 @InternalRpcApi
 public interface WireDecoder : AutoCloseable {
-    public fun hadError(): Boolean
-
     /**
      * When the read tag is null, it indicates EOF and the parser may stop at this point.
      */
@@ -79,11 +78,9 @@ public interface WireDecoder : AutoCloseable {
     public fun readPackedDouble(): List<Double>
     public fun readPackedEnum(): List<Int>
 
-    // TODO: Throw error instead of just returning
     public fun <T : InternalMessage> readMessage(msg: T, decoder: (T, WireDecoder) -> Unit) {
         val len = readInt32()
-        if (hadError()) return
-        if (len <= 0) return
+        if (len < 0) throw ProtobufDecodingException.negativeSize()
         val limit = pushLimit(len)
         decoder(msg, this)
         popLimit(limit)

grpc/grpc-core/src/commonTest/kotlin/kotlinx/rpc/grpc/pb/WireCodecTest.kt

@@ -28,7 +28,6 @@ class WireCodecTest {
         val decoder = WireDecoder(buffer)
 
         val tag = decoder.readTag()
-        assertFalse(decoder.hadError())
         assertNotNull(tag)
         assertEquals(WireType.VARINT, tag.wireType)
         assertEquals(fieldNr, tag.fieldNr)

grpc/grpc-core/src/jvmMain/kotlin/kotlinx/rpc/grpc/pb/WireDecoder.jvm.kt

@@ -15,11 +15,6 @@ internal class WireDecoderJvm(source: Buffer) : WireDecoder {
     // there is no way to omit coping here
     internal val codedInputStream: CodedInputStream = CodedInputStream.newInstance(source.asInputStream())
 
-    // errors in jvm are exceptions
-    override fun hadError(): Boolean {
-        return false
-    }
-
     override fun readTag(): KTag? = checked {
         val tag = codedInputStream.readTag().toUInt()
         if (tag == 0u) {

grpc/grpc-core/src/nativeMain/kotlin/kotlinx/rpc/grpc/pb/WireDecoder.native.kt

@@ -60,10 +60,6 @@ internal class WireDecoderNative(private val source: Buffer) : WireDecoder {
         zeroCopyInput.dispose()
     }
 
-    override fun hadError(): Boolean {
-        return false
-    }
-
     override fun readTag(): KTag? {
         val tag = pw_decoder_read_tag(raw)
         if (tag == 0u) {

protoc-gen/src/main/kotlin/kotlinx/rpc/protobuf/ModelToKotlinCommonGenerator.kt

@@ -284,7 +284,7 @@ class ModelToKotlinCommonGenerator(
         annotations = listOf("@$INTERNAL_RPC_API_ANNO"),
         contextReceiver = "${declaration.internalClassFullName()}.Companion"
     ) {
-        whileBlock("!decoder.hadError()") {
+        whileBlock("true") {
             code("val tag = decoder.readTag() ?: break // EOF, we read the whole message")
             whenBlock {
                 declaration.fields().forEach { (_, field) -> readMatchCase(field) }
@@ -294,10 +294,6 @@ class ModelToKotlinCommonGenerator(
                 }
             }
         }
-        ifBranch(
-            condition = "decoder.hadError()",
-            ifBlock = { code("error(\"Error during decoding of ${declaration.name.simpleName}\")") }
-        )
 
         // TODO: Make lists and maps immutable (KRPC-190)
     }