grpc-native: Address PR comments

Signed-off-by: Johannes Zottele <[email protected]>

Author: Jozott00

grpc/grpc-core/src/nativeMain/kotlin/kotlinx/rpc/grpc/ManagedChannel.native.kt

@@ -6,10 +6,7 @@
 
 package kotlinx.rpc.grpc
 
-import kotlinx.rpc.grpc.internal.GrpcChannel
-import kotlinx.rpc.grpc.internal.GrpcCredentials
-import kotlinx.rpc.grpc.internal.GrpcInsecureCredentials
-import kotlinx.rpc.grpc.internal.NativeManagedChannel
+import kotlinx.rpc.grpc.internal.*
 
 /**
  * Same as [ManagedChannel], but is platform-exposed.
@@ -31,7 +28,6 @@ internal class NativeManagedChannelBuilder(
     private var credentials: GrpcCredentials? = null
 
     override fun usePlaintext(): NativeManagedChannelBuilder {
-        check(credentials == null) { "Credentials already set" }
         credentials = GrpcInsecureCredentials()
         return this
     }
@@ -46,7 +42,7 @@ internal class NativeManagedChannelBuilder(
 }
 
 internal actual fun ManagedChannelBuilder<*>.buildChannel(): ManagedChannel {
-    check(this is NativeManagedChannelBuilder) { "Wrong builder type, expected NativeManagedChannelBuilder" }
+    check(this is NativeManagedChannelBuilder) { internalError("Wrong builder type, expected NativeManagedChannelBuilder") }
     return buildChannel()
 }
 

grpc/grpc-core/src/nativeMain/kotlin/kotlinx/rpc/grpc/internal/CompletionQueue.kt

@@ -52,7 +52,7 @@ internal class CompletionQueue {
 
     // if the shutdown() was called with forceShutdown = true,
     // it will reject all new batches and wait for all current ones to finish.
-    private var forceShutdown = false
+    private val forceShutdown = atomic(false)
 
     // internal as it must be accessible from the SHUTDOWN_CB,
     // but it shouldn't be used from outside this file.
@@ -109,7 +109,7 @@ internal class CompletionQueue {
                 return BatchResult.CQShutdown
             }
 
-            if (forceShutdown || _state.value == State.CLOSED) {
+            if (forceShutdown.value || _state.value == State.CLOSED) {
                 // if the queue is either closed or in the process of a FORCE shutdown,
                 // new batches will instantly fail.
                 deleteCbTag(tag)
@@ -139,7 +139,7 @@ internal class CompletionQueue {
      */
     fun shutdown(force: Boolean = false): CallbackFuture<Unit> {
         if (force) {
-            forceShutdown = true
+            forceShutdown.value = true
         }
         if (!_state.compareAndSet(State.OPEN, State.SHUTTING_DOWN)) {
             // the first call to shutdown() makes transition and to SHUTTING_DOWN and

grpc/grpc-core/src/nativeMain/kotlin/kotlinx/rpc/grpc/internal/utils.kt

@@ -47,7 +47,7 @@ internal fun grpc_slice.toByteArray(): ByteArray = memScoped {
 internal fun CPointer<grpc_byte_buffer>.toKotlin(): Buffer = memScoped {
     val reader = alloc<grpc_byte_buffer_reader>()
     check(grpc_byte_buffer_reader_init(reader.ptr, this@toKotlin) == 1)
-    { "Failed to initialized byte buffer." }
+    { internalError("Failed to initialized byte buffer.") }
 
     val out = Buffer()
     val slice = alloc<grpc_slice>()