Skip to content

Commit e498074

Browse files
committed
grpc-native: Address PR comments
Signed-off-by: Johannes Zottele <[email protected]>
1 parent a5b2854 commit e498074

File tree

7 files changed

+6
-2
lines changed

7 files changed

+6
-2
lines changed
32.5 MB
Binary file not shown.
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
b1023a3c07c18bd1be3066bd101380d99b56b22a725e15fed6f2bb67e6548765

cinterop-c/toolchain/cc_toolchain_config.bzl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@ ALL_ACTIONS = [
2121
ACTION_NAMES.cpp_link_static_library,
2222
]
2323

24+
# Constructs the toolchain configuration by defining all necessary flags and toolchain wrapper scripts.
25+
# The wrapper scripts call Konan which delegates all requests to the corresponding clang/llvm tools.
26+
# Additionally it includes all built-in include directories from the Konan toolchain and sysroot.
2427
def _impl(ctx):
2528
target = ctx.attr.target
2629
home = ctx.var.get("KONAN_HOME")

grpc/grpc-core/gradle.properties

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
kotlinx.rpc.exclude.wasmWasi=true
55
kotlinx.rpc.exclude.js=true
66
kotlinx.rpc.exclude.wasmJs=true
7-
kotlinx.rpc.exclude.macosX64=true
87
kotlinx.rpc.exclude.mingwX64=true
98
kotlinx.rpc.exclude.tvosArm64=true
109
kotlinx.rpc.exclude.tvosSimulatorArm64=true

grpc/grpc-core/src/nativeInterop/cinterop/libkgrpc.def

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ noStringConversion = grpc_slice_from_copied_buffer my_grpc_slice_from_copied_buf
99
strictEnums = grpc_status_code grpc_connectivity_state grpc_call_error
1010

1111
staticLibraries.macos_arm64 = libkgrpc.macos_arm64.a libgrpc_fat.macos_arm64.a
12+
staticLibraries.macos_x64 = libkgrpc.macos_x64.a libgrpc_fat.macos_x64.a
1213
staticLibraries.ios_arm64 = libkgrpc.ios_arm64.a libgrpc_fat.ios_arm64.a
1314
staticLibraries.ios_simulator_arm64 = libkgrpc.ios_simulator_arm64.a libgrpc_fat.ios_simulator_arm64.a
1415
staticLibraries.ios_x64 = libkgrpc.ios_x64.a libgrpc_fat.ios_x64.a

protobuf/protobuf-core/gradle.properties

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
kotlinx.rpc.exclude.wasmWasi=true
55
kotlinx.rpc.exclude.js=true
66
kotlinx.rpc.exclude.wasmJs=true
7-
kotlinx.rpc.exclude.macosX64=true
87
kotlinx.rpc.exclude.mingwX64=true
98
kotlinx.rpc.exclude.tvosArm64=true
109
kotlinx.rpc.exclude.tvosSimulatorArm64=true

protobuf/protobuf-core/src/nativeInterop/cinterop/libprotowire.def

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ noStringConversion = pw_encoder_write_string
55

66

77
staticLibraries.macos_arm64 = libprotowire_fat.macos_arm64.a
8+
staticLibraries.macos_x64 = libprotowire_fat.macos_x64.a
89
staticLibraries.ios_arm64 = libprotowire_fat.ios_arm64.a
910
staticLibraries.ios_simulator_arm64 = libprotowire_fat.ios_simulator_arm64.a
1011
staticLibraries.ios_x64 = libprotowire_fat.ios_x64.a

0 commit comments

Comments
 (0)