Skip to content

Conversation

Mr3zee
Copy link
Member

@Mr3zee Mr3zee commented Sep 18, 2025

Subsystem
gRPC, Compiler Plugin

Problem Description
Java and other impls support safe, idempotent and sampledToLocalTracing parameters for methods

Solution
Support them and also method name + add custom chekers

@Mr3zee Mr3zee requested a review from Jozott00 September 18, 2025 16:07
@Mr3zee Mr3zee self-assigned this Sep 18, 2025
@Mr3zee Mr3zee added the feature New feature or request label Sep 18, 2025
@Mr3zee Mr3zee marked this pull request as ready for review September 18, 2025 16:42
Copy link

@Jozott00 Jozott00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mr3zee Mr3zee merged commit 68887e1 into grpc-common Sep 18, 2025
5 of 6 checks passed
@Mr3zee Mr3zee deleted the grpc-annotations branch September 18, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants