MPP: Fixed invokeOnCompletion source compatibility

Author: elizarov

core/kotlinx-coroutines-core/src/main/kotlin/kotlinx/coroutines/experimental/Job.kt

@@ -267,8 +267,9 @@ public actual interface Job : CoroutineContext.Element {
     @Deprecated(message = "For binary compatibility", level = DeprecationLevel.HIDDEN)
     public fun invokeOnCompletion(handler: CompletionHandler, onCancelling: Boolean): DisposableHandle
 
-    @Deprecated(message = "For binary compatibility", level = DeprecationLevel.HIDDEN)
-    public fun invokeOnCompletion(onCancelling: Boolean = false, handler: CompletionHandler): DisposableHandle
+    @Deprecated(message = "Use with named `onCancelling` and `handler` parameters", level = DeprecationLevel.WARNING,
+        replaceWith = ReplaceWith("this.invokeOnCompletion(onCancelling = onCancelling_, handler = handler)"))
+    public fun invokeOnCompletion(onCancelling_: Boolean = false, handler: CompletionHandler): DisposableHandle
 
     /**
      * Registers handler that is **synchronously** invoked once on completion of this job.
@@ -843,8 +844,8 @@ public open class JobSupport(active: Boolean) : Job, SelectClause0, SelectClause
         invokeOnCompletion(onCancelling = onCancelling, invokeImmediately = true, handler = handler)
 
     @Suppress("OverridingDeprecatedMember")
-    public final override fun invokeOnCompletion(onCancelling: Boolean, handler: CompletionHandler): DisposableHandle =
-        invokeOnCompletion(onCancelling = onCancelling, invokeImmediately = true, handler = handler)
+    public final override fun invokeOnCompletion(onCancelling_: Boolean, handler: CompletionHandler): DisposableHandle =
+        invokeOnCompletion(onCancelling = onCancelling_, invokeImmediately = true, handler = handler)
 
     public override fun invokeOnCompletion(
         onCancelling: Boolean,

core/kotlinx-coroutines-io/src/test/kotlin/kotlinx/coroutines/experimental/io/ByteBufferChannelTest.kt

@@ -747,9 +747,9 @@ class ByteBufferChannelTest {
             if (r.decrementAndGet() == 0) latch.countDown()
         }
 
-        reader.invokeOnCompletion(true, handler)
-        writerJob.invokeOnCompletion(true, handler)
-        joinerJob.invokeOnCompletion(true, handler)
+        reader.invokeOnCompletion(onCancelling = true, handler = handler)
+        writerJob.invokeOnCompletion(onCancelling = true, handler = handler)
+        joinerJob.invokeOnCompletion(onCancelling = true, handler = handler)
 
         latch.await()
     }