Make all API internal where it is possible

Author: qwwdfsad

benchmarks/src/jmh/kotlin/benchmarks/ForkJoinBenchmark.kt

@@ -54,7 +54,7 @@ open class ForkJoinBenchmark : ParametrizedDispatcherBase() {
 
     @Benchmark
     fun asyncFjp() = runBlocking {
-        CoroutineScope(CommonPool).startAsync(coefficients, 0, coefficients.size).await()
+        CoroutineScope(ForkJoinPool.commonPool().asCoroutineDispatcher()).startAsync(coefficients, 0, coefficients.size).await()
     }
 
     @Benchmark

benchmarks/src/jmh/kotlin/benchmarks/ParametrizedDispatcherBase.kt

@@ -11,6 +11,7 @@ import org.openjdk.jmh.annotations.Param
 import org.openjdk.jmh.annotations.Setup
 import org.openjdk.jmh.annotations.TearDown
 import java.io.Closeable
+import java.util.concurrent.*
 import kotlin.coroutines.CoroutineContext
 
 /**
@@ -26,7 +27,7 @@ abstract class ParametrizedDispatcherBase : CoroutineScope {
     @Setup
     open fun setup() {
         coroutineContext = when {
-            dispatcher == "fjp" -> CommonPool
+            dispatcher == "fjp" -> ForkJoinPool.commonPool().asCoroutineDispatcher()
             dispatcher == "experimental" -> {
                 ExperimentalCoroutineDispatcher(CORES_COUNT).also { closeable = it }
             }

benchmarks/src/jmh/kotlin/benchmarks/actors/PingPongWithBlockingContext.kt

@@ -49,7 +49,7 @@ open class PingPongWithBlockingContext {
 
     @Benchmark
     fun commonPoolWithContextPingPong() = runBlocking {
-        runPingPongs(CommonPool, threadPool)
+        runPingPongs(ForkJoinPool.commonPool().asCoroutineDispatcher(), threadPool)
     }
 
     private suspend fun runPingPongs(pingContext: CoroutineContext, pongContext: CoroutineContext) {

binary-compatibility-validator/reference-public-api/kotlinx-coroutines-android.txt

@@ -1,18 +1,3 @@
-public final class kotlinx/coroutines/android/HandlerContext : kotlinx/coroutines/android/HandlerDispatcher, kotlinx/coroutines/Delay {
-	public fun <init> (Landroid/os/Handler;Ljava/lang/String;)V
-	public synthetic fun <init> (Landroid/os/Handler;Ljava/lang/String;ILkotlin/jvm/internal/DefaultConstructorMarker;)V
-	public fun dispatch (Lkotlin/coroutines/CoroutineContext;Ljava/lang/Runnable;)V
-	public fun equals (Ljava/lang/Object;)Z
-	public synthetic fun getImmediate ()Lkotlinx/coroutines/MainCoroutineDispatcher;
-	public fun getImmediate ()Lkotlinx/coroutines/android/HandlerContext;
-	public synthetic fun getImmediate ()Lkotlinx/coroutines/android/HandlerDispatcher;
-	public fun hashCode ()I
-	public fun invokeOnTimeout (JLjava/lang/Runnable;)Lkotlinx/coroutines/DisposableHandle;
-	public fun isDispatchNeeded (Lkotlin/coroutines/CoroutineContext;)Z
-	public fun scheduleResumeAfterDelay (JLkotlinx/coroutines/CancellableContinuation;)V
-	public fun toString ()Ljava/lang/String;
-}
-
 public abstract class kotlinx/coroutines/android/HandlerDispatcher : kotlinx/coroutines/MainCoroutineDispatcher, kotlinx/coroutines/Delay {
 	public fun delay (JLkotlin/coroutines/Continuation;)Ljava/lang/Object;
 	public abstract fun getImmediate ()Lkotlinx/coroutines/android/HandlerDispatcher;

binary-compatibility-validator/reference-public-api/kotlinx-coroutines-core.txt

@@ -1,9 +1,3 @@
-public final class kotlinx/coroutines/javafx/JavaFx : kotlinx/coroutines/javafx/JavaFxDispatcher {
-	public static final field INSTANCE Lkotlinx/coroutines/javafx/JavaFx;
-	public fun getImmediate ()Lkotlinx/coroutines/MainCoroutineDispatcher;
-	public fun toString ()Ljava/lang/String;
-}
-
 public abstract class kotlinx/coroutines/javafx/JavaFxDispatcher : kotlinx/coroutines/MainCoroutineDispatcher, kotlinx/coroutines/Delay {
 	public fun delay (JLkotlin/coroutines/Continuation;)Ljava/lang/Object;
 	public fun dispatch (Lkotlin/coroutines/CoroutineContext;Ljava/lang/Runnable;)V

binary-compatibility-validator/reference-public-api/kotlinx-coroutines-javafx.txt

@@ -1,7 +1,3 @@
-public final class kotlinx/coroutines/channels8/ChannelsKt {
-	public static final fun collect (Lkotlinx/coroutines/channels/ReceiveChannel;Ljava/util/stream/Collector;Lkotlin/coroutines/Continuation;)Ljava/lang/Object;
-}
-
 public final class kotlinx/coroutines/future/FutureKt {
 	public static final fun asCompletableFuture (Lkotlinx/coroutines/Deferred;)Ljava/util/concurrent/CompletableFuture;
 	public static final fun asDeferred (Ljava/util/concurrent/CompletionStage;)Lkotlinx/coroutines/Deferred;

binary-compatibility-validator/reference-public-api/kotlinx-coroutines-jdk8.txt

@@ -1,9 +1,3 @@
-public final class kotlinx/coroutines/swing/Swing : kotlinx/coroutines/swing/SwingDispatcher {
-	public static final field INSTANCE Lkotlinx/coroutines/swing/Swing;
-	public fun getImmediate ()Lkotlinx/coroutines/MainCoroutineDispatcher;
-	public fun toString ()Ljava/lang/String;
-}
-
 public abstract class kotlinx/coroutines/swing/SwingDispatcher : kotlinx/coroutines/MainCoroutineDispatcher, kotlinx/coroutines/Delay {
 	public fun delay (JLkotlin/coroutines/Continuation;)Ljava/lang/Object;
 	public fun dispatch (Lkotlin/coroutines/CoroutineContext;Ljava/lang/Runnable;)V

binary-compatibility-validator/reference-public-api/kotlinx-coroutines-swing.txt

@@ -181,10 +181,8 @@ public suspend inline fun <T> suspendAtomicCancellableCoroutine(
 
 /**
  * Removes a given node on cancellation.
- * @suppress **This is unstable API and it is subject to change.**
  */
-@InternalCoroutinesApi
-public fun CancellableContinuation<*>.removeOnCancellation(node: LockFreeLinkedListNode) =
+internal fun CancellableContinuation<*>.removeOnCancellation(node: LockFreeLinkedListNode) =
     invokeOnCancellation(handler = RemoveOnCancel(node).asHandler)
 
 /**

common/kotlinx-coroutines-core-common/src/CancellableContinuation.kt

@@ -7,24 +7,16 @@ package kotlinx.coroutines
 import kotlinx.coroutines.internal.*
 import kotlin.coroutines.*
 
-/**
- * @suppress **This is unstable API and it is subject to change.**
- */
-public fun <T> Result<T>.toState(): Any? =
+internal fun <T> Result<T>.toState(): Any? =
     if (isSuccess) getOrThrow() else CompletedExceptionally(exceptionOrNull()!!) // todo: need to do it better
 
 /**
  * Class for an internal state of a job that was cancelled (completed exceptionally).
  *
- * **Note: This class cannot be used outside of internal coroutines framework**.
- * **Note: cannot be internal and renamed until we get rid of MutableDelegateContinuation in IO**
- *
  * @param cause the exceptional completion cause. It's either original exceptional cause
  *        or artificial [CancellationException] if no cause was provided
- * @suppress **This is unstable API and it is subject to change.**
  */
-@InternalCoroutinesApi
-open class CompletedExceptionally(
+internal open class CompletedExceptionally(
     @JvmField public val cause: Throwable
 ) {
     override fun toString(): String = "$classSimpleName[$cause]"
@@ -33,15 +25,11 @@ open class CompletedExceptionally(
 /**
  * A specific subclass of [CompletedExceptionally] for cancelled [AbstractContinuation].
  *
- * **Note: This class cannot be used outside of internal coroutines framework**.
- *
  * @param continuation the continuation that was cancelled.
  * @param cause the exceptional completion cause. If `cause` is null, then a [CancellationException]
  *        if created on first access to [exception] property.
- * @suppress **This is unstable API and it is subject to change.**
  */
-@InternalCoroutinesApi
-public class CancelledContinuation(
+internal class CancelledContinuation(
     continuation: Continuation<*>,
     cause: Throwable?
 ) : CompletedExceptionally(cause ?: CancellationException("Continuation $continuation was cancelled normally"))