More precise SharedFlow lint message (#2830)

qwwdfsad · web-flow · commit 3694ac9ef192 · 2021-07-20T19:37:46.000+03:00
diff --git a/kotlinx-coroutines-core/common/src/flow/operators/Lint.kt b/kotlinx-coroutines-core/common/src/flow/operators/Lint.kt
@@ -83,7 +83,8 @@ public val FlowCollector<*>.coroutineContext: CoroutineContext
     get() = noImpl()
 
 @Deprecated(
-    message = "SharedFlow never completes, so this operator has no effect.",
+    message = "SharedFlow never completes, so this operator typically has not effect, it can only " +
+        "catch exceptions from 'onSubscribe' operator",
     level = DeprecationLevel.WARNING,
     replaceWith = ReplaceWith("this")
 )
diff --git a/kotlinx-coroutines-core/common/test/flow/sharing/SharedFlowTest.kt b/kotlinx-coroutines-core/common/test/flow/sharing/SharedFlowTest.kt
@@ -602,6 +602,7 @@ class SharedFlowTest : TestBase() {
     }
 
     @Test
+    @Suppress("DEPRECATION") // 'catch'
     fun onSubscriptionThrows() = runTest {
         expect(1)
         val sh = MutableSharedFlow<String>(1)

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,8 @@ public val FlowCollector<*>.coroutineContext: CoroutineContext`
`83`	`83`	`get() = noImpl()`
`84`	`84`
`85`	`85`	`@Deprecated(`
`86`		`- message = "SharedFlow never completes, so this operator has no effect.",`
	`86`	`+ message = "SharedFlow never completes, so this operator typically has not effect, it can only " +`
	`87`	`+ "catch exceptions from 'onSubscribe' operator",`
`87`	`88`	`level = DeprecationLevel.WARNING,`
`88`	`89`	`replaceWith = ReplaceWith("this")`
`89`	`90`	`)`
Original file line number	Diff line number	Diff line change
`@@ -602,6 +602,7 @@ class SharedFlowTest : TestBase() {`
`602`	`602`	`}`
`603`	`603`
`604`	`604`	`@Test`
	`605`	`+ @Suppress("DEPRECATION") // 'catch'`
`605`	`606`	`fun onSubscriptionThrows() = runTest {`
`606`	`607`	`expect(1)`
`607`	`608`	`val sh = MutableSharedFlow<String>(1)`