EventLoop works until the job isCompleted (process while cancelling)

elizarov · elizarov · commit 7400ff01c116 · 2017-07-10T17:56:41.000+03:00
diff --git a/kotlinx-coroutines-core/src/main/kotlin/kotlinx/coroutines/experimental/Builders.kt b/kotlinx-coroutines-core/src/main/kotlin/kotlinx/coroutines/experimental/Builders.kt
@@ -223,7 +223,7 @@ private class BlockingCoroutine<T>(
             if (Thread.interrupted()) throw InterruptedException().also { cancel(it) }
             val parkNanos = eventLoop?.processNextEvent() ?: Long.MAX_VALUE
             // note: process next even may look unpark flag, so check !isActive before parking
-            if (!isActive) break
+            if (isCompleted) break
             LockSupport.parkNanos(this, parkNanos)
         }
         // process queued events (that could have been added after last processNextEvent and before cancel

Original file line number	Diff line number	Diff line change
`@@ -223,7 +223,7 @@ private class BlockingCoroutine<T>(`
`223`	`223`	`if (Thread.interrupted()) throw InterruptedException().also { cancel(it) }`
`224`	`224`	`val parkNanos = eventLoop?.processNextEvent() ?: Long.MAX_VALUE`
`225`	`225`	`// note: process next even may look unpark flag, so check !isActive before parking`
`226`		`- if (!isActive) break`
	`226`	`+ if (isCompleted) break`
`227`	`227`	`LockSupport.parkNanos(this, parkNanos)`
`228`	`228`	`}`
`229`	`229`	`// process queued events (that could have been added after last processNextEvent and before cancel`