Unpark event-loop thread only when it's necessary

qwwdfsad · elizarov · commit b63fd8299637 · 2018-09-28T14:30:44.000+03:00
diff --git a/core/kotlinx-coroutines-core/src/EventLoop.kt b/core/kotlinx-coroutines-core/src/EventLoop.kt
@@ -243,12 +243,14 @@ internal abstract class EventLoopBase: CoroutineDispatcher(), Delay, EventLoop {
 
     internal fun schedule(delayedTask: DelayedTask) {
         if (scheduleImpl(delayedTask)) {
-            unpark()
+            if (shouldUnpark(delayedTask)) unpark()
         } else {
             DefaultExecutor.schedule(delayedTask)
         }
     }
 
+    private fun shouldUnpark(task: DelayedTask): Boolean = _delayed.value?.peek() === task
+
     private fun scheduleImpl(delayedTask: DelayedTask): Boolean {
         if (isCompleted) return false
         val delayed = _delayed.value ?: run {

Original file line number	Diff line number	Diff line change
`@@ -243,12 +243,14 @@ internal abstract class EventLoopBase: CoroutineDispatcher(), Delay, EventLoop {`
`243`	`243`
`244`	`244`	`internal fun schedule(delayedTask: DelayedTask) {`
`245`	`245`	`if (scheduleImpl(delayedTask)) {`
`246`		`- unpark()`
	`246`	`+ if (shouldUnpark(delayedTask)) unpark()`
`247`	`247`	`} else {`
`248`	`248`	`DefaultExecutor.schedule(delayedTask)`
`249`	`249`	`}`
`250`	`250`	`}`
`251`	`251`
	`252`	`+ private fun shouldUnpark(task: DelayedTask): Boolean = _delayed.value?.peek() === task`
	`253`	`+`
`252`	`254`	`private fun scheduleImpl(delayedTask: DelayedTask): Boolean {`
`253`	`255`	`if (isCompleted) return false`
`254`	`256`	`val delayed = _delayed.value ?: run {`