Missing libs.repository.id property dependency

Improve validation that this property is passed, it is
a prerequisite for publishing to sonatype, same as sonatype username and password.
Document expected properties.

Author: ilya-g

main/resources/teamcity/settings.kts

@@ -51,6 +51,7 @@ project {
     val deploys = platforms.map { deploy(it, deployVersion) }
     val deployPublish = deployPublish(deployVersion).apply {
         dependsOnSnapshot(buildAll, onFailure = FailureAction.IGNORE)
+        dependsOnSnapshot(BUILD_CREATE_STAGING_REPO_ABSOLUTE_ID)
         deploys.forEach {
             dependsOnSnapshot(it)
         }
@@ -185,6 +186,7 @@ fun Project.deploy(platform: Platform, configureBuild: BuildType) = buildType("D
         param(releaseVersionParameter, "${configureBuild.depParamRefs[releaseVersionParameter]}")
         param("bintray-user", bintrayUserName)
         password("bintray-key", bintrayToken)
+        param("env.libs.repository.id", "%dep.$BUILD_CREATE_STAGING_REPO_ABSOLUTE_ID.env.libs.repository.id%")
     }
 
     vcs {

main/src/kotlinx/team/infra/Publishing.kt

@@ -60,6 +60,11 @@ open class PublishingConfiguration {
 
 class SonatypeConfiguration {
     // no things to configure here for now
+    // all information is provided with properties or env. variables with known names:
+    // - libs.repository.id: sonatype staging repository id, 'auto' to open staging implicitly,
+    // - libs.sonatype.user: sonatype user name
+    // - libs.sonatype.password: sonatype password
+    // - libs.sign.key.id, libs.sign.key.private, libs.sign.passphrase: publication signing information
     internal var isSelected: Boolean = false
 }
 
@@ -318,8 +323,13 @@ private fun Project.verifySonatypeConfiguration(): Boolean {
         return false
     }
 
+    if (stagingRepositoryId.isNullOrEmpty()) {
+        return missing("staging repository id 'libs.repository.id'. Pass 'auto' for implicit staging")
+    }
+
     sonatypeUsername ?: return missing("username")
     val password = sonatypePassword ?: return missing("password")
+
     if (password.startsWith("credentialsJSON")) {
         logger.warn("INFRA: API key secure token was not expanded, publishing is not possible.")
         return false
@@ -422,15 +432,21 @@ private fun Project.configureSigning() {
 
 
 private fun Project.sonatypeRepositoryUri(): URI {
-    val repositoryId: String? = System.getenv("libs.repository.id")
-    return if (repositoryId == null) {
-        // Using implicitly created staging, for MPP it's likely a mistake
-        logger.warn("INFRA: using an implicitly created staging for ${project.rootProject.name}")
-        URI("https://oss.sonatype.org/service/local/staging/deploy/maven2/")
-    } else {
-        URI("https://oss.sonatype.org/service/local/staging/deployByRepositoryId/$repositoryId")
+    val repositoryId: String? = stagingRepositoryId
+    return when {
+        repositoryId.isNullOrEmpty() ->
+            throw KotlinInfrastructureException("Staging repository id 'libs.repository.id' is not specified.")
+        repositoryId == "auto" -> {
+            // Using implicitly created staging, for MPP it's likely a mistake
+            logger.warn("INFRA: using an implicitly created staging for ${project.rootProject.name}")
+            URI("https://oss.sonatype.org/service/local/staging/deploy/maven2/")
+        }
+        else -> {
+            URI("https://oss.sonatype.org/service/local/staging/deployByRepositoryId/$repositoryId")
+        }
     }
 }
 
+private val Project.stagingRepositoryId: String? get() = propertyOrEnv("libs.repository.id")
 private val Project.sonatypeUsername: String? get() = propertyOrEnv("libs.sonatype.user")
 private val Project.sonatypePassword: String? get() = propertyOrEnv("libs.sonatype.password")