Skip to content

Commit 3094dc7

Browse files
committed
fix type errors in tests from new basedmypy version
1 parent b4881f9 commit 3094dc7

File tree

5 files changed

+13
-8
lines changed

5 files changed

+13
-8
lines changed

tests/test_never_type/test_runtime.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,15 @@ def test_isinstance() -> None:
1414

1515

1616
def test_issubform_true() -> None:
17-
assert issubform(Never, int) # type: ignore[arg-type]
17+
assert issubform(Never, int)
1818

1919

2020
def test_issubform_false() -> None:
21-
assert not issubform(str, Never) # type: ignore[arg-type]
21+
assert not issubform(str, Never)
2222

2323

2424
def test_issubform_never_is_never() -> None:
25-
assert issubform(Never, Never) # type: ignore[arg-type]
25+
assert issubform(Never, Never)
2626

2727

2828
def test_issubclass() -> None:

tests/test_reified_generics/test_issubclass.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,8 @@ def test_without_generics_first_arg_false() -> None:
3333

3434
@mark.xfail(reason="not implemented")
3535
def test_without_generics_first_arg_true() -> None:
36-
class Foo(ReifiedGeneric[T_co]):
36+
# https://github.com/KotlinIsland/basedtyping/issues/70
37+
class Foo(ReifiedGeneric[T_co]): # type:ignore[type-var]
3738
pass
3839

3940
assert not issubclass(Foo, Foo[object]) # type: ignore[misc]

tests/test_reified_generics/test_not_enough_type_params.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@ class Reified2(ReifiedGeneric[Tuple[T, U]]):
1313

1414
def test_not_enough_type_params() -> None:
1515
with raises(NotEnoughTypeParametersError):
16-
Reified2[int]() # type: ignore[no-any-expr,misc]
16+
Reified2[int]() # type: ignore[misc]

tests/test_reified_generics/test_reified_generic.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,4 +76,8 @@ class SubASpecified(A[int]):
7676

7777

7878
def test_none_type() -> None:
79-
assert Reified[None, None].__reified_generics__ == (NoneType, NoneType)
79+
# TODO: is this mypy error correct?
80+
assert Reified[None, None].__reified_generics__ == (
81+
NoneType,
82+
NoneType,
83+
) # type:ignore[comparison-overlap]

tests/test_reified_generics/test_typevars.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,12 @@ def test_isinstance(_value: T) -> None:
2323
isinstance(Reified[str](), Reified[T]) # type: ignore[misc]
2424

2525

26-
def test_unbound_instantiate() -> None:
26+
def test_unbound_instantiate(_value: T) -> None:
2727
with raises(NotReifiedError):
2828
Reified[T]()
2929

3030

31-
def test_unbound_isinstance() -> None:
31+
def test_unbound_isinstance(_value: T) -> None:
3232
with raises(NotReifiedError):
3333
isinstance(Reified[str](), Reified[T]) # type: ignore[misc]
3434

0 commit comments

Comments
 (0)