Make message cache test a bit less flaky

Author: jchristgit

test/nostrum/cache/message_cache/mnesia_additional_test.exs

@@ -151,26 +151,32 @@ defmodule Nostrum.Cache.MessageCache.MnesiaAdditionalTest do
   end
 
   describe "bulk_delete/2" do
-    test "returns the deleted messages when they are found in the cache" do
-      expected_messages = [
+    setup do
+      messages = [
         MessageCache.Mnesia.create(@test_message),
         MessageCache.Mnesia.create(%{@test_message_two | channel_id: @test_message.channel_id})
       ]
 
-      assert expected_messages ==
+      [messages: messages]
+    end
+
+    test "returns the deleted messages when they are found in the cache", %{messages: messages} do
+      assert messages ==
                MessageCache.Mnesia.bulk_delete(@test_message.channel_id, [
                  @test_message.id,
                  @test_message_two.id
                ])
     end
 
-    test "does not include messages not found in the cache in the returned list" do
-      expected_message = MessageCache.Mnesia.create(@test_message)
+    test "does not include messages not found in the cache in the returned list", %{
+      messages: messages
+    } do
+      [first, second] = messages
 
-      assert [expected_message] ==
+      assert [^first] =
                MessageCache.Mnesia.bulk_delete(@test_message.channel_id, [
-                 @test_message.id,
-                 @test_message_two.id
+                 first.id,
+                 second.id + 1234
                ])
     end
   end