Change quaternion tests to not use ub

Author: KredeGC

README.md

@@ -219,18 +219,16 @@ As well as a short example of its usage:
 ```cpp
 struct quaternion
 {
-    float w;
-    float x;
-    float y;
-    float z;
-    
-    // This needs to return the same order as the constructor
+    // smallest_three supports any combination of w, x, y and z, as long as it's consistent
+    float values[4];
+
+    // The constructor order must be the same as the operator[]
     float operator[](size_t index) const
     {
-        return reinterpret_cast<const float*>(this)[index];
+        return values[index];
     }
 };
-quaternion in_value = { 1.0f, 0.0f, 0.0f, 0.0f };
+quaternion in_value{ 1.0f, 0.0f, 0.0f, 0.0f };
 quaternion out_value;
 bool status_write = writer.serialize<smallest_three<quaternion, 12>>(in_value);
 bool status_read = reader.serialize<smallest_three<quaternion, 12>>(out_value);

src/shared/test_types.h

@@ -1,27 +1,22 @@
 #pragma once
 
+#include <bitstream/utility/assert.h>
+
 #include <cstddef>
 
 namespace bitstream::test
 {
-	struct quaternion
+    struct quaternion
 	{
 		// smallest_three supports any combination of w, x, y and z, as long as it's consistent
-		float w;
-		float x;
-		float y;
-		float z;
-
-		quaternion() = default;
+		float values[4];
 
 		// The constructor order must be the same as the operator[]
-		quaternion(float w, float x, float y, float z)
-			: w(w), x(x), y(y), z(z) {}
-
-		// smallest_three uses this operator
 		float operator[](size_t index) const
 		{
-			return reinterpret_cast<const float*>(this)[index];
+            BS_ASSERT(index >= 0 && index < 4);
+            
+            return values[index];
 		}
 	};
 }

src/test/quantization_test.cpp

@@ -40,12 +40,12 @@ namespace bitstream::test::quantization
 
 	BS_ADD_TEST(test_smallest_three)
 	{
-		quaternion quat_in(0.0f, std::sin(2.0f), std::cos(2.0f), 0.0f);
+		quaternion quat_in{ 0.0f, std::sin(2.0f), std::cos(2.0f), 0.0f };
 
 		auto quantized_quat = smallest_three<quaternion, 11>::quantize(quat_in);
 		quaternion quat_out = smallest_three<quaternion, 11>::dequantize(quantized_quat);
 
-		float dot = quat_in.x * quat_out.x + quat_in.y * quat_out.y + quat_in.z * quat_out.z + quat_in.w * quat_out.w;
+		float dot = quat_in[0] * quat_out[0] + quat_in[1] * quat_out[1] + quat_in[2] * quat_out[2] + quat_in[3] * quat_out[3];
 
 		if (dot < 0.0f)
 			dot *= -1.0f;

src/test/serialize_quantization_test.cpp

@@ -86,7 +86,7 @@ namespace bitstream::test::traits
 		using trait = smallest_three<quaternion, 11>;
 
 		// Test smallest three
-		quaternion value_in(0.0f, std::sin(2.0f), std::cos(2.0f), 0.0f);
+		quaternion value_in{ 0.0f, std::sin(2.0f), std::cos(2.0f), 0.0f };
 
 		byte_buffer<16> buffer;
 		bit_writer writer(buffer);
@@ -102,7 +102,7 @@ namespace bitstream::test::traits
 
 		BS_TEST_ASSERT(reader.serialize<trait>(value_out));
 
-		float dot = value_in.x * value_out.x + value_in.y * value_out.y + value_in.z * value_out.z + value_in.w * value_out.w;
+		float dot = value_in[0] * value_out[0] + value_in[1] * value_out[1] + value_in[2] * value_out[2] + value_in[3] * value_out[3];
 
 		if (dot < 0.0f)
 			dot *= -1.0f;