Skip to content

Commit c30e32b

Browse files
committed
Update smallest_three casts
Remove sign conversion warning
1 parent 228e002 commit c30e32b

File tree

2 files changed

+3
-29
lines changed

2 files changed

+3
-29
lines changed

include/bitstream/quantization/smallest_three.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -134,9 +134,9 @@ namespace bitstream
134134
constexpr uint32_t half_range = (1 << (BitsPerElement - 1));
135135
constexpr float unpacker = SMALLEST_THREE_UNPACK * (1.0f / half_range);
136136

137-
float a = data.a * unpacker - half_range * unpacker;
138-
float b = data.b * unpacker - half_range * unpacker;
139-
float c = data.c * unpacker - half_range * unpacker;
137+
float a = static_cast<float>(data.a * unpacker - half_range * unpacker);
138+
float b = static_cast<float>(data.b * unpacker - half_range * unpacker);
139+
float c = static_cast<float>(data.c * unpacker - half_range * unpacker);
140140

141141
float d = std::sqrt(1.0f - ((a * a) + (b * b) + (c * c)));
142142

premake5.lua

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -90,28 +90,6 @@ project "Test"
9090
conformancemode "on"
9191

9292
flags { "MultiProcessorCompile" }
93-
94-
buildoptions {
95-
"/w14242",
96-
"/w14254",
97-
"/w14263",
98-
"/w14265",
99-
"/w14287",
100-
"/w14289",
101-
"/w14296",
102-
"/w14311",
103-
"/w14545",
104-
"/w14546",
105-
"/w14547",
106-
"/w14549",
107-
"/w14555",
108-
"/w14619",
109-
"/w14640",
110-
"/w14826",
111-
"/w14905",
112-
"/w14906",
113-
"/w14928"
114-
}
11593

11694
filter "system:linux"
11795
systemversion "latest"
@@ -128,10 +106,6 @@ project "Test"
128106
"-Wunused",
129107
"-Woverloaded-virtual",
130108
"-Wpedantic",
131-
"-Wconversion",
132-
"-Wsign-conversion",
133-
"-Wdouble-promotion",
134-
"-Wformat=2",
135109
"-Wimplicit-fallthrough"
136110
}
137111

0 commit comments

Comments
 (0)