Skip to content

Commit cd697c7

Browse files
author
Kristifor
committed
Resolving security issue, due to create encoding the password for parity with a seed it was possible to decode the original pin using the seed from the in memory data. Now after the roles is reversed it's no longer possible to decode the parity pair unless the user knows the pin for the wallet for both hardware and software version.
1 parent 9a909e7 commit cd697c7

File tree

4 files changed

+7
-8
lines changed

4 files changed

+7
-8
lines changed

Pages/Create.razor

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -304,7 +304,7 @@
304304

305305
try
306306
{
307-
var passwrod = HardwareService.Encrypt(PassCode, "iV1z@$H8");
307+
var passwrod = HardwareService.Encrypt("iV1z@$H8",PassCode);
308308
var PK = HardwareService.Encrypt(Wallet.PrivateKey, PassCode);
309309

310310
switch (Communication.SoftwareType)

Pages/Index.razor

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@
6565
private IHardwareService HardwareService { get; set; }
6666
private string Port{ get; set; }
6767

68-
69-
68+
69+
7070
protected override Task OnAfterRenderAsync(bool firstRender)
7171
{
7272

@@ -84,8 +84,8 @@
8484

8585

8686
}
87-
88-
87+
88+
8989

9090
private void LoadHotWallet()
9191
{
@@ -100,8 +100,8 @@
100100

101101
private void LoadColdWallet()
102102
{
103+
Communication.SoftwareType = ConfigMode.ColdWallet;
103104
NavigationManager.NavigateTo("HardwareSelect");
104-
105105
}
106106

107107
}

Pages/LoginPanel.razor

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@
100100
return;
101101
}
102102

103-
var passwrod = HardwareService.Encrypt(Password, "iV1z@$H8");
103+
var passwrod = HardwareService.Encrypt("iV1z@$H8",Password);
104104
Communication.Pass = Password;
105105

106106
switch(Communication.SoftwareType)

Services/Implementation/Communication.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11

22
using ArduinoUploader.Hardware;
3-
using Microsoft.Extensions.Logging;
43
using Newtonsoft.Json;
54
using NFTLock.Models;
65
using SYNCWallet.Models;

0 commit comments

Comments
 (0)