Cargo clippy

Author: Kronicaler

src/driver/tasks/mixer/mix_logic.rs

@@ -246,7 +246,7 @@ pub fn mix_symph_indiv(
                     resample_in_progress = true;
                     continue;
                 }
-            };
+            }
 
             let samples_marched = mix_resampled(rs_out_buf, symph_mix, samples_written, volume);
 

src/input/adapters/cached/compressed.rs

@@ -434,7 +434,7 @@ where
                         },
                         Err(e) => {
                             debug!("Read error {:?} {:?} {:?}.", e, out, raw_len);
-                            out = Some(Err(IoError::new(IoErrorKind::Other, e)));
+                            out = Some(Err(IoError::other(e)));
                             break;
                         },
                     }
@@ -472,7 +472,7 @@ where
 
         // NOTE: use of raw_len here preserves true sample length even if
         // stream is extended to 20ms boundary.
-        out.unwrap_or_else(|| Err(IoError::new(IoErrorKind::Other, "Unclear.")))
+        out.unwrap_or_else(|| Err(IoError::other("Unclear.")))
             .map(|compressed_sz| {
                 self.audio_bytes
                     .fetch_add(raw_len * mem::size_of::<f32>(), Ordering::Release);

src/input/sources/http.rs

@@ -133,7 +133,7 @@ impl HttpRequest {
 
             let stream = Box::new(StreamReader::new(
                 resp.bytes_stream()
-                    .map_err(|e| IoError::new(IoErrorKind::Other, e)),
+                    .map_err(|e| IoError::other(e)),
             ));
 
             let input = HttpStream {

src/input/sources/ytdl.rs

@@ -167,7 +167,7 @@ impl<'a> YoutubeDl<'a> {
         let out = output
             .stdout
             .split(|&b| b == b'\n')
-            .filter(|&x| (!x.is_empty()))
+            .filter(|&x| !x.is_empty())
             .map(serde_json::from_slice)
             .collect::<Result<Vec<Output>, _>>()
             .map_err(|e| AudioStreamError::Fail(Box::new(e)))?;

src/shards.rs

@@ -10,8 +10,6 @@ use futures::channel::mpsc::{TrySendError, UnboundedSender as Sender};
 #[cfg(feature = "serenity")]
 use parking_lot::{lock_api::RwLockWriteGuard, Mutex as PMutex, RwLock as PRwLock};
 #[cfg(feature = "serenity")]
-use serde_json::json;
-#[cfg(feature = "serenity")]
 use serenity::gateway::ShardRunnerMessage;
 #[cfg(feature = "serenity")]
 use std::result::Result as StdResult;

src/tracks/ready.rs

@@ -1,10 +1,12 @@
 /// Whether this track has been made live, is being processed, or is
 /// currently uninitialised.
 #[derive(Copy, Clone, Debug, Eq, PartialEq)]
+#[derive(Default)]
 pub enum ReadyState {
     /// This track is still a lazy [`Compose`] object, and hasn't been made playable.
     ///
     /// [`Compose`]: crate::input::Compose
+    #[default]
     Uninitialised,
 
     /// The mixer is currently creating and parsing this track's bytestream.
@@ -14,8 +16,3 @@ pub enum ReadyState {
     Playable,
 }
 
-impl Default for ReadyState {
-    fn default() -> Self {
-        Self::Uninitialised
-    }
-}