[FEAT] Init Tracker Start-of-turn Effect Timers

[Craftidore]

Is your feature request related to a problem? Please describe.

Sometimes I want an effect to decrease on start-of-turn (especially if such an effect were paired with a every-turn reminder notification from #1764 )

Describe the solution you'd like

Toggle when creating an initiative-tracker effect to set the effect to decrease/trigger on turn-start or turn-end (defaulting to turn-end).

Describe alternatives you've considered

Setting the effect to last 1 less turn than the effect states, so it will be gone by the time their turn rolls around a final time. This still requires me to remember which things were decrease-at-start and which were decrease-at-end.

Additional context

• Toggle should be present even when the effect is infinite, for [FEAT] Init Tracker Effect Notifications #1764 interaction.
• There'd need to be some kind of visual indicator for which side of the turn it decreases on. Maybe a background color? I don't think the visual indicator needs to be obvious in what it is indicating, just enough so that you can tell the difference if you have a bunch of effects on something.

[rexy712]

This one is easily possible, it's just a matter of deciding how to layout the UI and a good way to indicate the setting. Color could work or an icon beside the entry perhaps.

I think I'd like to have the toggle in the effect creation UI be a button with an icon or just an icon. I just don't know what icons could indicate start and end. This avoids crowding the UI with labels and avoids issues with the length of localization strings varying. Any ideas?

Here's a mockup of the idea I have for adding some additional options. Hovering over the icons would give a tooltip. The eye would be for public/private, the infinity symbol would toggle turns/infinite duration, and the chevron would be for start/end turn. The chevron is just a placeholder as I can't think of a good icon for it right now.

[rexy712]

I've got this mostly functioning now. I'm still not sure about the way UI should be handled. The core functionality seems to be working well though.

Currently there is no indicator in the UI as to what updates at start of turn vs what updates at end of turn. So in the demo I just name the effects to clarify.

out.mp4

[Craftidore]

Hmmmm....

I'm not certain what would be best here. One idea is to expand the trash-can on hover to also show all such minutia settings to the left (which would double as toggles for them). I don't think that'd be the most intuitive thing, but at least those settings wouldn't be cluttering the already cramped UI. Another idea is to have them appear below upon hovering over any given effect, which would be more intuitive and discoverable, but feels like it would become annoying.

[rexy712]

I also want to avoid an overcluttering. I think putting the arrow icon on the left end of the effect would double as a toggle and indicator for when it updates (start vs end turn). So I think having it visible is a good thing in this case.

When we get to implementing #1765, I was considering how to include an icon for visibility. I kinda want it visible too so its clear if it's public or private, but then it might be too cluttered. I haven't started on that yet, but just trying to think ahead. I feel like the trash icon could be hidden or changed to take less space.

Another option is to have visible indicators on the left side which could be smaller since they wouldn't be interactable. Then have an edit button to show the editable toggles slide out and a button to submit changes. Not sure how I feel about that overall though. Realistically toggles wouldn't need used often but the visual cues would be, so it sounds reasonable. Adding another popout dialog would add some complexity though.