Add test for trackers being escaped in magnet link

+ minor refactor
+semver: skip

Author: Krusen

BencodeNET.Tests/Torrents/TorrentUtilTests.cs

@@ -105,6 +105,17 @@ public void CreateMagnetLink_NonEmptyTrackers_WithOptionIncludeTrackers_AreInclu
             magnet.Should().Be($"magnet:?xt=urn:btih:{infoHash}&dn={displayName}&tr={tracker1}&tr={tracker2}");
         }
 
+        [Theory]
+        [AutoMockedData("https://en.wikipedia.org/wiki/Bencode", "https%3A%2F%2Fen.wikipedia.org%2Fwiki%2FBencode")]
+        public void CreateMagnetLink_Tracker_IsEscapedWhenEscapingEnabled(string tracker, string expected, string infoHash, string displayName)
+        {
+            var trackers = new List<string> { tracker };
+
+            var magnet = TorrentUtil.CreateMagnetLink(infoHash, displayName, trackers, MagnetLinkOptions.IncludeTrackers);
+
+            magnet.Should().Be($"magnet:?xt=urn:btih:{infoHash}&dn={displayName}&tr={expected}");
+        }
+
         [Theory]
         [AutoMockedData]
         public void CreateMagnetLink_Torrent_UsesInfoHashDisplayNameAndTrackersFromTorrent(string infoHash, string displayName, IList<IList<string>> trackers)

BencodeNET/Torrents/TorrentUtil.cs

@@ -120,11 +120,13 @@ public static string CreateMagnetLink(string infoHash, string displayName, IEnum
             if (!string.IsNullOrWhiteSpace(displayName))
                 magnet += $"&dn={displayName}";
 
-            var validTrackers = trackers?.Where(x => !string.IsNullOrWhiteSpace(x)).ToList() ?? new List<string>();
+            var validEscapedTrackers =
+                trackers?.Where(x => !string.IsNullOrWhiteSpace(x)).Select(Uri.EscapeDataString).ToList() ??
+                new List<string>();
 
-            if (options.HasFlag(MagnetLinkOptions.IncludeTrackers) && validTrackers.Any())
+            if (options.HasFlag(MagnetLinkOptions.IncludeTrackers) && validEscapedTrackers.Any())
             {
-                var trackersString = string.Join("&", validTrackers.Select(x => $"tr={Uri.EscapeDataString(x)}"));
+                var trackersString = string.Join("&", validEscapedTrackers.Select(x => $"tr={x}"));
                 magnet += $"&{trackersString}";
             }