Skip to content

Commit 73bb3b1

Browse files
KrusenKrusen
committed
Rename test methods
1 parent 3ec5053 commit 73bb3b1

File tree

1 file changed

+17
-18
lines changed

1 file changed

+17
-18
lines changed

‎BencodeNET.Tests/Parsing/TorrentParserTests.cs‎

Lines changed: 17 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313

1414
namespace BencodeNET.Tests.Parsing
1515
{
16-
// TODO: Rename CanParse tests to better explain expected behavior/outcome
1716
public class TorrentParserTests
1817
{
1918
private BDictionary ValidSingleFileTorrentData { get; }
@@ -54,7 +53,7 @@ public TorrentParserTests()
5453

5554
[Theory]
5655
[AutoMockedData]
57-
public void CanParseComment(string comment)
56+
public void Comment_IsParsed(string comment)
5857
{
5958
// Arrange
6059
ParsedData = ValidSingleFileTorrentData;
@@ -70,7 +69,7 @@ public void CanParseComment(string comment)
7069

7170
[Theory]
7271
[AutoMockedData]
73-
public void CanParseCreatedBy(string createdBy)
72+
public void CreatedBy_IsParsed(string createdBy)
7473
{
7574
// Arrange
7675
ParsedData = ValidSingleFileTorrentData;
@@ -86,7 +85,7 @@ public void CanParseCreatedBy(string createdBy)
8685

8786
[Theory]
8887
[AutoMockedData]
89-
public void CanParseCreationDate()
88+
public void CreationDate_IsParsed()
9089
{
9190
// Arrange
9291
ParsedData = ValidSingleFileTorrentData;
@@ -105,7 +104,7 @@ public void CanParseCreationDate()
105104
[InlineAutoMockedData("UTF8")]
106105
[InlineAutoMockedData("utf-8")]
107106
[InlineAutoMockedData("UTF-8")]
108-
public void CanParseEncoding_UTF8(string encoding)
107+
public void Encoding_UTF8_CanBeParsed(string encoding)
109108
{
110109
// Arrange
111110
ParsedData = ValidSingleFileTorrentData;
@@ -122,7 +121,7 @@ public void CanParseEncoding_UTF8(string encoding)
122121
[Theory]
123122
[InlineAutoMockedData("ascii")]
124123
[InlineAutoMockedData("ASCII")]
125-
public void CanParseEncoding_ASCII(string encoding)
124+
public void Encoding_ASCII_CanBeParsed(string encoding)
126125
{
127126
// Arrange
128127
ParsedData = ValidSingleFileTorrentData;
@@ -141,7 +140,7 @@ public void CanParseEncoding_ASCII(string encoding)
141140
[InlineAutoMockedData("asdf")]
142141
[InlineAutoMockedData("1")]
143142
[InlineAutoMockedData("UTF 8")]
144-
public void CanParseEncoding_InvalidValueIsNull(string encoding)
143+
public void Encoding_InvalidValidAsNull(string encoding)
145144
{
146145
// Arrange
147146
ParsedData = ValidSingleFileTorrentData;
@@ -157,7 +156,7 @@ public void CanParseEncoding_InvalidValueIsNull(string encoding)
157156

158157
[Theory]
159158
[AutoMockedData]
160-
public void CanParse_Info_PieceLength(long pieceSize)
159+
public void Info_PieceLength_IsParsed(long pieceSize)
161160
{
162161
// Arrange
163162
ParsedData = ValidSingleFileTorrentData;
@@ -174,7 +173,7 @@ public void CanParse_Info_PieceLength(long pieceSize)
174173

175174
[Theory]
176175
[AutoMockedData]
177-
public void CanParse_Info_Pieces(string pieces)
176+
public void Info_Pieces_IsParsed(string pieces)
178177
{
179178
// Arrange
180179
ParsedData = ValidSingleFileTorrentData;
@@ -195,7 +194,7 @@ public void CanParse_Info_Pieces(string pieces)
195194
[InlineAutoMockedData(1, true)]
196195
[InlineAutoMockedData(42, false)]
197196
[InlineAutoMockedData(12345, false)]
198-
public void CanParse_Info_Private_ShouldBeTrueIfValueIsOne(int value, bool expectedResult)
197+
public void Info_Private_ShouldBeTrueOnlyIfValueIsOne(int value, bool expectedResult)
199198
{
200199
// Arrange
201200
ParsedData = ValidSingleFileTorrentData;
@@ -212,7 +211,7 @@ public void CanParse_Info_Private_ShouldBeTrueIfValueIsOne(int value, bool expec
212211

213212
[Theory]
214213
[AutoMockedData]
215-
public void CanParse_ExtraFields(string extraKey, string extraValue, string extraInfoKey, string extraInfoValue)
214+
public void ExtraFields_IsParsed(string extraKey, string extraValue, string extraInfoKey, string extraInfoValue)
216215
{
217216
// Arrange
218217
ParsedData = ValidSingleFileTorrentData;
@@ -230,7 +229,7 @@ public void CanParse_ExtraFields(string extraKey, string extraValue, string extr
230229

231230
[Theory]
232231
[AutoMockedData]
233-
public void CanParse_Announce(string announceUrl)
232+
public void Announce_IsParsed(string announceUrl)
234233
{
235234
// Arrange
236235
ParsedData = ValidSingleFileTorrentData;
@@ -248,7 +247,7 @@ public void CanParse_Announce(string announceUrl)
248247

249248
[Theory]
250249
[AutoMockedData]
251-
public void CanParse_AnnounceList_Single(IList<string> announceList)
250+
public void AnnounceList_Single_IsParsed(IList<string> announceList)
252251
{
253252
// Arrange
254253
ParsedData = ValidSingleFileTorrentData;
@@ -269,7 +268,7 @@ public void CanParse_AnnounceList_Single(IList<string> announceList)
269268

270269
[Theory]
271270
[AutoMockedData]
272-
public void CanParse_AnnounceList_Multiple(IList<string> announceList1, IList<string> announceList2)
271+
public void AnnounceList_Multiple_IsParsed(IList<string> announceList1, IList<string> announceList2)
273272
{
274273
// Arrange
275274
ParsedData = ValidSingleFileTorrentData;
@@ -293,7 +292,7 @@ public void CanParse_AnnounceList_Multiple(IList<string> announceList1, IList<st
293292

294293
[Theory]
295294
[AutoMockedData]
296-
public void CanParse_AnnounceAndAnnounceList(string announceUrl, IList<string> announceList1, IList<string> announceList2)
295+
public void AnnounceAndAnnounceList_IsParsed(string announceUrl, IList<string> announceList1, IList<string> announceList2)
297296
{
298297
// Arrange
299298
ParsedData = ValidSingleFileTorrentData;
@@ -321,7 +320,7 @@ public void CanParse_AnnounceAndAnnounceList(string announceUrl, IList<string> a
321320

322321
[Theory]
323322
[AutoMockedData]
324-
public void CanParse_AnnounceAndAnnounceList_DoesNotContainDuplicatesInPrimary(string announceUrl1, string announceUrl2)
323+
public void AnnounceAndAnnounceList_DoesNotContainDuplicatesInPrimaryList(string announceUrl1, string announceUrl2)
325324
{
326325
// Arrange
327326
ParsedData = ValidSingleFileTorrentData;
@@ -343,7 +342,7 @@ public void CanParse_AnnounceAndAnnounceList_DoesNotContainDuplicatesInPrimary(s
343342

344343
[Theory]
345344
[AutoMockedData]
346-
public void CanParse_SingleFileInfo(long length, string fileName, string md5Sum)
345+
public void SingleFileInfo_IsParsed(long length, string fileName, string md5Sum)
347346
{
348347
// Arrange
349348
ParsedData = ValidSingleFileTorrentData;
@@ -368,7 +367,7 @@ public void CanParse_SingleFileInfo(long length, string fileName, string md5Sum)
368367

369368
[Theory]
370369
[AutoMockedData]
371-
public void CanParse_MultiFileInfo(string directoryName, long length1, IList<string> paths1, string md5Sum1, long length2, IList<string> paths2, string md5Sum2)
370+
public void MultiFileInfo_IsParsed(string directoryName, long length1, IList<string> paths1, string md5Sum1, long length2, IList<string> paths2, string md5Sum2)
372371
{
373372
// Arrange
374373
ParsedData = ValidMultiFileTorrentData;

0 commit comments

Comments
 (0)