Skip to content

Can you upgrade this package so that it uses styled-components ^5.3.1 and also React 17? (would be better if you add them as peer dependencies) #1

@tonix-tuft

Description

@tonix-tuft

Hi @KrustyC!

Thank you for this component, it looks really pretty!

We have some problems using it now that styled-components is at its ^5.0.0 major version, whereas your component depends on version 3. Also, you depend on React 16, but now React 17 has been established from a long time.

Could you upgrade these dependencies in your package.json? It would be better if you add styled-components as well as react and react-dom to the peerDependencies of package.json instead of dependencies, like so:

// package.json
{
   ...
   "peerDependencies": {
        "react": "^15.0.0 || ^16.0.0 || ^17.0.0",
        "react-dom": "^15.0.0 || ^16.0.0 || ^17.0.0",
        "styled-components": "^3.0.0 || ^4.0.0 || ^5.0.0"
   },
   "dependencies": {
       ...
   },
   ...
}

Otherwise we have conflicts with other dependencies on styled-components cause they all now use version "^5.3.1" and yours still uses version ^3.3.3.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions