Skip to content

Commit 41cdb9a

Browse files
giduacgiduac
authored
2487-V100-PaletteBase.PalettePaint-event-is-not-synchronized (#2488)
* 2487-V100-PaletteBase.PalettePaint-event-is-not-synchronized - Add PalettePaintInternal to PaletteBase - Change components/classes that subscribe to PaletteBase.PalettePaint to use PaletteBase.PalettePaintInternal - And the changelog. * 2487-V100-PaletteBase.PalettePaint-event-is-not-synchronized - Add PalettePaintInternal to PaletteBase - Change components/classes that subscribe to PaletteBase.PalettePaint to use PaletteBase.PalettePaintInternal - And the changelog.
1 parent f8eb623 commit 41cdb9a

19 files changed

+67
-57
lines changed

‎Documents/Changelog/Changelog.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
====
44

55
## 2025-11-xx - Build 2511 (V10 - alpha) - November 2025
6+
* Resolved [#2487](https://github.com/Krypton-Suite/Standard-Toolkit/issues/2487), `PaletteBase.PalettePaint` event is not synchronized toward the user.
67
* Implemented [#2446](https://github.com/Krypton-Suite/Standard-Toolkit/issues/2446), Add `build.yml` to `.github/workflows`.
78
* Implemented [#1376](https://github.com/Krypton-Suite/Standard-Toolkit/issues/1376), **[Breaking Change]** `KryptonTaskDialog` has had a full overhaul. Please refer to the ticket for full details, status and code sample to get started.
89
* Implemented [#648](https://github.com/Krypton-Suite/Standard-Toolkit/issues/648), SystemMenu to be theme related

‎Source/Krypton Components/Krypton.Toolkit/Controls Toolkit/KryptonCustomPaletteBase.cs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ public KryptonCustomPaletteBase()
101101

102102
// Hook to palette events
103103
ToolMenuStatus = new KryptonPaletteTMS(this, _basePalette.ColorTable, OnMenuToolStatusPaint);
104-
_basePalette.PalettePaint += OnPalettePaint;
104+
_basePalette.PalettePaintInternal += OnPalettePaint;
105105
_basePalette.ButtonSpecChanged += OnButtonSpecChanged;
106106
_basePalette.BasePaletteChanged += OnBasePaletteChanged;
107107
_basePalette.BaseRendererChanged += OnBaseRendererChanged;
@@ -136,7 +136,7 @@ protected override void Dispose(bool disposing)
136136
// Must unhook from the palette paint event
137137
if (_basePalette is not null)
138138
{
139-
_basePalette.PalettePaint -= OnPalettePaint;
139+
_basePalette.PalettePaintInternal -= OnPalettePaint;
140140
_basePalette.ButtonSpecChanged -= OnButtonSpecChanged;
141141
_basePalette.BasePaletteChanged -= OnBasePaletteChanged;
142142
_basePalette.BaseRendererChanged -= OnBaseRendererChanged;
@@ -5736,7 +5736,7 @@ private void SetPalette(PaletteBase basePalette)
57365736
// Unhook from current palette events
57375737
if (_basePalette is not null)
57385738
{
5739-
_basePalette.PalettePaint -= OnPalettePaint;
5739+
_basePalette.PalettePaintInternal -= OnPalettePaint;
57405740
_basePalette.ButtonSpecChanged -= OnButtonSpecChanged;
57415741
_basePalette.BasePaletteChanged -= OnBasePaletteChanged;
57425742
_basePalette.BaseRendererChanged -= OnBaseRendererChanged;
@@ -5754,7 +5754,7 @@ private void SetPalette(PaletteBase basePalette)
57545754
// Hook to new palette events
57555755
if (_basePalette != null)
57565756
{
5757-
_basePalette.PalettePaint += OnPalettePaint;
5757+
_basePalette.PalettePaintInternal += OnPalettePaint;
57585758
_basePalette.ButtonSpecChanged += OnButtonSpecChanged;
57595759
_basePalette.BasePaletteChanged += OnBasePaletteChanged;
57605760
_basePalette.BaseRendererChanged += OnBaseRendererChanged;

‎Source/Krypton Components/Krypton.Toolkit/Controls Toolkit/KryptonDataGridView.cs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ protected override void Dispose(bool disposing)
217217
// Must unhook from the palette paint event
218218
if (_palette != null)
219219
{
220-
_palette.PalettePaint -= OnNeedResyncPaint;
220+
_palette.PalettePaintInternal -= OnNeedResyncPaint;
221221
_palette.ButtonSpecChanged -= OnButtonSpecChanged;
222222
}
223223

@@ -2805,7 +2805,7 @@ private void SetPalette(PaletteBase? palette)
28052805
// Unhook from current palette events
28062806
if (_palette != null)
28072807
{
2808-
_palette.PalettePaint -= OnNeedResyncPaint;
2808+
_palette.PalettePaintInternal -= OnNeedResyncPaint;
28092809
_palette.ButtonSpecChanged -= OnButtonSpecChanged;
28102810
}
28112811

@@ -2818,7 +2818,7 @@ private void SetPalette(PaletteBase? palette)
28182818
// Hook to new palette events
28192819
if (_palette != null)
28202820
{
2821-
_palette.PalettePaint += OnNeedResyncPaint;
2821+
_palette.PalettePaintInternal += OnNeedResyncPaint;
28222822
_palette.ButtonSpecChanged += OnButtonSpecChanged;
28232823
}
28242824

‎Source/Krypton Components/Krypton.Toolkit/Controls Toolkit/KryptonLinkWrapLabel.cs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ protected override void Dispose(bool disposing)
9797
// Must unhook from the palette paint event
9898
if (_palette != null)
9999
{
100-
_palette.PalettePaint -= OnPaletteNeedPaint;
100+
_palette.PalettePaintInternal -= OnPaletteNeedPaint;
101101
_palette.BasePaletteChanged -= OnBaseChanged;
102102
_palette.BaseRendererChanged -= OnBaseChanged;
103103
}
@@ -794,7 +794,7 @@ private void SetPalette(PaletteBase? palette)
794794
// Unhook from current palette events
795795
if (_palette != null)
796796
{
797-
_palette.PalettePaint -= OnPaletteNeedPaint;
797+
_palette.PalettePaintInternal -= OnPaletteNeedPaint;
798798
_palette.BasePaletteChanged -= OnBaseChanged;
799799
_palette.BaseRendererChanged -= OnBaseChanged;
800800
}
@@ -808,7 +808,7 @@ private void SetPalette(PaletteBase? palette)
808808
// Hook to new palette events
809809
if (_palette != null)
810810
{
811-
_palette.PalettePaint += OnPaletteNeedPaint;
811+
_palette.PalettePaintInternal += OnPaletteNeedPaint;
812812
_palette.BasePaletteChanged += OnBaseChanged;
813813
_palette.BaseRendererChanged += OnBaseChanged;
814814
}

‎Source/Krypton Components/Krypton.Toolkit/Controls Toolkit/KryptonManager.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1072,7 +1072,7 @@ private static void SetPalette(PaletteBase globalPalette)
10721072
// Unhook from current palette events
10731073
if (CurrentGlobalPalette != null)
10741074
{
1075-
CurrentGlobalPalette.PalettePaint -= OnPalettePaint;
1075+
CurrentGlobalPalette.PalettePaintInternal -= OnPalettePaint;
10761076
}
10771077

10781078
// Remember the new palette
@@ -1081,7 +1081,7 @@ private static void SetPalette(PaletteBase globalPalette)
10811081
// Hook to new palette events
10821082
if (CurrentGlobalPalette != null)
10831083
{
1084-
CurrentGlobalPalette.PalettePaint += OnPalettePaint;
1084+
CurrentGlobalPalette.PalettePaintInternal += OnPalettePaint;
10851085
}
10861086
}
10871087
}

‎Source/Krypton Components/Krypton.Toolkit/Controls Toolkit/KryptonProgressBar.cs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ public KryptonProgressBar()
9191
// Hook into palette events
9292
if (_palette != null)
9393
{
94-
_palette.PalettePaint += OnPalettePaint;
94+
_palette.PalettePaintInternal += OnPalettePaint;
9595
}
9696

9797
// Create content storage
@@ -165,7 +165,7 @@ protected override void Dispose(bool disposing)
165165
// Unhook from the palette events
166166
if (_palette != null)
167167
{
168-
_palette.PalettePaint -= OnPalettePaint;
168+
_palette.PalettePaintInternal -= OnPalettePaint;
169169
_palette = null;
170170
}
171171

@@ -1080,7 +1080,7 @@ private void OnGlobalPaletteChanged(object? sender, EventArgs e)
10801080
// Unhook events from old palette
10811081
if (_palette != null)
10821082
{
1083-
_palette.PalettePaint -= OnPalettePaint;
1083+
_palette.PalettePaintInternal -= OnPalettePaint;
10841084
}
10851085

10861086
// Cache the new PaletteBase that is the global palette
@@ -1090,7 +1090,7 @@ private void OnGlobalPaletteChanged(object? sender, EventArgs e)
10901090
// Hook into events for the new palette
10911091
if (_palette != null)
10921092
{
1093-
_palette.PalettePaint += OnPalettePaint;
1093+
_palette.PalettePaintInternal += OnPalettePaint;
10941094
}
10951095

10961096
// Change of palette means we should repaint to show any changes

‎Source/Krypton Components/Krypton.Toolkit/Controls Toolkit/KryptonScrollBar.cs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ public KryptonScrollBar()
148148

149149
if (_palette != null)
150150
{
151-
_palette.PalettePaint += OnPalettePaint;
151+
_palette.PalettePaintInternal += OnPalettePaint;
152152
}
153153

154154
KryptonManager.GlobalPaletteChanged += OnGlobalPaletteChanged;
@@ -1450,7 +1450,7 @@ private void OnGlobalPaletteChanged(object? sender, EventArgs e)
14501450
{
14511451
if (_palette != null)
14521452
{
1453-
_palette.PalettePaint -= OnPalettePaint;
1453+
_palette.PalettePaintInternal -= OnPalettePaint;
14541454
}
14551455

14561456
_palette = KryptonManager.CurrentGlobalPalette;
@@ -1459,7 +1459,7 @@ private void OnGlobalPaletteChanged(object? sender, EventArgs e)
14591459

14601460
if (_palette != null)
14611461
{
1462-
_palette.PalettePaint += OnPalettePaint;
1462+
_palette.PalettePaintInternal += OnPalettePaint;
14631463

14641464
// Repaint
14651465
KryptonScrollBarRenderer.InitColors();

‎Source/Krypton Components/Krypton.Toolkit/Controls Toolkit/KryptonToggleSwitch.cs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -401,7 +401,7 @@ protected override void Dispose(bool disposing)
401401

402402
if (_palette != null)
403403
{
404-
_palette.PalettePaint -= OnPalettePaint;
404+
_palette.PalettePaintInternal -= OnPalettePaint;
405405

406406
_palette = null;
407407
}
@@ -689,7 +689,7 @@ private void OnGlobalPaletteChanged(object? sender, EventArgs e)
689689
// Unhook events from old palette
690690
if (_palette != null)
691691
{
692-
_palette.PalettePaint -= OnPalettePaint;
692+
_palette.PalettePaintInternal -= OnPalettePaint;
693693
}
694694

695695
// Cache the new PaletteBase that is the global palette
@@ -699,7 +699,7 @@ private void OnGlobalPaletteChanged(object? sender, EventArgs e)
699699
// Hook into events for the new palette
700700
if (_palette != null)
701701
{
702-
_palette.PalettePaint += OnPalettePaint;
702+
_palette.PalettePaintInternal += OnPalettePaint;
703703
}
704704

705705
// Change of palette means we should repaint to show any changes

‎Source/Krypton Components/Krypton.Toolkit/Controls Toolkit/KryptonWrapLabel.cs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ protected override void Dispose(bool disposing)
9999
// Must unhook from the palette paint event
100100
if (_palette != null)
101101
{
102-
_palette.PalettePaint -= OnPaletteNeedPaint;
102+
_palette.PalettePaintInternal -= OnPaletteNeedPaint;
103103
_palette.BasePaletteChanged -= OnBaseChanged;
104104
_palette.BaseRendererChanged -= OnBaseChanged;
105105
}
@@ -800,7 +800,7 @@ private void SetPalette(PaletteBase? palette)
800800
// Unhook from current palette events
801801
if (_palette is not null)
802802
{
803-
_palette.PalettePaint -= OnPaletteNeedPaint;
803+
_palette.PalettePaintInternal -= OnPaletteNeedPaint;
804804
_palette.BasePaletteChanged -= OnBaseChanged;
805805
_palette.BaseRendererChanged -= OnBaseChanged;
806806
}
@@ -814,7 +814,7 @@ private void SetPalette(PaletteBase? palette)
814814
// Hook to new palette events
815815
if (_palette is not null)
816816
{
817-
_palette.PalettePaint += OnPaletteNeedPaint;
817+
_palette.PalettePaintInternal += OnPaletteNeedPaint;
818818
_palette.BasePaletteChanged += OnBaseChanged;
819819
_palette.BaseRendererChanged += OnBaseChanged;
820820
}

‎Source/Krypton Components/Krypton.Toolkit/Controls Visuals/VisualContainerControlBase.cs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ protected override void Dispose(bool disposing)
138138
// Must unhook from the palette paint event
139139
if (_palette != null)
140140
{
141-
_palette.PalettePaint -= OnPaletteNeedPaint;
141+
_palette.PalettePaintInternal -= OnPaletteNeedPaint;
142142
_palette.ButtonSpecChanged -= OnButtonSpecChanged;
143143
_palette.BasePaletteChanged -= OnBaseChanged;
144144
_palette.BaseRendererChanged -= OnBaseChanged;
@@ -1089,7 +1089,7 @@ private void SetPalette(PaletteBase? palette)
10891089
// Unhook from current palette events
10901090
if (_palette != null)
10911091
{
1092-
_palette.PalettePaint -= OnPaletteNeedPaint;
1092+
_palette.PalettePaintInternal -= OnPaletteNeedPaint;
10931093
_palette.ButtonSpecChanged -= OnButtonSpecChanged;
10941094
_palette.BasePaletteChanged -= OnBaseChanged;
10951095
_palette.BaseRendererChanged -= OnBaseChanged;
@@ -1104,7 +1104,7 @@ private void SetPalette(PaletteBase? palette)
11041104
// Hook to new palette events
11051105
if (_palette != null)
11061106
{
1107-
_palette.PalettePaint += OnPaletteNeedPaint;
1107+
_palette.PalettePaintInternal += OnPaletteNeedPaint;
11081108
_palette.ButtonSpecChanged += OnButtonSpecChanged;
11091109
_palette.BasePaletteChanged += OnBaseChanged;
11101110
_palette.BaseRendererChanged += OnBaseChanged;

0 commit comments

Comments
 (0)