Merge branch 'alpha' into 2898-feature-request-kryptonhscrollbar-kryptonvscrollbar---part-of-2658

Author: PWagner1

Documents/Changelog/Changelog.md

@@ -5,6 +5,7 @@
 ## 2026-11-xx - Build 2611 (V110 Nightly) - November 2026
 
 * Implemented [#2898](https://github.com/Krypton-Suite/Standard-Toolkit/issues/2898), `KryptonHScrollBar` & `KryptonVScrollBar` - Part of #2658
+* Resolved [#2910](https://github.com/Krypton-Suite/Standard-Toolkit/issues/2910), `KryptonComboBox` override Font property causes form designer error
 * Implemented [#2895](https://github.com/Krypton-Suite/Standard-Toolkit/issues/2895), `KryptonProgressBar` - Three Colour States
 * Resolved/Implemented [#2844](https://github.com/Krypton-Suite/Standard-Toolkit/issues/2844), Touchscreen High DPI scaling
 * Implemented [#2808](https://github.com/Krypton-Suite/Standard-Toolkit/issues/2808), Move `KryptonToastNotification` feature to `Krypton.Utilities`

Source/Krypton Components/Krypton.Toolkit/ButtonSpec/ButtonSpecManagerBase.cs

@@ -857,7 +857,7 @@ private ViewDockStyle GetDockStyle(ButtonSpec spec)
     {
         var edge = spec.GetEdge(_redirector);
 
-        var isRtl = Control is Form form && form.RightToLeft == RightToLeft.Yes && form.RightToLeftLayout;
+        var isRtl = CommonHelper.IsRightToLeftLayout(Control);
 
         // In RTL mode with RightToLeftLayout enabled, reverse the dock style
         return isRtl ? edge == RelativeEdgeAlign.Near ? ViewDockStyle.Right : ViewDockStyle.Left :

Source/Krypton Components/Krypton.Toolkit/Controls Toolkit/KryptonComboBox.cs

@@ -1503,9 +1503,15 @@ public override Color BackColor
     [AllowNull]
     public override Font Font
     {
-        get => base.Font;
+        get => GetStateCommonFont() ?? base.Font;
 
-        set => base.Font = value!;
+        set
+        {
+            // Always set base.Font to ensure consistency
+            base.Font = value!;
+            // Also try to set StateCommon font, but don't fail if it's not available
+            SetStateCommonFont(value);
+        }
     }
 
     /// <summary>
@@ -2477,6 +2483,53 @@ protected virtual void OnHoverSelectionChanged(HoveredSelectionChangedEventArgs
     /// </summary>
     /// <param name="e"></param>
     protected virtual void OnToolTipNeeded(ToolTipNeededEventArgs e) => ToolTipNeeded?.Invoke(this, e);
+
+    /// <summary>
+    /// Gets the font from StateCommon.ComboBox.Content.Font safely, handling design mode serialization issues.
+    /// </summary>
+    /// <returns>The font from StateCommon, or null if not available or during problematic design time access.</returns>
+    protected virtual Font? GetStateCommonFont()
+    {
+        try
+        {
+            // Use null-conditional operators to safely access nested properties
+            // This prevents issues during design time serialization when StateCommon might not be fully initialized
+            return StateCommon.ComboBox.Content?.Font;
+        }
+        catch
+        {
+            // If StateCommon is not fully initialized or there's a serialization issue,
+            // return null to fall back to base.Font
+            return null;
+        }
+    }
+
+    /// <summary>
+    /// Sets the font to StateCommon.ComboBox.Content.Font safely, handling design mode serialization issues.
+    /// </summary>
+    /// <param name="value">The font value to set.</param>
+    /// <returns>True if the font was set to StateCommon, false to fall back to base.Font.</returns>
+    protected virtual bool SetStateCommonFont(Font? value)
+    {
+        try
+        {
+            // Use null-conditional operators to safely access nested properties
+            // This prevents issues during design time serialization when StateCommon might not be fully initialized
+            if (StateCommon.ComboBox?.Content != null)
+            {
+                StateCommon.ComboBox.Content.Font = value;
+
+                return true;
+            }
+        }
+        catch
+        {
+            // If StateCommon is not fully initialized or there's a serialization issue,
+            // return false to fall back to base.Font
+        }
+
+        return false;
+    }
     // ReSharper restore VirtualMemberNeverOverridden.Global
     #endregion
 

Source/Krypton Components/Krypton.Toolkit/Controls Toolkit/KryptonMonthCalendar.cs

@@ -290,6 +290,7 @@ public override AutoSizeMode AutoSizeMode
         set => base.AutoSizeMode = value;
     }
 
+
     /// <summary>
     /// Gets or sets the Input Method Editor (IME) mode of the control.
     /// </summary>
@@ -1479,6 +1480,7 @@ protected override void OnLostFocus(EventArgs e)
         base.OnLostFocus(e);
     }
 
+
     /// <summary>
     /// Raises the Paint event.
     /// </summary>

Source/Krypton Components/Krypton.Toolkit/Controls Visuals/VisualSimpleBase.cs

@@ -19,12 +19,19 @@ namespace Krypton.Toolkit;
 [DesignerCategory(@"code")]
 public abstract class VisualSimpleBase : VisualControlBase
 {
+    #region Instance Fields
+
+    private bool _isRightToLeftLayout;
+
+    #endregion
+
     #region Identity
     /// <summary>
     /// Initialize a new instance of the VisualSimpleBase class.
     /// </summary>
     protected VisualSimpleBase()
     {
+        _isRightToLeftLayout = false;
     }
     #endregion
 
@@ -172,5 +179,76 @@ public override Color ForeColor
         get => base.ForeColor;
         set => base.ForeColor = value;
     }
+
+    /// <summary>
+    /// Gets or sets a value indicating whether control's elements are aligned to support locales using right-to-left fonts.
+    /// </summary>
+    [Category(@"Appearance")]
+    [Localizable(true)]
+    [Description(@"Indicates whether the control should support RightToLeft layouts.")]
+    [DefaultValue(typeof(RightToLeft), "No")]
+    public override RightToLeft RightToLeft
+    {
+        get => base.RightToLeft;
+        set
+        {
+            if (base.RightToLeft != value)
+            {
+                base.RightToLeft = value;
+                PerformNeedPaint(true);
+            }
+        }
+    }
+
+    /// <summary>
+    /// Gets or sets a value indicating whether the layout of the control is from right to left.
+    /// </summary>
+    [Category(@"Appearance")]
+    [Localizable(true)]
+    [Description(@"Indicates whether the layout of the control is from right to left.")]
+    [DefaultValue(false)]
+    [Browsable(true)]
+    [EditorBrowsable(EditorBrowsableState.Always)]
+    [DesignerSerializationVisibility(DesignerSerializationVisibility.Visible)]
+    public bool RightToLeftLayout
+    {
+        get => _isRightToLeftLayout;
+        set
+        {
+            if (_isRightToLeftLayout != value)
+            {
+                _isRightToLeftLayout = value;
+                OnRightToLeftLayoutChanged(EventArgs.Empty);
+                PerformNeedPaint(true);
+            }
+        }
+    }
+    #endregion
+
+    #region Protected Overrides
+    /// <summary>
+    /// Raises the RightToLeftChanged event.
+    /// </summary>
+    /// <param name="e">An EventArgs containing event data.</param>
+    protected override void OnRightToLeftChanged(EventArgs e)
+    {
+        // Need re-layout to reflect change of layout direction
+        PerformNeedPaint(true);
+
+        base.OnRightToLeftChanged(e);
+    }
+
+    /// <summary>
+    /// Raises the RightToLeftLayoutChanged event.
+    /// </summary>
+    /// <param name="e">An EventArgs containing event data.</param>
+    /// <remarks>
+    /// This method is provided for controls that don't have OnRightToLeftLayoutChanged in their base class.
+    /// Derived classes can override this to provide custom handling when RightToLeftLayout changes.
+    /// </remarks>
+    protected virtual void OnRightToLeftLayoutChanged(EventArgs e) =>
+        // Need re-layout to reflect change of layout direction
+        PerformNeedPaint(true);
+
     #endregion
 }

Source/Krypton Components/Krypton.Toolkit/General/CommonHelper.cs

@@ -421,29 +421,70 @@ public static Padding OrientatePadding(VisualOrientation orientation,
     public static void SwapRectangleSizes(ref Rectangle rect) => (rect.Width, rect.Height) = (rect.Height, rect.Width);
 
     /// <summary>
-    /// Gets the form level right to left setting.
+    /// Gets the right to left layout setting for a control.
     /// </summary>
     /// <param name="control">Control for which the setting is needed.</param>
-    /// <returns>RightToLeft setting.</returns>
+    /// <returns>RightToLeftLayout setting.</returns>
     public static bool GetRightToLeftLayout(Control control)
     {
-        // Default to left-to-right layout
-        var rtl = false;
-
-        // We need a valid control to find a top level form
-        // Search for a top level form associated with the control
-        Form? topForm = control.FindForm();
+        // First check if the control itself has RightToLeftLayout (e.g., VisualSimpleBase controls)
+        if (control is VisualSimpleBase visualSimpleBase)
+        {
+            return visualSimpleBase.RightToLeftLayout;
+        }
 
-        // If can find an owning form
-        if (topForm != null)
+        // For other controls that might have RightToLeftLayout (like Form, ListView, etc.)
+        // Use reflection to check if the property exists and get its value
+        var property = control.GetType().GetProperty("RightToLeftLayout");
+        if (property != null && property.PropertyType == typeof(bool))
         {
-            // Use the form setting instead
-            rtl = topForm.RightToLeftLayout;
+            if (property.GetValue(control) is bool value)
+            {
+                return value;
+            }
         }
 
-        return rtl;
+        // Default to left-to-right layout
+        return false;
     }
 
+    /// <summary>
+    /// Determines if RTL layout should be applied for the given control.
+    /// </summary>
+    /// <param name="control">Control for which RTL is checked.</param>
+    /// <returns>True if RTL layout should be applied; otherwise false.</returns>
+    public static bool IsRightToLeftLayout(Control control) => GetRightToLeftLayout(control) && (control.RightToLeft == RightToLeft.Yes);
+
+    /// <summary>
+    /// Calculates the X position from the right edge for RTL-aware positioning.
+    /// </summary>
+    /// <param name="containerWidth">Width of the container.</param>
+    /// <param name="itemWidth">Width of the item to position.</param>
+    /// <param name="offset">Offset from the edge.</param>
+    /// <param name="isRtl">True if RTL layout is active.</param>
+    /// <returns>X position for the item.</returns>
+    public static int GetRtlAwareXPosition(int containerWidth, int itemWidth, int offset, bool isRtl) =>
+        isRtl
+            ? containerWidth - itemWidth - offset  // Position from right
+            : offset; // Position from left
+
+    /// <summary>
+    /// Calculates the X position increment for RTL-aware layout (positive or negative step).
+    /// </summary>
+    /// <param name="step">Step size to increment by.</param>
+    /// <param name="isRtl">True if RTL layout is active.</param>
+    /// <returns>Step value (negative for RTL, positive for LTR).</returns>
+    public static int GetRtlAwareStep(int step, bool isRtl) => isRtl ? -step : step;
+
+    /// <summary>
+    /// Gets the reverse index for accessing items in reverse order for RTL.
+    /// </summary>
+    /// <param name="index">Original index (0-based).</param>
+    /// <param name="totalCount">Total number of items.</param>
+    /// <param name="isRtl">True if RTL layout is active.</param>
+    /// <returns>Index to use for accessing the item (reversed if RTL).</returns>
+    public static int GetRtlAwareIndex(int index, int totalCount, bool isRtl) => isRtl ? (totalCount - 1 - index) : index;
+
     /// <summary>
     /// Decide if the context menu strip should be Displayed.
     /// </summary>

Source/Krypton Components/Krypton.Toolkit/View Draw/ViewDrawMonth.cs

@@ -85,6 +85,7 @@ public ViewDrawMonth(IKryptonMonthCalendar calendar,
         Add(_drawHeader);
 
         // Create the left/right arrows for moving the months
+        // Note: ButtonSpecManagerBase.GetDockStyle() handles RTL swapping automatically
         _arrowPrev = new ButtonSpecCalendar(this, PaletteButtonSpecStyle.Previous, RelativeEdgeAlign.Near);
         _arrowNext = new ButtonSpecCalendar(this, PaletteButtonSpecStyle.Next, RelativeEdgeAlign.Far);
         _arrowPrev.Click += OnPrevMonth;
@@ -124,14 +125,16 @@ public ViewDrawMonth(IKryptonMonthCalendar calendar,
         _borderEdge = new PaletteBorderEdge(_borderEdgeRedirect, null);
         _drawBorderEdge = new ViewDrawBorderEdge(_borderEdge, Orientation.Vertical);
         _drawWeekNumbers = new ViewDrawWeekNumbers(_calendar, _months);
-        var borderLeftDock = new ViewLayoutDocker
+
+        // Create a docker for week numbers - use ViewLayoutDocker which automatically handles RTL via CalculateDock
+        var borderWeekDock = new ViewLayoutDocker
         {
             { _drawWeekNumbers, ViewDockStyle.Left },
             { new ViewLayoutSeparator(0, 4), ViewDockStyle.Top },
             { _drawBorderEdge, ViewDockStyle.Fill },
             { new ViewLayoutSeparator(0, 4), ViewDockStyle.Bottom }
         };
-        _numberStack.Add(borderLeftDock);
+        _numberStack.Add(borderWeekDock);
 
         // Add border between day names and individual days
         var borderEdgeRedirect = new PaletteBorderEdgeRedirect(_calendar.StateNormal.Header.Border, null);