Style difference with nested list and normal list

[mengluwang121]

Hi,

Thanks for providing this awesome code to make Markdown in WPF much easier!
I am from VisualStudio setup team and we using this package for Markdown support. We are having some rendering issues about nested list that hope can get your help. As you can see from the below image, the space/new line rendering of nested list is different from normal list, looks like the extra "\r\n" we added are ignored. We tried different way to workaround this issue, one way is to add " \r\n" as a new line. But it is slightly different. So I am wondering do you have some other suggestions here?

The render of github markdown: it keeps the new line

1. Save your work before continuing. We need to close the following process:

   • Microsoft Visual Studio master (devenv)

   Select Continue to save its current state, close it, and restart it if it is a non-elevated process when the installation is done.

2. Your machine is busy installing a program other than Visual Studio.

   Select Continue to install Visual Studio while the other install is running. This might cause problems with other parts of the installation.

   Select Retry to continue with the Visual Studio install once the other install has completed.

   Select Cancel to cancel the Visual Studio install.

[Kryptos-FR]

I believe this is because we don't have a vertical margin by default on paragraphs and GitHub must be applying CSS styles afterwards.

Looking at the expected output using Babelmark, we can see that no additional lines are added. This is confirmed by looking at the HTML source for this page where a style is applied on <p> with margin-bottom: 16px;.

So we can try to apply the same in the styles. Saying that there is currently to style key for the default paragraph, so I will add that. Then we will be able to define custom styles for paragraph such as:

<Style TargetType="{x:Type Paragraph}" x:Key="{x:Static markdig:Styles.ParagraphStyleKey}">
  <Setter Property="Margin" Value="0,0,0,10" />
</Style>

That should help with what you are needing. In the meantime, you can workaround by setting it to all Paragraph in your control or page (headings and codeblocks already have their own style, so they shouldn't be affected.

<Style TargetType="{x:Type Paragraph}">
  <Setter Property="Margin" Value="0,0,0,10" />
</Style>

However, it could break some other parts so that's why I want to introduce a new dedicated style key. And on that topic, I also probably need to add one for the List object itself as it seems it already adds some kind of space between each levels that is a bit unfortunate, especially when combined with the above change.

There might be something we can also do with the styles on either List or ListItem.

[mengluwang121]

Thanks for the answer :)! I'll work around it by applying paragraph style for now and come back when this enhancement is added to the package! Really appreciate your help!

Best,
Menglu

[mengluwang121]

You were right, with the paragraph work around we are seeing some extra spacing for the normal bullet items, cannot see which is better so I'll wait for the improvement. Could you please inform me if the improvement is completed? Thank you so much!

[mengluwang121]

Hi Nicolas, I am wondering is the paragraph feature available now? Also, as I replied on the other thread. Our repo cannot target to .net4.5.2 yet... (since it is shipped along with win7) I am wondering could we added back the support for .net4.5? Thank you so very much!!!

Best,
Menglu

[mengluwang121]

Also, I noticed for the sub listview item, normal html will not add paragraph tag within the listViewItem, while here we are adding the paragraph tag. So as I added the paragraph style, the list view style was broken. It seems html have different handling for the first level list and sub level list (first level list adding paragraph wrap while sub list doesn't)

[Kryptos-FR]

I have some ideas on how to deal with those cases, but I hardly had time to work on any project except work during the last couple of weeks.

[mengluwang121]

Totally understand! Due to the .net 45 version issue at the same time, we decide to work around in our end. (Basically dynamically change the first layer paragraph style) Thank you so much for all the help here~! Hope you have a great day!