Skip to content
This repository was archived by the owner on Jul 31, 2022. It is now read-only.

Commit 9484b89

Browse files
committed
Optimize #toString
1 parent 11f4410 commit 9484b89

File tree

5 files changed

+38
-26
lines changed

5 files changed

+38
-26
lines changed

src/main/java/com/kttdevelopment/simplehttpserver/handler/ExchangeThrottler.java

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -60,13 +60,10 @@ int getMaxConnections(final HttpExchange exchange){
6060

6161
@Override
6262
public String toString(){
63-
final StringBuilder OUT = new StringBuilder();
64-
65-
OUT.append("ExchangeThrottler") .append('{');
66-
OUT.append("connections") .append('=') .append(connections.toString());
67-
OUT.append('}');
68-
69-
return OUT.toString();
63+
return
64+
"Exchange Throttler" + '{' +
65+
"connections" + '=' + connections.toString() +
66+
'}';
7067
}
7168

7269
}

src/main/java/com/kttdevelopment/simplehttpserver/handler/ServerExchangeThrottler.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,4 +128,14 @@ public synchronized final int getMaxServerConnections(){
128128
return uConnMax.get();
129129
}
130130

131+
@Override
132+
public String toString(){
133+
return
134+
"ServerExchangeThrottler" + '{' +
135+
"connections" + '=' + connections.toString() + ", " +
136+
"userConnections" + '=' + uConn + ", " +
137+
"userConnectionsMax" + '=' + uConnMax +
138+
'}';
139+
}
140+
131141
}

src/main/java/com/kttdevelopment/simplehttpserver/handler/ServerSessionThrottler.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -149,4 +149,15 @@ public synchronized final int getMaxServerConnections(){
149149
return uConnMax.get();
150150
}
151151

152+
@Override
153+
public String toString(){
154+
return
155+
"ServerSessionThrottler" + '{' +
156+
"sessionHandler" + '=' + sessionHandler + ", " +
157+
"connections" + '=' + connections.toString() + ", " +
158+
"userConnections" + '=' + uConn + ", " +
159+
"userConnectionsMax" + '=' + uConnMax +
160+
'}';
161+
}
162+
152163
}

src/main/java/com/kttdevelopment/simplehttpserver/handler/SessionThrottler.java

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -178,18 +178,16 @@ int getMaxConnections(final HttpSession session, final HttpExchange exchange){
178178

179179
//
180180

181-
@SuppressWarnings("StringBufferReplaceableByString")
182181
@Override
183182
public String toString(){
184-
final StringBuilder OUT = new StringBuilder();
185-
186-
OUT.append("SessionThrottler") .append('{');
187-
OUT.append("condition") .append('=') .append(countsTowardsLimit) .append(", ");
188-
OUT.append("sessions@depreciated") .append('=') .append(connections.toString()).append(", ");
189-
OUT.append("maxConnections@depreciated") .append('=') .append(maxConnections.get());
190-
OUT.append('}');
191-
192-
return OUT.toString();
183+
return
184+
"SessionThrottler" + '{' +
185+
"condition@depreciated" + '=' + countsTowardsLimit + ", " +
186+
"sessions@depreciated" + '=' + connections.toString() + ", " +
187+
"maxConnections@depreciated" + '=' + maxConnections.get() + ", " +
188+
"sessionHandler" + '=' + sessionHandler + ", " +
189+
"connections" + '=' + connections.toString() + ", " +
190+
'}';
193191
}
194192

195193
}

src/main/java/com/kttdevelopment/simplehttpserver/handler/ThrottledHandler.java

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -50,17 +50,13 @@ public final void handle(final HttpExchange exchange) throws IOException{
5050
}
5151
}
5252

53-
@SuppressWarnings("StringBufferReplaceableByString")
5453
@Override
5554
public String toString(){
56-
final StringBuilder OUT = new StringBuilder();
57-
58-
OUT.append("ThrottledHandler") .append('{');
59-
OUT.append("handler") .append('=') .append(handler) .append(", ");
60-
OUT.append("throttler") .append('=') .append(throttler);
61-
OUT.append('}');
62-
63-
return OUT.toString();
55+
return
56+
"ThrottledHandler" + '{' +
57+
"handler" + '=' + handler + ", " +
58+
"throttler" + '=' + throttler +
59+
'}';
6460
}
6561

6662
}

0 commit comments

Comments
 (0)