error screen fixes, not sure why this was so overcomplicated before, now it's not

Author: MaxNeedsSnacks

src/main/java/dev/latvian/mods/kubejs/DevProperties.java

@@ -2,6 +2,10 @@
 
 import dev.latvian.mods.kubejs.util.BaseProperties;
 
+import java.util.Locale;
+
+import static dev.latvian.mods.kubejs.client.EditorExt.*;
+
 public class DevProperties extends BaseProperties {
 	private static DevProperties instance;
 
@@ -36,6 +40,7 @@ public static void reload() {
 	public boolean strictTags;
 	public boolean alwaysCaptureErrors;
 	public boolean reloadOnFileSave;
+	public String openUriFormat;
 	public String kubedexSound;
 
 	private DevProperties() {
@@ -64,5 +69,13 @@ protected void load() {
 		alwaysCaptureErrors = get("always_capture_errors", false);
 		reloadOnFileSave = get("reload_on_file_save", false);
 		kubedexSound = get("kubedex_sound", "entity.experience_orb.pickup");
+
+		var format = get("open_uri_format", "vscode");
+		openUriFormat = switch (format.toLowerCase(Locale.ROOT)) {
+			case "vscode" -> VSCODE;
+			case "vscodium" -> VSCODIUM;
+			case "vscode-oss" -> VSCODE_OSS;
+			default -> format;
+		};
 	}
 }

src/main/java/dev/latvian/mods/kubejs/client/EditorExt.java

@@ -0,0 +1,39 @@
+package dev.latvian.mods.kubejs.client;
+
+import dev.latvian.mods.kubejs.DevProperties;
+import net.minecraft.Util;
+
+import java.net.URI;
+import java.nio.file.Path;
+
+public class EditorExt {
+	public static final String VSCODE = vsLikeScheme("vscode");
+	public static final String VSCODIUM = vsLikeScheme("vscodium");
+	public static final String VSCODE_OSS = vsLikeScheme("vscode-oss");
+
+	private static String vsLikeScheme(String prefix) {
+		return prefix + "://file{path}:{line}:{col}";
+	}
+
+	public static boolean isKnownVSCode() {
+		var custom = DevProperties.get().openUriFormat;
+		return !custom.isEmpty() && (custom.equals(VSCODE) || custom.equals(VSCODIUM) || custom.equals(VSCODE_OSS));
+	}
+
+	private static URI format(String scheme, Path path, int line, int column) {
+		return URI.create(scheme
+			.replace("{path}", path.toString())
+			.replace("{line}", String.valueOf(line))
+			.replace("{col}", String.valueOf(column))
+		);
+	}
+
+	public static void openFile(Path path, int line, int column) {
+		var custom = DevProperties.get().openUriFormat;
+		if (!custom.isBlank()) {
+			Util.getPlatform().openUri(format(custom, path, line, column));
+		} else {
+			Util.getPlatform().openPath(path);
+		}
+	}
+}

src/main/java/dev/latvian/mods/kubejs/client/KubeJSClientEventHandler.java

@@ -100,10 +100,6 @@ public class KubeJSClientEventHandler {
 	public static void setupClient(FMLClientSetupEvent event) {
 		KubeJS.PROXY = new KubeJSClient();
 		event.enqueueWork(KubeJSClientEventHandler::setupClient0);
-
-		if (VSCodeExt.isInstalled()) {
-			ConsoleJS.CLIENT.info("VSCode " + VSCodeExt.getVersion() + " detected");
-		}
 	}
 
 	@SubscribeEvent

src/main/java/dev/latvian/mods/kubejs/client/KubeJSErrorScreen.java

@@ -290,16 +290,15 @@ public void render(GuiGraphics g, int idx, int y, int x, int w, int h, int mx, i
 					}
 
 					if (ln > 0) {
-						if (VSCodeExt.isInstalled()) {
-							var comp = Component.empty();
-							comp.append("Double-click to Open in ");
+						var comp = Component.empty();
+						comp.append("Double-click to open file");
+
+						if (EditorExt.isKnownVSCode()) {
+							comp.append(" in ");
 							comp.append(TextIcons.icons("V."));
 							comp.append(Component.literal("VSCode").withColor(0x22A7F2));
-							lines.addAll(minecraft.font.split(comp, 1000));
-
-						} else {
-							lines.add(FormattedCharSequence.forward("Double-click to Open File", Style.EMPTY));
 						}
+						lines.addAll(minecraft.font.split(comp, 1000));
 					}
 
 					for (var line : line.sourceLines) {
@@ -365,20 +364,16 @@ public void open() {
 						path = path.getParent();
 					}
 
-					if (VSCodeExt.isInstalled()) {
-						int ln = 1;
+					int ln = 1;
 
-						for (var line : line.sourceLines) {
-							if (line.line() > 0 && line.source().endsWith(".js")) {
-								ln = line.line();
-								break;
-							}
+					for (var line : line.sourceLines) {
+						if (line.line() > 0 && line.source().endsWith(".js")) {
+							ln = line.line();
+							break;
 						}
-
-						VSCodeExt.openFile(path, ln, 0);
-					} else {
-						errorList.screen.handleComponentClicked(Style.EMPTY.withClickEvent(new ClickEvent(ClickEvent.Action.OPEN_FILE, path.toAbsolutePath().toString())));
 					}
+
+					EditorExt.openFile(path, ln, 0);
 				}
 			}
 		}